Change the signature of method addTextSource() in AwesomePlayer

James Dong · James Dong · commit 23cc716cc529 · 2012-02-09T17:32:57.000-08:00
o avoid a unnecessary copy constructor call

Change-Id: Ib598bbe42d42a835549e2d29502c6f196f859874
diff --git a/media/libstagefright/AwesomePlayer.cpp b/media/libstagefright/AwesomePlayer.cpp
@@ -1360,7 +1360,7 @@ void AwesomePlayer::setAudioSource(sp<MediaSource> source) {
     mAudioTrack = source;
 }
 
-void AwesomePlayer::addTextSource(sp<MediaSource> source) {
+void AwesomePlayer::addTextSource(const sp<MediaSource>& source) {
     Mutex::Autolock autoLock(mTimedTextLock);
     CHECK(source != NULL);
 
diff --git a/media/libstagefright/include/AwesomePlayer.h b/media/libstagefright/include/AwesomePlayer.h
@@ -258,7 +258,7 @@ struct AwesomePlayer {
     void setVideoSource(sp<MediaSource> source);
     status_t initVideoDecoder(uint32_t flags = 0);
 
-    void addTextSource(sp<MediaSource> source);
+    void addTextSource(const sp<MediaSource>& source);
 
     void onStreamDone();
 

Original file line number	Diff line number	Diff line change
`@@ -1360,7 +1360,7 @@ void AwesomePlayer::setAudioSource(sp<MediaSource> source) {`
`1360`	`1360`	`mAudioTrack = source;`
`1361`	`1361`	`}`
`1362`	`1362`
`1363`		`-void AwesomePlayer::addTextSource(sp<MediaSource> source) {`
	`1363`	`+void AwesomePlayer::addTextSource(const sp<MediaSource>& source) {`
`1364`	`1364`	`Mutex::Autolock autoLock(mTimedTextLock);`
`1365`	`1365`	`CHECK(source != NULL);`
`1366`	`1366`