Skip to content

Commit 232a698

Browse files
Henrik HallJean-Baptiste Queru
authored andcommitted
Fix data type of RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS in RIL.
Fixing incorrect data type of RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS in Android RIL. The Android RIL specifies that the unsolicited response signal RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS should contain a raw byte array (ril.h). However, in the implementation of the Java RIL and the C++ RIL daemon, the data is unpacked as a string. This causes data delivered from the network stack to be garbled. Changing so that both the C++ RIL deamon in platform/hardware/ril and the Java RIL in frameworks/base follows the specification. Change-Id: I9b9b26d16cd39422c43d9fa7aadfcff3e60c78ae
1 parent 0a5174a commit 232a698

File tree

1 file changed

+1
-1
lines changed
  • telephony/java/com/android/internal/telephony

1 file changed

+1
-1
lines changed

telephony/java/com/android/internal/telephony/RIL.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2329,7 +2329,7 @@ private RILRequest findAndRemoveRequestFromList(int serial) {
23292329
case RIL_UNSOL_RESTRICTED_STATE_CHANGED: ret = responseInts(p); break;
23302330
case RIL_UNSOL_RESPONSE_SIM_STATUS_CHANGED: ret = responseVoid(p); break;
23312331
case RIL_UNSOL_RESPONSE_CDMA_NEW_SMS: ret = responseCdmaSms(p); break;
2332-
case RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS: ret = responseString(p); break;
2332+
case RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS: ret = responseRaw(p); break;
23332333
case RIL_UNSOL_CDMA_RUIM_SMS_STORAGE_FULL: ret = responseVoid(p); break;
23342334
case RIL_UNSOL_ENTER_EMERGENCY_CALLBACK_MODE: ret = responseVoid(p); break;
23352335
case RIL_UNSOL_CDMA_CALL_WAITING: ret = responseCdmaCallWaiting(p); break;

0 commit comments

Comments
 (0)