Skip to content

Commit 20c53cb

Browse files
James DongAndroid (Google) Code Review
authored andcommitted
Merge "Remove obsolete TODO comments"
2 parents 22d4184 + e1103cf commit 20c53cb

File tree

6 files changed

+4
-139
lines changed

6 files changed

+4
-139
lines changed

media/tests/MediaFrameworkTest/src/com/android/mediaframeworktest/functional/videoeditor/MediaItemThumbnailTest.java

Lines changed: 3 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ protected void validateThumbnail(Bitmap thumbNailBmp, int outWidth,
8282
/**
8383
* To test thumbnail / frame extraction on H.263 QCIF.
8484
*/
85-
// TODO : TC_TN_001
8685
@LargeTest
8786
public void testThumbnailForH263QCIF() throws Exception {
8887
final String videoItemFilename = INPUT_FILE_PATH
@@ -104,7 +103,6 @@ public void testThumbnailForH263QCIF() throws Exception {
104103
/**
105104
* To test thumbnail / frame extraction on MPEG4 VGA .
106105
*/
107-
// TODO : TC_TN_002
108106
@LargeTest
109107
public void testThumbnailForMPEG4VGA() throws Exception {
110108
final String videoItemFilename = INPUT_FILE_PATH +
@@ -124,7 +122,6 @@ public void testThumbnailForMPEG4VGA() throws Exception {
124122
/**
125123
* To test thumbnail / frame extraction on MPEG4 NTSC.
126124
*/
127-
// TODO : TC_TN_003
128125
@LargeTest
129126
public void testThumbnailForMPEG4NTSC() throws Exception {
130127
final String videoItemFilename = INPUT_FILE_PATH
@@ -144,7 +141,6 @@ public void testThumbnailForMPEG4NTSC() throws Exception {
144141
/**
145142
* To test thumbnail / frame extraction on MPEG4 WVGA.
146143
*/
147-
// TODO : TC_TN_004
148144
@LargeTest
149145
public void testThumbnailForMPEG4WVGA() throws Exception {
150146

@@ -165,7 +161,6 @@ public void testThumbnailForMPEG4WVGA() throws Exception {
165161
/**
166162
* To test thumbnail / frame extraction on MPEG4 QCIF.
167163
*/
168-
// TODO : TC_TN_005
169164
@LargeTest
170165
public void testThumbnailForMPEG4QCIF() throws Exception {
171166
final String videoItemFilename = INPUT_FILE_PATH
@@ -186,7 +181,6 @@ public void testThumbnailForMPEG4QCIF() throws Exception {
186181
/**
187182
* To test thumbnail / frame extraction on H264 QCIF.
188183
*/
189-
// TODO : TC_TN_006
190184
@LargeTest
191185
public void testThumbnailForH264QCIF() throws Exception {
192186
final String videoItemFilename = INPUT_FILE_PATH
@@ -207,7 +201,6 @@ public void testThumbnailForH264QCIF() throws Exception {
207201
/**
208202
* To test thumbnail / frame extraction on H264 VGA.
209203
*/
210-
// TODO : TC_TN_007
211204
@LargeTest
212205
public void testThumbnailForH264VGA() throws Exception {
213206
final String videoItemFilename = INPUT_FILE_PATH +
@@ -228,7 +221,6 @@ public void testThumbnailForH264VGA() throws Exception {
228221
/**
229222
* To test thumbnail / frame extraction on H264 WVGA.
230223
*/
231-
// TODO : TC_TN_008
232224
@LargeTest
233225
public void testThumbnailForH264WVGA() throws Exception {
234226
final String videoItemFilename = INPUT_FILE_PATH +
@@ -248,7 +240,6 @@ public void testThumbnailForH264WVGA() throws Exception {
248240
/**
249241
* To test thumbnail / frame extraction on H264 854x480.
250242
*/
251-
// TODO : TC_TN_009
252243
@LargeTest
253244
public void testThumbnailForH264854_480() throws Exception {
254245
final String videoItemFilename = INPUT_FILE_PATH
@@ -269,7 +260,6 @@ public void testThumbnailForH264854_480() throws Exception {
269260
/**
270261
* To test thumbnail / frame extraction on H264 960x720.
271262
*/
272-
// TODO : TC_TN_010
273263
@LargeTest
274264
public void testThumbnailForH264HD960() throws Exception {
275265
final String videoItemFilename = INPUT_FILE_PATH +
@@ -290,7 +280,6 @@ public void testThumbnailForH264HD960() throws Exception {
290280
/**
291281
* To test thumbnail / frame extraction on H264 1080x720 .
292282
*/
293-
// TODO : TC_TN_011
294283
@LargeTest
295284
public void testThumbnailForH264HD1080() throws Exception {
296285
final String videoItemFilename = INPUT_FILE_PATH +
@@ -310,7 +299,6 @@ public void testThumbnailForH264HD1080() throws Exception {
310299
/**
311300
* Check the thumbnail / frame extraction precision at 0,100 and 200 ms
312301
*/
313-
// TODO : TC_TN_012
314302
@LargeTest
315303
public void testThumbnailForH264VGADifferentDuration() throws Exception {
316304
final String videoItemFilename = INPUT_FILE_PATH +
@@ -345,7 +333,6 @@ public void testThumbnailForH264VGADifferentDuration() throws Exception {
345333
*Check the thumbnail / frame extraction precision at
346334
* FileDuration,FileDuration/2 + 100 andFileDuration/2 + 200 ms
347335
*/
348-
// TODO : TC_TN_013
349336
@LargeTest
350337
public void testThumbnailForMP4VGA() throws Exception {
351338
final String videoItemFilename = INPUT_FILE_PATH +
@@ -379,7 +366,6 @@ public void testThumbnailForMP4VGA() throws Exception {
379366
/**
380367
* Check the thumbnail / frame extraction on JPEG file
381368
*/
382-
// TODO : TC_TN_014
383369
@LargeTest
384370
public void testThumbnailForImage() throws Exception {
385371
final String imageItemFilename = INPUT_FILE_PATH + "IMG_640x480.jpg";
@@ -402,7 +388,6 @@ public void testThumbnailForImage() throws Exception {
402388
/**
403389
*To test ThumbnailList for H263 QCIF
404390
*/
405-
// TODO : TC_TN_015
406391
@LargeTest
407392
public void testThumbnailListH263QCIF() throws Exception {
408393
final String videoItemFilename = INPUT_FILE_PATH
@@ -432,7 +417,6 @@ public void testThumbnailListH263QCIF() throws Exception {
432417
/**
433418
*To test ThumbnailList for MPEG4 QCIF
434419
*/
435-
// TODO : TC_TN_016
436420
@LargeTest
437421
public void testThumbnailListMPEG4QCIF() throws Exception {
438422
final String videoItemFilename = INPUT_FILE_PATH
@@ -463,7 +447,6 @@ public void testThumbnailListMPEG4QCIF() throws Exception {
463447
/**
464448
*To test ThumbnailList for H264 VGA
465449
*/
466-
// TODO : TC_TN_017
467450
@LargeTest
468451
public void testThumbnailListH264VGA() throws Exception {
469452
final String videoItemFilename = INPUT_FILE_PATH +
@@ -492,7 +475,6 @@ public void testThumbnailListH264VGA() throws Exception {
492475
/**
493476
*To test ThumbnailList for H264 WVGA
494477
*/
495-
// TODO : TC_TN_018
496478
@LargeTest
497479
public void testThumbnailListH264WVGA() throws Exception {
498480
final String videoItemFilename = INPUT_FILE_PATH +
@@ -521,7 +503,6 @@ public void testThumbnailListH264WVGA() throws Exception {
521503
/**
522504
*To test ThumbnailList for H264 VGA ,Time exceeding file duration
523505
*/
524-
// TODO : TC_TN_019
525506
@LargeTest
526507
public void testThumbnailH264VGAExceedingFileDuration() throws Exception {
527508
final String videoItemFilename = INPUT_FILE_PATH +
@@ -547,7 +528,6 @@ public void testThumbnailH264VGAExceedingFileDuration() throws Exception {
547528
/**
548529
*To test ThumbnailList for VGA Image
549530
*/
550-
// TODO : TC_TN_020
551531
@LargeTest
552532
public void testThumbnailListVGAImage() throws Exception {
553533
final String imageItemFilename = INPUT_FILE_PATH + "IMG_640x480.jpg";
@@ -576,7 +556,6 @@ public void testThumbnailListVGAImage() throws Exception {
576556
/**
577557
*To test ThumbnailList for Invalid file path
578558
*/
579-
// TODO : TC_TN_021
580559
@LargeTest
581560
public void testThumbnailForInvalidFilePath() throws Exception {
582561
final String imageItemFileName = INPUT_FILE_PATH + "/sdcard/abc.jpg";
@@ -596,7 +575,6 @@ public void testThumbnailForInvalidFilePath() throws Exception {
596575
/**
597576
* To test thumbnail / frame extraction with setBoundaries
598577
*/
599-
// TODO : TC_TN_022
600578
@LargeTest
601579
public void testThumbnailForMPEG4WVGAWithSetBoundaries() throws Exception {
602580
final String videoItemFilename = INPUT_FILE_PATH +
@@ -620,7 +598,6 @@ public void testThumbnailForMPEG4WVGAWithSetBoundaries() throws Exception {
620598
/**
621599
*To test ThumbnailList for H264 WVGA with setExtractboundaries
622600
*/
623-
// TODO : TC_TN_023
624601
@LargeTest
625602
public void testThumbnailListForH264WVGAWithSetBoundaries() throws Exception {
626603
final String videoItemFilename = INPUT_FILE_PATH +
@@ -652,7 +629,6 @@ public void testThumbnailListForH264WVGAWithSetBoundaries() throws Exception {
652629
/**
653630
*To test ThumbnailList for H264 WVGA with count > frame available
654631
*/
655-
// TODO : TC_TN_024
656632
@LargeTest
657633
public void testThumbnailListForH264WVGAWithCount() throws Exception {
658634
final String videoItemFilename = INPUT_FILE_PATH +
@@ -684,7 +660,6 @@ public void testThumbnailListForH264WVGAWithCount() throws Exception {
684660
/**
685661
*To test ThumbnailList for H264 WVGA with startTime > End Time
686662
*/
687-
// TODO : TC_TN_025
688663
@LargeTest
689664
public void testThumbnailListH264WVGAWithStartGreaterEnd() throws Exception {
690665
final String videoItemFilename = INPUT_FILE_PATH +
@@ -710,9 +685,8 @@ public void testThumbnailListH264WVGAWithStartGreaterEnd() throws Exception {
710685
}
711686

712687
/**
713-
*To test ThumbnailList TC_TN_026 for H264 WVGA with startTime = End Time
688+
*To test ThumbnailList for H264 WVGA with startTime = End Time
714689
*/
715-
// TODO : TC_TN_026
716690
@LargeTest
717691
public void testThumbnailListH264WVGAWithStartEqualEnd() throws Exception {
718692
final String videoItemFilename = INPUT_FILE_PATH +
@@ -738,10 +712,9 @@ public void testThumbnailListH264WVGAWithStartEqualEnd() throws Exception {
738712
}
739713

740714
/**
741-
*To test ThumbnailList TC_TN_027 for file where video duration is less
715+
*To test ThumbnailList for file where video duration is less
742716
* than file duration.
743717
*/
744-
// TODO : TC_TN_027
745718
@LargeTest
746719
public void testThumbnailForVideoDurationLessFileDuration() throws Exception {
747720
final String videoItemFilename = INPUT_FILE_PATH
@@ -760,9 +733,8 @@ public void testThumbnailForVideoDurationLessFileDuration() throws Exception {
760733
}
761734

762735
/**
763-
*To test ThumbnailList TC_TN_028 for file which has video part corrupted
736+
*To test ThumbnailList for file which has video part corrupted
764737
*/
765-
// TODO : TC_TN_028
766738
@LargeTest
767739
public void testThumbnailWithCorruptedVideoPart() throws Exception {
768740
final String videoItemFilename = INPUT_FILE_PATH +
@@ -787,7 +759,6 @@ public void testThumbnailWithCorruptedVideoPart() throws Exception {
787759
/**
788760
* Check the thumbnail / frame list extraction for Height as Negative Value
789761
*/
790-
// TODO : TC_TN_029
791762
@LargeTest
792763
public void testThumbnailWithNegativeHeight() throws Exception {
793764
final String videoItemFilename = INPUT_FILE_PATH
@@ -815,7 +786,6 @@ public void testThumbnailWithNegativeHeight() throws Exception {
815786
/**
816787
* Check the thumbnail for Height as Zero
817788
*/
818-
// TODO : TC_TN_030
819789
@LargeTest
820790
public void testThumbnailWithHeightAsZero() throws Exception {
821791
final String videoItemFilename = INPUT_FILE_PATH
@@ -839,7 +809,6 @@ public void testThumbnailWithHeightAsZero() throws Exception {
839809
/**
840810
* Check the thumbnail for Height = 10
841811
*/
842-
// TODO : TC_TN_031
843812
@LargeTest
844813
public void testThumbnailWithHeight() throws Exception {
845814
final String videoItemFilename = INPUT_FILE_PATH
@@ -859,7 +828,6 @@ public void testThumbnailWithHeight() throws Exception {
859828
/**
860829
* Check the thumbnail / frame list extraction for Width as Negative Value
861830
*/
862-
// TODO : TC_TN_032
863831
@LargeTest
864832
public void testThumbnailWithNegativeWidth() throws Exception {
865833
final String videoItemFilename = INPUT_FILE_PATH
@@ -887,7 +855,6 @@ public void testThumbnailWithNegativeWidth() throws Exception {
887855
/**
888856
* Check the thumbnail / frame list extraction for Width zero
889857
*/
890-
// TODO : TC_TN_033
891858
@LargeTest
892859
public void testThumbnailWithWidthAsZero() throws Exception {
893860
final String videoItemFilename = INPUT_FILE_PATH
@@ -911,7 +878,6 @@ public void testThumbnailWithWidthAsZero() throws Exception {
911878
/**
912879
* Check the thumbnail for Width = 10
913880
*/
914-
// TODO : TC_TN_034
915881
@LargeTest
916882
public void testThumbnailWithWidth() throws Exception {
917883
final String videoItemFilename = INPUT_FILE_PATH
@@ -931,7 +897,6 @@ public void testThumbnailWithWidth() throws Exception {
931897
/**
932898
* To test thumbnail / frame extraction on MPEG4 (time beyond file duration).
933899
*/
934-
// TODO : TC_TN_035
935900
@LargeTest
936901
public void testThumbnailMPEG4withMorethanFileDuration() throws Exception {
937902
final String videoItemFilename = INPUT_FILE_PATH

0 commit comments

Comments
 (0)