Handle GET_POWER failures

isheriff · isheriff · commit 1a5b6098d500 · 2011-05-04T14:23:42.000-07:00
Return a failure when GET_POWER returns a non-conforming
format

Bug: 4380317
Change-Id: If1ce73572ae261cd6998e4289e21112c88859437
diff --git a/core/jni/android_net_wifi_Wifi.cpp b/core/jni/android_net_wifi_Wifi.cpp
@@ -402,7 +402,9 @@ static jint android_net_wifi_getPowerModeCommand(JNIEnv* env, jobject clazz)
     }
     // reply comes back in the form "powermode = XX" where XX is the
     // number we're interested in.
-    sscanf(reply, "%*s = %u", &power);
+    if (sscanf(reply, "%*s = %u", &power) != 1) {
+        return (jint)-1;
+    }
     return (jint)power;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,9 @@ static jint android_net_wifi_getPowerModeCommand(JNIEnv* env, jobject clazz)`
`402`	`402`	`}`
`403`	`403`	`// reply comes back in the form "powermode = XX" where XX is the`
`404`	`404`	`// number we're interested in.`
`405`		`- sscanf(reply, "%*s = %u", &power);`
	`405`	`+ if (sscanf(reply, "%*s = %u", &power) != 1) {`
	`406`	`+ return (jint)-1;`
	`407`	`+ }`
`406`	`408`	`return (jint)power;`
`407`	`409`	`}`
`408`	`410`