Skip to content

Commit 19a07d9

Browse files
sganovAndroid (Google) Code Review
authored andcommitted
Merge "AccessibilityServiceInfo does not convert correctly feedback type to string."
2 parents dc4bb3f + c6c25f9 commit 19a07d9

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

core/java/android/accessibilityservice/AccessibilityServiceInfo.java

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -503,26 +503,38 @@ private static void appendFlags(StringBuilder stringBuilder, int flags) {
503503
public static String feedbackTypeToString(int feedbackType) {
504504
StringBuilder builder = new StringBuilder();
505505
builder.append("[");
506-
while (feedbackType > 0) {
506+
while (feedbackType != 0) {
507507
final int feedbackTypeFlag = 1 << Integer.numberOfTrailingZeros(feedbackType);
508508
feedbackType &= ~feedbackTypeFlag;
509-
if (builder.length() > 1) {
510-
builder.append(", ");
511-
}
512509
switch (feedbackTypeFlag) {
513510
case FEEDBACK_AUDIBLE:
511+
if (builder.length() > 1) {
512+
builder.append(", ");
513+
}
514514
builder.append("FEEDBACK_AUDIBLE");
515515
break;
516516
case FEEDBACK_HAPTIC:
517+
if (builder.length() > 1) {
518+
builder.append(", ");
519+
}
517520
builder.append("FEEDBACK_HAPTIC");
518521
break;
519522
case FEEDBACK_GENERIC:
523+
if (builder.length() > 1) {
524+
builder.append(", ");
525+
}
520526
builder.append("FEEDBACK_GENERIC");
521527
break;
522528
case FEEDBACK_SPOKEN:
529+
if (builder.length() > 1) {
530+
builder.append(", ");
531+
}
523532
builder.append("FEEDBACK_SPOKEN");
524533
break;
525534
case FEEDBACK_VISUAL:
535+
if (builder.length() > 1) {
536+
builder.append(", ");
537+
}
526538
builder.append("FEEDBACK_VISUAL");
527539
break;
528540
}

0 commit comments

Comments
 (0)