Skip to content

Commit 17b9cec

Browse files
Dianne HackbornAndroid (Google) Code Review
authored andcommitted
Merge "Fix issue #6636731: Mariner animation ring gets stuck" into jb-dev
2 parents 4de60b2 + 6e3d6da commit 17b9cec

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

services/java/com/android/server/am/ActivityRecord.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,9 @@ void dump(PrintWriter pw, String prefix) {
164164
if (pendingResults != null) {
165165
pw.print(prefix); pw.print("pendingResults="); pw.println(pendingResults);
166166
}
167+
if (pendingOptions != null) {
168+
pw.print(prefix); pw.print("pendingOptions="); pw.println(pendingOptions);
169+
}
167170
if (uriPermissions != null) {
168171
if (uriPermissions.readUriPermissions != null) {
169172
pw.print(prefix); pw.print("readUriPermissions=");
@@ -202,7 +205,7 @@ void dump(PrintWriter pw, String prefix) {
202205
if (lastVisibleTime != 0 || waitingVisible || nowVisible) {
203206
pw.print(prefix); pw.print("waitingVisible="); pw.print(waitingVisible);
204207
pw.print(" nowVisible="); pw.print(nowVisible);
205-
pw.print("lastVisibleTime=");
208+
pw.print(" lastVisibleTime=");
206209
TimeUtils.formatDuration(lastVisibleTime, pw); pw.println("");
207210
}
208211
if (configDestroy || configChangeFlags != 0) {
@@ -453,6 +456,7 @@ void takeFromHistory() {
453456
if (task != null && !finishing) {
454457
task.numActivities--;
455458
}
459+
clearOptionsLocked();
456460
}
457461
}
458462

@@ -466,6 +470,9 @@ void makeFinishing() {
466470
if (task != null && inHistory) {
467471
task.numActivities--;
468472
}
473+
if (stopped) {
474+
clearOptionsLocked();
475+
}
469476
}
470477
}
471478

services/java/com/android/server/am/ActivityStack.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1055,7 +1055,9 @@ final void activityStoppedLocked(ActivityRecord r, Bundle icicle, Bitmap thumbna
10551055
mHandler.removeMessages(STOP_TIMEOUT_MSG, r);
10561056
r.stopped = true;
10571057
r.state = ActivityState.STOPPED;
1058-
if (!r.finishing) {
1058+
if (r.finishing) {
1059+
r.clearOptionsLocked();
1060+
} else {
10591061
if (r.configDestroy) {
10601062
destroyActivityLocked(r, true, false, "stop-config");
10611063
resumeTopActivityLocked(null);

0 commit comments

Comments
 (0)