Skip to content

Commit 166c1b2

Browse files
psanketiAndroid (Google) Code Review
authored andcommitted
Merge "Fixing bug in SurfaceMediaSource_test"
2 parents ec64655 + 3814ff4 commit 166c1b2

File tree

1 file changed

+19
-5
lines changed

1 file changed

+19
-5
lines changed

media/libstagefright/tests/SurfaceMediaSource_test.cpp

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,6 @@ class GLTest : public ::testing::Test {
156156
eglDestroySurface(mEglDisplay, mEglSurface);
157157
}
158158
if (mEglDisplay != EGL_NO_DISPLAY) {
159-
eglMakeCurrent(mEglDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE,
160-
EGL_NO_CONTEXT);
161159
eglTerminate(mEglDisplay);
162160
}
163161
ASSERT_EQ(EGL_SUCCESS, eglGetError());
@@ -461,6 +459,7 @@ void SurfaceMediaSourceGLTest::oneBufferPassGL(int num) {
461459

462460
// The following call dequeues and queues the buffer
463461
eglSwapBuffers(mEglDisplay, mEglSurface);
462+
ASSERT_EQ(EGL_SUCCESS, eglGetError());
464463
glDisable(GL_SCISSOR_TEST);
465464
}
466465

@@ -796,7 +795,12 @@ TEST_F(SurfaceMediaSourceGLTest, ChooseAndroidRecordableEGLConfigDummyWriter) {
796795
LOGV("framesCount = %d", nFramesCount);
797796
}
798797

799-
ASSERT_EQ(NO_ERROR, native_window_api_disconnect(mANW.get(), NATIVE_WINDOW_API_EGL));
798+
EXPECT_TRUE(eglMakeCurrent(mEglDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE,
799+
EGL_NO_CONTEXT));
800+
ASSERT_EQ(EGL_SUCCESS, eglGetError());
801+
eglDestroySurface(mEglDisplay, mEglSurface);
802+
mEglSurface = EGL_NO_SURFACE;
803+
800804
writer.stop();
801805
}
802806
// Test to examine whether we can render GL buffers in to the surface
@@ -875,7 +879,12 @@ TEST_F(SurfaceMediaSourceGLTest, EncodingFromGLRgbaSameImageEachBufNpotWrite) {
875879
LOGV("framesCount = %d", nFramesCount);
876880
}
877881

878-
ASSERT_EQ(NO_ERROR, native_window_api_disconnect(mANW.get(), NATIVE_WINDOW_API_EGL));
882+
EXPECT_TRUE(eglMakeCurrent(mEglDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE,
883+
EGL_NO_CONTEXT));
884+
ASSERT_EQ(EGL_SUCCESS, eglGetError());
885+
eglDestroySurface(mEglDisplay, mEglSurface);
886+
mEglSurface = EGL_NO_SURFACE;
887+
879888
LOGV("Stopping MediaRecorder...");
880889
CHECK_EQ(OK, mr->stop());
881890
mr.clear();
@@ -913,7 +922,12 @@ TEST_F(SurfaceMediaSourceGLTest, EncodingFromGLRgbaDiffImageEachBufNpotWrite) {
913922
LOGV("framesCount = %d", nFramesCount);
914923
}
915924

916-
ASSERT_EQ(NO_ERROR, native_window_api_disconnect(mANW.get(), NATIVE_WINDOW_API_EGL));
925+
EXPECT_TRUE(eglMakeCurrent(mEglDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE,
926+
EGL_NO_CONTEXT));
927+
ASSERT_EQ(EGL_SUCCESS, eglGetError());
928+
eglDestroySurface(mEglDisplay, mEglSurface);
929+
mEglSurface = EGL_NO_SURFACE;
930+
917931
LOGV("Stopping MediaRecorder...");
918932
CHECK_EQ(OK, mr->stop());
919933
mr.clear();

0 commit comments

Comments
 (0)