Skip to content

Commit 1552586

Browse files
jsharkeyAndroid (Google) Code Review
authored andcommitted
Merge "Clean up firewall interface method names." into jb-mr1-dev
2 parents 34f8631 + 2c09298 commit 1552586

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

core/java/android/os/INetworkManagementService.aidl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -365,8 +365,8 @@ interface INetworkManagementService
365365

366366
void setFirewallEnabled(boolean enabled);
367367
boolean isFirewallEnabled();
368-
void setInterfaceFirewallRule(String iface, boolean allow);
369-
void setEgressSourceFirewallRule(String addr, boolean allow);
370-
void setEgressDestFirewallRule(String addr, int port, boolean allow);
371-
void setUidFirewallRule(int uid, boolean allow);
368+
void setFirewallInterfaceRule(String iface, boolean allow);
369+
void setFirewallEgressSourceRule(String addr, boolean allow);
370+
void setFirewallEgressDestRule(String addr, int port, boolean allow);
371+
void setFirewallUidRule(int uid, boolean allow);
372372
}

services/java/com/android/server/NetworkManagementService.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1451,7 +1451,7 @@ public boolean isFirewallEnabled() {
14511451
}
14521452

14531453
@Override
1454-
public void setInterfaceFirewallRule(String iface, boolean allow) {
1454+
public void setFirewallInterfaceRule(String iface, boolean allow) {
14551455
mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG);
14561456
Preconditions.checkState(mFirewallEnabled);
14571457
final String rule = allow ? ALLOW : DENY;
@@ -1463,7 +1463,7 @@ public void setInterfaceFirewallRule(String iface, boolean allow) {
14631463
}
14641464

14651465
@Override
1466-
public void setEgressSourceFirewallRule(String addr, boolean allow) {
1466+
public void setFirewallEgressSourceRule(String addr, boolean allow) {
14671467
mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG);
14681468
Preconditions.checkState(mFirewallEnabled);
14691469
final String rule = allow ? ALLOW : DENY;
@@ -1475,7 +1475,7 @@ public void setEgressSourceFirewallRule(String addr, boolean allow) {
14751475
}
14761476

14771477
@Override
1478-
public void setEgressDestFirewallRule(String addr, int port, boolean allow) {
1478+
public void setFirewallEgressDestRule(String addr, int port, boolean allow) {
14791479
mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG);
14801480
Preconditions.checkState(mFirewallEnabled);
14811481
final String rule = allow ? ALLOW : DENY;
@@ -1487,7 +1487,7 @@ public void setEgressDestFirewallRule(String addr, int port, boolean allow) {
14871487
}
14881488

14891489
@Override
1490-
public void setUidFirewallRule(int uid, boolean allow) {
1490+
public void setFirewallUidRule(int uid, boolean allow) {
14911491
mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG);
14921492
Preconditions.checkState(mFirewallEnabled);
14931493
final String rule = allow ? ALLOW : DENY;

0 commit comments

Comments
 (0)