Skip to content

Commit 11167b8

Browse files
Jeff BrownAndroid (Google) Code Review
authored andcommitted
Merge "Make the screen brightness setting limits configurable." into jb-mr1-dev
2 parents 572a085 + f9bba13 commit 11167b8

File tree

3 files changed

+24
-13
lines changed

3 files changed

+24
-13
lines changed

core/java/android/os/PowerManager.java

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -239,13 +239,6 @@ public final class PowerManager {
239239
*/
240240
public static final int BRIGHTNESS_OFF = 0;
241241

242-
/**
243-
* A nominal default brightness value.
244-
* Use {@link #getDefaultScreenBrightnessSetting()} instead.
245-
* @hide
246-
*/
247-
private static final int BRIGHTNESS_DEFAULT = 102;
248-
249242
// Note: Be sure to update android.os.BatteryStats and PowerManager.h
250243
// if adding or modifying user activity event constants.
251244

@@ -321,7 +314,7 @@ public PowerManager(Context context, IPowerManager service, Handler handler) {
321314
*/
322315
public int getMinimumScreenBrightnessSetting() {
323316
return mContext.getResources().getInteger(
324-
com.android.internal.R.integer.config_screenBrightnessDim);
317+
com.android.internal.R.integer.config_screenBrightnessSettingMinimum);
325318
}
326319

327320
/**
@@ -331,15 +324,17 @@ public int getMinimumScreenBrightnessSetting() {
331324
* @hide
332325
*/
333326
public int getMaximumScreenBrightnessSetting() {
334-
return BRIGHTNESS_ON;
327+
return mContext.getResources().getInteger(
328+
com.android.internal.R.integer.config_screenBrightnessSettingMaximum);
335329
}
336330

337331
/**
338332
* Gets the default screen brightness setting.
339333
* @hide
340334
*/
341335
public int getDefaultScreenBrightnessSetting() {
342-
return BRIGHTNESS_DEFAULT;
336+
return mContext.getResources().getInteger(
337+
com.android.internal.R.integer.config_screenBrightnessSettingDefault);
343338
}
344339

345340
/**

core/res/res/values/config.xml

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -554,9 +554,22 @@
554554
<integer-array name="config_autoBrightnessLevels">
555555
</integer-array>
556556

557-
558-
<!-- Minimum screen brightness allowed by the power manager. -->
559-
<integer name="config_screenBrightnessDim">20</integer>
557+
<!-- Minimum screen brightness setting allowed by the power manager.
558+
The user is forbidden from setting the brightness below this level. -->
559+
<integer name="config_screenBrightnessSettingMinimum">10</integer>
560+
561+
<!-- Maximum screen brightness allowed by the power manager.
562+
The user is forbidden from setting the brightness above this level. -->
563+
<integer name="config_screenBrightnessSettingMaximum">255</integer>
564+
565+
<!-- Default screen brightness setting.
566+
Must be in the range specified by minimum and maximum. -->
567+
<integer name="config_screenBrightnessSettingDefault">102</integer>
568+
569+
<!-- Screen brightness used to dim the screen when the user activity
570+
timeout expires. May be less than the minimum allowed brightness setting
571+
that can be set by the user. -->
572+
<integer name="config_screenBrightnessDim">10</integer>
560573

561574
<!-- Array of output values for LCD backlight corresponding to the LUX values
562575
in the config_autoBrightnessLevels array. This array should have size one greater

core/res/res/values/public.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1471,6 +1471,9 @@
14711471
<java-symbol type="integer" name="config_notificationsBatteryLowARGB" />
14721472
<java-symbol type="integer" name="config_notificationsBatteryMediumARGB" />
14731473
<java-symbol type="integer" name="config_radioScanningTimeout" />
1474+
<java-symbol type="integer" name="config_screenBrightnessSettingMinimum" />
1475+
<java-symbol type="integer" name="config_screenBrightnessSettingMaximum" />
1476+
<java-symbol type="integer" name="config_screenBrightnessSettingDefault" />
14741477
<java-symbol type="integer" name="config_screenBrightnessDim" />
14751478
<java-symbol type="integer" name="config_virtualKeyQuietTimeMillis" />
14761479
<java-symbol type="layout" name="am_compat_mode_dialog" />

0 commit comments

Comments
 (0)