Skip to content

Commit 0922389

Browse files
Samyeoul ChoiRobert Greenwalt
authored andcommitted
Crespo4G: Voicemail: Add 'config_telephony_...' for Sprint
'*86' which is set now as a default at CDMAPhone.java, is default voicemail number for Verizon. For Sprint, we use user's own number for voicemail. So we add codes in CDMAPhone.java to use 'config_telephony_use_own_number_for_voicemail', and use config.xml to set this value as false. Then we overlay Sprint's own config.xml file to override 'config_telephony_use_own_number_for_voicemail' as a true. Change-Id: I110914bdfa9a79aaba89d3b80edbcf044e9aabee
1 parent 9e5b1a4 commit 0922389

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

core/res/res/values/config.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,4 +377,7 @@
377377
<!-- Do not translate. Defines the slots is Two Digit Number for dialing normally not USSD -->
378378
<string-array name="config_twoDigitNumberPattern">
379379
</string-array>
380+
381+
<!-- The VoiceMail default value is displayed to my own number if it is true -->
382+
<bool name="config_telephony_use_own_number_for_voicemail">false</bool>
380383
</resources>

telephony/java/com/android/internal/telephony/cdma/CDMAPhone.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -730,7 +730,14 @@ public String getVoiceMailNumber() {
730730
String number = null;
731731
SharedPreferences sp = PreferenceManager.getDefaultSharedPreferences(getContext());
732732
// TODO: The default value of voicemail number should be read from a system property
733-
number = sp.getString(VM_NUMBER_CDMA, "*86");
733+
734+
// Read platform settings for dynamic voicemail number
735+
if (getContext().getResources().getBoolean(com.android.internal
736+
.R.bool.config_telephony_use_own_number_for_voicemail)) {
737+
number = sp.getString(VM_NUMBER_CDMA, getLine1Number());
738+
} else {
739+
number = sp.getString(VM_NUMBER_CDMA, "*86");
740+
}
734741
return number;
735742
}
736743

0 commit comments

Comments
 (0)