some performance stuff

Author: Haehnchen

src/main/java/fr/adrienbrault/idea/symfony2plugin/codeInspection/form/FormTypeAsClassConstantInspection.java

@@ -27,7 +27,7 @@ public class FormTypeAsClassConstantInspection extends LocalInspectionTool {
 
     @NotNull
     public PsiElementVisitor buildVisitor(final @NotNull ProblemsHolder holder, boolean isOnTheFly) {
-        if(!Symfony2ProjectComponent.isEnabled(holder.getProject()) || !SymfonyUtil.isVersionGreaterThenEquals(holder.getProject(), "2.8")) {
+        if(!Symfony2ProjectComponent.isEnabled(holder.getProject())) {
             return super.buildVisitor(holder, isOnTheFly);
         }
 
@@ -36,23 +36,32 @@ public PsiElementVisitor buildVisitor(final @NotNull ProblemsHolder holder, bool
 
     private static class MyPsiElementVisitor extends PsiElementVisitor {
         private final ProblemsHolder holder;
+        private Boolean isVersionGreaterThenEquals = null;
 
         MyPsiElementVisitor(ProblemsHolder holder) {
             this.holder = holder;
         }
 
         @Override
         public void visitElement(PsiElement element) {
-            if(!(element instanceof MethodReference) ||
-                !ArrayUtil.contains(((MethodReference) element).getName(), "add", "create") ||
-                !PhpElementsUtil.isMethodReferenceInstanceOf((MethodReference) element, "Symfony\\Component\\Form\\FormBuilderInterface")
+            if(!(element instanceof MethodReference methodReference) ||
+                !ArrayUtil.contains(methodReference.getName(), "add", "create") ||
+                !PhpElementsUtil.isMethodReferenceInstanceOf(methodReference, "Symfony\\Component\\Form\\FormBuilderInterface")
                 ) {
 
                 super.visitElement(element);
                 return;
             }
 
-            PsiElement[] parameters = ((MethodReference) element).getParameters();
+            if (isVersionGreaterThenEquals == null) {
+                isVersionGreaterThenEquals = SymfonyUtil.isVersionGreaterThenEquals(holder.getProject(), "2.8");
+            }
+
+            if (!isVersionGreaterThenEquals) {
+                return;
+            }
+
+            PsiElement[] parameters = methodReference.getParameters();
             if(parameters.length < 2) {
                 super.visitElement(element);
                 return;