修复 MultipleSourceVersionList 不会使用备用下载源的问题#5585
Merged
Glavo merged 2 commits intoHMCL-dev:mainfrom Feb 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where MultipleSourceVersionList was not properly falling back to alternative download sources when the primary source failed. The original implementation used thenComposeAsync, which only executes when the dependent task succeeds, preventing the fallback mechanism from working. The new implementation creates a custom Task wrapper that uses isRelyingOnDependents() = false to ensure execute() is called even when dependents fail, allowing it to detect failures and create fallback tasks dynamically.
Changes:
- Replaced
thenComposeAsyncpattern with custom Task wrapper that handles dependent failures - Implemented dynamic dependency creation for fallback sources
- Preserved exception handling and logging for all sources exhausted
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HMCLCore/src/main/java/org/jackhuang/hmcl/download/MultipleSourceVersionList.java
Show resolved
Hide resolved
Glavo
added a commit
to Glavo/HMCL
that referenced
this pull request
Feb 20, 2026
Glavo
added a commit
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.