From 8435452fe7e18dee65eaaadbdd3e7de8d0b504cd Mon Sep 17 00:00:00 2001 From: Ghzdude <44148655+ghzdude@users.noreply.github.com> Date: Wed, 2 Jul 2025 20:53:06 -0700 Subject: [PATCH 1/2] default to true when checking notify world --- .../java/gregtech/api/metatileentity/SyncedTileEntityBase.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/gregtech/api/metatileentity/SyncedTileEntityBase.java b/src/main/java/gregtech/api/metatileentity/SyncedTileEntityBase.java index 148bed2b78f..6952609db20 100644 --- a/src/main/java/gregtech/api/metatileentity/SyncedTileEntityBase.java +++ b/src/main/java/gregtech/api/metatileentity/SyncedTileEntityBase.java @@ -76,7 +76,8 @@ private boolean canNotifyWorld() { return false; } } - return false; + // assume we can send data regardless + return true; } @Override From 115f4c6f329ab1bd77322abd2f4cf0099722ed5e Mon Sep 17 00:00:00 2001 From: Ghzdude <44148655+ghzdude@users.noreply.github.com> Date: Wed, 2 Jul 2025 21:44:38 -0700 Subject: [PATCH 2/2] replace literal with a named constant --- .../java/gregtech/api/metatileentity/SyncedTileEntityBase.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/gregtech/api/metatileentity/SyncedTileEntityBase.java b/src/main/java/gregtech/api/metatileentity/SyncedTileEntityBase.java index 6952609db20..a36b9bc0772 100644 --- a/src/main/java/gregtech/api/metatileentity/SyncedTileEntityBase.java +++ b/src/main/java/gregtech/api/metatileentity/SyncedTileEntityBase.java @@ -26,6 +26,7 @@ public abstract class SyncedTileEntityBase extends BlockStateTileEntity implements ISyncedTileEntity { + public static final int SIZE_THRESHOLD = 10; private final PacketDataList updates = new PacketDataList(); public @Nullable TileEntity getNeighbor(EnumFacing facing) { @@ -65,7 +66,7 @@ private void notifyWorld() { private boolean canNotifyWorld() { // short circuit with packet size to avoid too many hash lookups and instanceof casts - if (updates.size() > 10 && getWorld() instanceof WorldServer server) { + if (updates.size() > SIZE_THRESHOLD && getWorld() instanceof WorldServer server) { int x = getPos().getX() >> 4; int z = getPos().getZ() >> 4; if (server.getPlayerChunkMap().contains(x, z)) {