[2.0.0-SNAPSHOT]

LogQueryBuilderImpl address validation added

Author: GoodforGod

src/main/java/io/goodforgod/api/etherscan/manager/impl/SemaphoreRequestQueueManager.java

@@ -31,8 +31,8 @@ public SemaphoreRequestQueueManager(int size, Duration resetIn, Duration delayIn
     public SemaphoreRequestQueueManager(int size, Duration queueResetTimeIn, Duration delayIn, int initialSize) {
         this.semaphore = new Semaphore(initialSize);
         this.queueResetTimeInMillis = queueResetTimeIn.toMillis();
-        this.executorService.scheduleAtFixedRate(releaseLocks(size + 1), delayIn.toMillis(), queueResetTimeInMillis,
-                TimeUnit.MILLISECONDS);
+        this.executorService.scheduleAtFixedRate(releaseLocks(size + 1),
+                delayIn.toMillis(), queueResetTimeInMillis, TimeUnit.MILLISECONDS);
     }
 
     @SuppressWarnings("java:S899")

src/main/java/io/goodforgod/api/etherscan/model/query/LogQueryBuilderImpl.java

@@ -21,6 +21,7 @@ final class LogQueryBuilderImpl implements LogQuery.Builder {
     private final long startBlock, endBlock;
 
     LogQueryBuilderImpl(String address, long startBlock, long endBlock) {
+        BasicUtils.validateAddress(address);
         this.address = address;
         this.startBlock = startBlock;
         this.endBlock = endBlock;

src/test/java/io/goodforgod/api/etherscan/EtherScanAPITests.java

@@ -1,7 +1,7 @@
 package io.goodforgod.api.etherscan;
 
+import io.goodforgod.api.etherscan.error.EtherScanConnectionException;
 import io.goodforgod.api.etherscan.error.EtherScanKeyException;
-import io.goodforgod.api.etherscan.error.EtherScanTimeoutException;
 import io.goodforgod.api.etherscan.http.EthHttpClient;
 import io.goodforgod.api.etherscan.http.impl.UrlEthHttpClient;
 import io.goodforgod.api.etherscan.model.Balance;
@@ -70,7 +70,7 @@ void timeout() throws InterruptedException {
         Supplier<EthHttpClient> supplier = () -> new UrlEthHttpClient(Duration.ofMillis(300), Duration.ofMillis(300));
         EtherScanAPI api = EtherScanAPI.builder().withApiKey(getApiKey()).withNetwork(EthNetworks.KOVAN).withHttpClient(supplier)
                 .build();
-        assertThrows(EtherScanTimeoutException.class,
+        assertThrows(EtherScanConnectionException.class,
                 () -> api.account().blocksMined("0x0010f94b296A852aAac52EA6c5Ac72e03afD032D"));
     }
 }

src/test/java/io/goodforgod/api/etherscan/logs/LogsApiTest.java

@@ -38,10 +38,10 @@ static Stream<Arguments> source() {
                 .build();
 
         return Stream.of(
-                Arguments.of(single, 423),
+                Arguments.of(single, 424),
                 Arguments.of(singleInvalidAddr, 0),
                 Arguments.of(tupleAnd, 1),
-                Arguments.of(tupleOr, 425));
+                Arguments.of(tupleOr, 426));
     }
 
     @ParameterizedTest