Fix NPM publishing once and for all (#3811)

SamyPesse · web-flow · commit 27a461be9d50 · 2025-11-16T02:16:20.000+01:00
diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
@@ -29,6 +29,9 @@ jobs:
               with:
                   node-version: 22
                   registry-url: 'https://registry.npmjs.org'
+            # Ensure npm 11.5.1 or later is installed
+            - name: Update npm
+              run: npm install -g npm@latest
             - name: Setup Bun
               uses: ./.github/composite/setup-bun
             - name: Install dependencies
@@ -39,13 +42,10 @@ jobs:
               id: changesets
               uses: changesets/action@v1
               with:
+                  publish: bun run publish-all-packages
                   version: bun run changeset-version
               env:
                   # Using a PAT instead of GITHUB_TOKEN because we need to run workflows when releases are created
                   # https://github.com/orgs/community/discussions/26875#discussioncomment-3253761
                   GITHUB_TOKEN: ${{ secrets.GH_PERSONAL_TOKEN }}
 
-            # We use a dedicated step to publish to npm because it needs the top level GITHUB_TOKEN and not the GH_PERSONAL_TOKEN one
-            - name: Publish to NPM
-              if: steps.changesets.outputs.hasChangesets == 'false'
-              run: bun run publish-all-packages
diff --git a/package.json b/package.json
@@ -32,7 +32,7 @@
         "e2e-customers": "turbo run e2e-customers",
         "changeset": "changeset",
         "changeset-version": "changeset version && bun run format && bun update",
-        "publish-all-packages": "turbo run publish-to-npm",
+        "publish-all-packages": "turbo run publish-to-npm --continue=dependencies-successful",
         "download:env": "op read op://gitbook-x-dev/gitbook-open/.env.local >> .env.local",
         "clean": "turbo run clean"
     },
diff --git a/packages/browser-types/package.json b/packages/browser-types/package.json
@@ -29,5 +29,8 @@
     "publishConfig": {
         "access": "public",
         "registry": "https://registry.npmjs.org/"
+    },
+    "repository": {
+        "url": "https://github.com/GitbookIO/gitbook"
     }
 }
diff --git a/packages/cache-tags/package.json b/packages/cache-tags/package.json
@@ -28,5 +28,8 @@
     "publishConfig": {
         "access": "public",
         "registry": "https://registry.npmjs.org/"
+    },
+    "repository": {
+        "url": "https://github.com/GitbookIO/gitbook"
     }
 }
diff --git a/packages/colors/package.json b/packages/colors/package.json
@@ -24,5 +24,8 @@
     "publishConfig": {
         "access": "public",
         "registry": "https://registry.npmjs.org/"
+    },
+    "repository": {
+        "url": "https://github.com/GitbookIO/gitbook"
     }
 }
diff --git a/packages/embed/package.json b/packages/embed/package.json
@@ -41,5 +41,8 @@
     "publishConfig": {
         "access": "public",
         "registry": "https://registry.npmjs.org/"
+    },
+    "repository": {
+        "url": "https://github.com/GitbookIO/gitbook"
     }
 }
diff --git a/packages/expr/package.json b/packages/expr/package.json
@@ -40,5 +40,8 @@
     "publishConfig": {
         "access": "public",
         "registry": "https://registry.npmjs.org/"
+    },
+    "repository": {
+        "url": "https://github.com/GitbookIO/gitbook"
     }
 }
diff --git a/packages/fonts/package.json b/packages/fonts/package.json
@@ -34,5 +34,8 @@
     "publishConfig": {
         "access": "public",
         "registry": "https://registry.npmjs.org/"
+    },
+    "repository": {
+        "url": "https://github.com/GitbookIO/gitbook"
     }
 }
diff --git a/packages/gitbook/turbo.json b/packages/gitbook/turbo.json
@@ -11,6 +11,9 @@
         },
         "typecheck": {
             "dependsOn": ["^typecheck", "generate"]
+        },
+        "publish-to-npm": {
+            "dependsOn": []
         }
     }
 }
diff --git a/packages/icons/package.json b/packages/icons/package.json
@@ -52,5 +52,8 @@
     "publishConfig": {
         "access": "public",
         "registry": "https://registry.npmjs.org/"
+    },
+    "repository": {
+        "url": "https://github.com/GitbookIO/gitbook"
     }
 }
diff --git a/packages/openapi-parser/package.json b/packages/openapi-parser/package.json
@@ -35,5 +35,8 @@
     "publishConfig": {
         "access": "public",
         "registry": "https://registry.npmjs.org/"
+    },
+    "repository": {
+        "url": "https://github.com/GitbookIO/gitbook"
     }
 }
diff --git a/packages/react-contentkit/package.json b/packages/react-contentkit/package.json
@@ -35,5 +35,8 @@
     "publishConfig": {
         "access": "public",
         "registry": "https://registry.npmjs.org/"
+    },
+    "repository": {
+        "url": "https://github.com/GitbookIO/gitbook"
     }
 }
diff --git a/packages/react-math/package.json b/packages/react-math/package.json
@@ -40,5 +40,8 @@
     "publishConfig": {
         "access": "public",
         "registry": "https://registry.npmjs.org/"
+    },
+    "repository": {
+        "url": "https://github.com/GitbookIO/gitbook"
     }
 }
diff --git a/packages/react-openapi/package.json b/packages/react-openapi/package.json
@@ -57,5 +57,8 @@
     "publishConfig": {
         "access": "public",
         "registry": "https://registry.npmjs.org/"
+    },
+    "repository": {
+        "url": "https://github.com/GitbookIO/gitbook"
     }
 }
diff --git a/scripts/publish-if-new.sh b/scripts/publish-if-new.sh
@@ -8,9 +8,6 @@
 
 set -euo pipefail
 
-echo "Node auth token: ${NODE_AUTH_TOKEN}"
-echo "NPM config userconfig: ${NPM_CONFIG_USERCONFIG}"
-
 NAME=$(node -p "require('./package.json').name")
 VERSION=$(node -p "require('./package.json').version")
 
@@ -41,4 +38,4 @@ fi
 trap 'rm -f "${TARBALL_PATH}"' EXIT
 
 # Publish with verbose logging to aid debugging
-npm publish "${TARBALL_PATH}" --no-workspaces --provenance --loglevel=verbose
+npm publish "${TARBALL_PATH}" --no-workspaces --provenance
diff --git a/turbo.json b/turbo.json
@@ -57,7 +57,7 @@
         "publish-to-npm": {
             "dependsOn": ["build"],
             "cache": false,
-            "env": ["NODE_AUTH_TOKEN", "NPM_CONFIG_USERCONFIG", "ACTIONS_ID_TOKEN_*"]
+            "env": ["NODE_AUTH_TOKEN", "NPM_*", "ACTIONS_ID_TOKEN_*", "SIGSTORE_*"]
         },
         // Clean up the package
         "clean": {

Original file line number	Diff line number	Diff line change
`@@ -29,5 +29,8 @@`
`29`	`29`	`"publishConfig": {`
`30`	`30`	`"access": "public",`
`31`	`31`	`"registry": "https://registry.npmjs.org/"`
	`32`	`+ },`
	`33`	`+ "repository": {`
	`34`	`+ "url": "https://github.com/GitbookIO/gitbook"`
`32`	`35`	`}`
`33`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,5 +28,8 @@`
`28`	`28`	`"publishConfig": {`
`29`	`29`	`"access": "public",`
`30`	`30`	`"registry": "https://registry.npmjs.org/"`
	`31`	`+ },`
	`32`	`+ "repository": {`
	`33`	`+ "url": "https://github.com/GitbookIO/gitbook"`
`31`	`34`	`}`
`32`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,5 +24,8 @@`
`24`	`24`	`"publishConfig": {`
`25`	`25`	`"access": "public",`
`26`	`26`	`"registry": "https://registry.npmjs.org/"`
	`27`	`+ },`
	`28`	`+ "repository": {`
	`29`	`+ "url": "https://github.com/GitbookIO/gitbook"`
`27`	`30`	`}`
`28`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,5 +41,8 @@`
`41`	`41`	`"publishConfig": {`
`42`	`42`	`"access": "public",`
`43`	`43`	`"registry": "https://registry.npmjs.org/"`
	`44`	`+ },`
	`45`	`+ "repository": {`
	`46`	`+ "url": "https://github.com/GitbookIO/gitbook"`
`44`	`47`	`}`
`45`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,5 +40,8 @@`
`40`	`40`	`"publishConfig": {`
`41`	`41`	`"access": "public",`
`42`	`42`	`"registry": "https://registry.npmjs.org/"`
	`43`	`+ },`
	`44`	`+ "repository": {`
	`45`	`+ "url": "https://github.com/GitbookIO/gitbook"`
`43`	`46`	`}`
`44`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,5 +34,8 @@`
`34`	`34`	`"publishConfig": {`
`35`	`35`	`"access": "public",`
`36`	`36`	`"registry": "https://registry.npmjs.org/"`
	`37`	`+ },`
	`38`	`+ "repository": {`
	`39`	`+ "url": "https://github.com/GitbookIO/gitbook"`
`37`	`40`	`}`
`38`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,9 @@`
`11`	`11`	`},`
`12`	`12`	`"typecheck": {`
`13`	`13`	`"dependsOn": ["^typecheck", "generate"]`
	`14`	`+ },`
	`15`	`+ "publish-to-npm": {`
	`16`	`+ "dependsOn": []`
`14`	`17`	`}`
`15`	`18`	`}`
`16`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,5 +52,8 @@`
`52`	`52`	`"publishConfig": {`
`53`	`53`	`"access": "public",`
`54`	`54`	`"registry": "https://registry.npmjs.org/"`
	`55`	`+ },`
	`56`	`+ "repository": {`
	`57`	`+ "url": "https://github.com/GitbookIO/gitbook"`
`55`	`58`	`}`
`56`	`59`	`}`