Skip to content

Add SensitiveParameter attribute to Client::authenticate() #859

@prudloff-insite

Description

@prudloff-insite

It is a good practice to add #[\SensitiveParameter] to sensitive arguments. It prevents them from leaking in stack traces.
The $token argument in Client::authenticate() is sensitive and should probably be protected:

public function authenticate(#[\SensitiveParameter] string $token, string $authMethod, ?string $sudo = null): void

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions