Skip to content

Unimplemented validation for extension_data field in FRProject.__post_init__ #3

@harshith1118

Description

@harshith1118

In pmp_manip/core/project.py at line 147, there's a commented-out TODO that should validate the
extension_data field:

TODO #if self.extension_data != {}: raise MANIP_ThanksError() # also uncomment test

This validation is currently disabled, which means the code doesn't enforce that the extension_data field
should always be empty as expected. According to the TODO comment, there's also a corresponding test that
needs to be uncommented.

Impact:
The project might accept invalid state where extension_data contains non-empty data
Lacks proper validation that could catch potential issues early
Incomplete implementation as indicated by the TODO

Location: pmp_manip/core/project.py, line 147 in the post_init method of the FRProject class

Suggestion:
Uncomment and implement the validation that raises MANIP_ThanksError when extension_data is not empty
Uncomment the corresponding test mentioned in the TODO
Verify that this validation aligns with the expected behavior of the extension_data field

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions