fix(oxlint): integration of oxlint

components added

Author: MaxNumerique

.oxlintrc.json

@@ -7,28 +7,51 @@
     "style": "error",
     "restriction": "error"
   },
-  "plugins": ["import", "node", "oxc", "promise", "unicorn", "vitest"],
+  "plugins": ["import", "node", "oxc", "promise", "unicorn", "vue"],
   "rules": {
     "unicorn/filename-case": [
       "error",
       {
-        "case": "snakeCase"
+        "cases": {
+          "snakeCase": true
+        }
       }
     ],
-    "eslint/func-style": [
+    "eslint/func-style": ["error", "declaration"],
+    "eslint/sort-keys": "off",
+    "eslint/no-ternary": "off", // A utiliser pour des opérations simples
+    "oxc/no-async-await": "off",
+    "oxc/no-rest-spread-properties": "off", // Enable if older browser support is needed
+    "eslint/max-statements": ["warn", 20],
+    "eslint/id-length": ["error", { "exceptions": ["x", "y", "z", "i", "j", "k"], "min": 2 }],
+    "eslint/no-console": "warn", // Disable for debugging. Disable later to not have browser logs
+    "unicorn/numeric-separators-style": "off", // 1_000 ou 1000 ?
+    "sort-imports": ["error", { "allowSeparatedGroups": true }],
+    "eslint/curly": "off", // Quick statement in one line
+    "eslint/no-undefined": "off", // Conflict with unicorn/no-typeof-undefined which prefers direct undefined comparison
+    "unicorn/no-null": "warn", // A débattre ?
+    "import/prefer-default-export": "off",
+    "import/no-named-export": "off",
+    "unicorn/prefer-global-this": "off",
+    "import/unambiguous": "off",
+    "oxc/no-optional-chaining": "off",
+    "node/no-process-env": "off",
+    "capitalized-comments": "warn",
+    "unicorn/consistent-existence-index-check": "off",  // Opérateur < > remplacés par !== -1 for index check
+    "unicorn/require-post-message-target-origin": "off", // lorsqu'on envoie un message avec postMessage, on doit spécifier l'origin
+    "unicorn/prefer-structured-clone": "off", // Pas compatible avec plugin Pinia ?
+    "eslint/no-magic-numbers": [
       "error",
       {
-        "style:": "declaration"
+        "ignore": [-1, 0, 1, 2, 4],
+        "ignoreArrayIndexes": true
       }
     ],
-    "eslint/sort-keys": "off",
-    "eslint/no-ternary": "off",
-    "import/no-named-export": "off",
-    "import/prefer-default-export": "off"
+    "vue/max-props": ["error", { "maxProps": 7 }]
   },
   "overrides": [
     {
-      "files": ["**/components/*"],
+      "files": ["app/components/**"],
       "rules": {
         "unicorn/filename-case": [
           "error",
@@ -37,6 +60,18 @@
           }
         ]
       }
+    },
+    {
+      "files": ["*.js", "app/plugins/**"],
+      "rules": {
+        "import/no-default-export": "off"
+      }
+    },
+    {
+      "files": ["utils/**"],
+      "rules": {
+        "promise/prefer-await-to-callbacks": "off"
+      }
     }
   ]
 }

app/components/Carousel.vue

@@ -1,14 +1,17 @@
 <script setup>
+  // oxlint-disable-next-line import/no-unassigned-import
   import "vue3-carousel/dist/carousel.css"
-  import { Carousel, Slide, Navigation, Pagination } from "vue3-carousel"
+  import { Carousel, Navigation, Pagination, Slide } from "vue3-carousel"
   import { useDisplay } from "vuetify"
 
-  const props = defineProps({
+  const NB_ITEMS_TO_DISPLAY = 3
+
+  const { items } = defineProps({
     items: { type: Array, required: true },
   })
 
   const { name } = useDisplay()
-  const nb_items_to_display = ref(3)
+  const nb_items_to_display = ref(NB_ITEMS_TO_DISPLAY)
   watch(
     name,
     (value) => {
@@ -46,7 +49,7 @@
   <ClientOnly>
     <Carousel :settings="carrousel_settings">
       <Slide
-        v-for="(item, index) in props.items"
+        v-for="(item, index) in items"
         :key="index"
         class="carousel__slide"
       >

app/components/CrsSelector.vue

@@ -1,21 +1,20 @@
 <script setup>
   import schemas from "@geode/opengeodeweb-back/opengeodeweb_back_schemas.json"
-  const schema = schemas.opengeodeweb_back.geographic_coordinate_systems
   import { useGeodeStore } from "@ogw_front/stores/geode"
 
+  const schema = schemas.opengeodeweb_back.geographic_coordinate_systems
+
   const emit = defineEmits([
     "update_values",
     "increment_step",
     "decrement_step",
   ])
 
-  const props = defineProps({
+  const { geode_object_type, key_to_update } = defineProps({
     geode_object_type: { type: String, required: true },
     key_to_update: { type: String, required: true },
   })
 
-  const { geode_object_type, key_to_update } = props
-
   const search = ref("")
   const data_table_loading = ref(false)
   const crs_list = ref([])
@@ -33,8 +32,8 @@
   })
 
   function get_selected_crs(crs_code) {
-    for (let i = 0; i <= crs_list.value.length; i++) {
-      if (crs_list.value[i]["code"] == crs_code) {
+    for (let i = 0; i <= crs_list.value.length; i += 1) {
+      if (crs_list.value[i]["code"] === crs_code) {
         return crs_list.value[i]
       }
     }

app/components/DragAndDrop.vue

@@ -1,5 +1,5 @@
 <script setup>
-  const props = defineProps({
+  const { multiple, accept, loading, showExtensions, idleText, dropText, loadingText } = defineProps({
     multiple: { type: Boolean, default: false },
     accept: { type: String, default: "" },
     loading: { type: Boolean, default: false },
@@ -14,18 +14,20 @@
   const isDragging = ref(false)
   const fileInput = ref(null)
 
-  const triggerFileDialog = () => fileInput.value?.click()
+  function triggerFileDialog() {
+    fileInput.value?.click()
+  }
 
-  function handleDrop(e) {
+  function handleDrop(event) {
     isDragging.value = false
-    const files = Array.from(e.dataTransfer.files)
+    const files = [...event.dataTransfer.files]
     emit("files-selected", files)
   }
 
-  function handleFileSelect(e) {
-    const files = Array.from(e.target.files)
+  function handleFileSelect(event) {
+    const files = [...event.target.files]
     emit("files-selected", files)
-    e.target.value = ""
+    event.target.value = ""
   }
 </script>
 

app/components/ExtensionSelector.vue

@@ -11,11 +11,10 @@
     "decrement_step",
   ])
 
-  const props = defineProps({
+  const { geode_object_type, filenames } = defineProps({
     geode_object_type: { type: String, required: true },
     filenames: { type: Array, required: true },
   })
-  const { geode_object_type, filenames } = props
   const geode_objects_and_output_extensions = ref({})
   const loading = ref(false)
 
@@ -25,27 +24,20 @@
     toggle_loading()
     geode_objects_and_output_extensions.value = {}
     const geodeStore = useGeodeStore()
-    const promise_array = filenames.map((filename) => {
-      return new Promise((resolve, reject) => {
-        const params = {
+    const values = await Promise.all(
+      filenames.map(async (filename) => {
+        const response = await geodeStore.request(schema, {
           geode_object_type,
           filename,
-        }
-        geodeStore.request(schema, params, {
-          request_error_function: () => reject(),
-          response_function: (response) => {
-            resolve(response.geode_objects_and_output_extensions)
-          },
-          response_error_function: () => reject(),
         })
-      })
-    })
-    const values = await Promise.all(promise_array)
+        return response.geode_objects_and_output_extensions
+      }),
+    )
     const all_keys = [...new Set(values.flatMap((value) => Object.keys(value)))]
     const common_keys = all_keys.filter(
       (i) => !values.some((j) => !Object.keys(j).includes(i)),
     )
-    var final_object = {}
+    const final_object = {}
     for (const key of common_keys) {
       final_object[key] = {}
       for (const value of values) {
@@ -61,7 +53,7 @@
   }
 
   function update_values(output_geode_object, output_extension) {
-    if (output_geode_object != "" && output_extension != "") {
+    if (output_geode_object !== "" && output_extension !== "") {
       emit("update_values", {
         output_geode_object,
         output_extension,

app/components/FeedBack/Snackers.vue

@@ -1,11 +1,15 @@
 <script setup>
   import { useFeedbackStore } from "@ogw_front/stores/feedback"
 
+  const MARGIN_BETWEEN_SNACKERS = 60
+  const FIRST_SNACKER_MARGIN = 8
+
+
   const feedbackStore = useFeedbackStore()
   const show = ref(true)
 
   function calc_margin(index) {
-    return index * 60 + 8 + "px"
+    return `${index * MARGIN_BETWEEN_SNACKERS + FIRST_SNACKER_MARGIN}px`
   }
 </script>
 

app/components/FileSelector.vue

@@ -13,31 +13,35 @@
     "decrement_step",
   ])
 
-  const props = defineProps({
+  const { multiple, files, auto_upload } = defineProps({
     multiple: { type: Boolean, required: true },
     files: { type: Array, default: () => [] },
     auto_upload: { type: Boolean, default: true },
   })
 
-  const internal_files = ref(props.files)
-  const auto_upload = ref(props.auto_upload)
+  const internal_files = ref(files)
+  const internal_auto_upload = ref(auto_upload)
   const accept = ref("")
   const loading = ref(false)
 
   watch(
-    () => props.files,
-    (val) => (internal_files.value = val),
+    () => files,
+    (val) => {
+      internal_files.value = val
+    },
   )
 
   watch(
-    () => props.auto_upload,
-    (val) => (auto_upload.value = val),
+    () => auto_upload,
+    (val) => {
+      internal_auto_upload.value = val
+    },
   )
 
   const toggle_loading = useToggle(loading)
 
   function files_uploaded_event(value) {
-    if (value.length) {
+    if (value.length > 0) {
       emit("update_values", { files: value, auto_upload: false })
       emit("increment_step")
     }
@@ -47,7 +51,7 @@
     toggle_loading()
     const geodeStore = useGeodeStore()
     const response = await geodeStore.request(schema, {})
-    accept.value = response.extensions.map((e) => `.${e}`).join(",")
+    accept.value = response.extensions.map((extension) => `.${extension}`).join(",")
     toggle_loading()
   }
 
@@ -58,7 +62,7 @@
   <FetchingData v-if="loading" />
   <FileUploader
     v-else
-    v-bind="{ multiple, accept, files: internal_files, auto_upload }"
+    v-bind="{ multiple, accept, files: internal_files, auto_upload: internal_auto_upload }"
     @files_uploaded="files_uploaded_event"
   />
 </template>