From a400206149a8f795b0bc34a231d96f7fe2868f92 Mon Sep 17 00:00:00 2001
From: Andrea Aime <andrea.aime@gmail.com>
Date: Sun, 18 May 2025 16:21:45 +0200
Subject: [PATCH 1/2] Updating errorprone to 2.31

---
 geowebcache/pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/geowebcache/pom.xml b/geowebcache/pom.xml
index 6a2dc7818..aa9eada9a 100644
--- a/geowebcache/pom.xml
+++ b/geowebcache/pom.xml
@@ -87,7 +87,7 @@
     <jackson.databind.version>${jackson.version}</jackson.databind.version>
     <jetty.version>9.4.55.v20240627</jetty.version>
     <errorProneFlags></errorProneFlags>
-    <errorProne.version>2.24.1</errorProne.version>
+    <errorProne.version>2.31.0</errorProne.version>
     <javac.version>9+181-r4173-1</javac.version>
     <pmd.version>7.10.0</pmd.version>
     <checkstyle.skip>false</checkstyle.skip>
@@ -918,7 +918,7 @@
               <fork>false</fork>
               <compilerArgs>
                 <arg>-XDcompilePolicy=simple</arg>
-                <arg>-Xplugin:ErrorProne -XepExcludedPaths:${project.build.directory}/generated-sources/.* ${errorProneFlags}</arg>
+                <arg>-Xplugin:ErrorProne -XepExcludedPaths:${project.build.directory}/generated-sources/.* -Xep:SelfAssertion:OFF ${errorProneFlags}</arg>
                 <arg>-Xlint:${lint}</arg>
                 <arg>-Werror</arg>
               </compilerArgs>

From 2d2243b2d7e22d820b2bb053b2e7708a44a276d0 Mon Sep 17 00:00:00 2001
From: Andrea Aime <andrea.aime@gmail.com>
Date: Sun, 18 May 2025 16:43:27 +0200
Subject: [PATCH 2/2] Update PMD to 7.13

---
 geowebcache/pmd-junit-ruleset.xml | 6 +++---
 geowebcache/pom.xml               | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/geowebcache/pmd-junit-ruleset.xml b/geowebcache/pmd-junit-ruleset.xml
index 66c500dca..556c6cb0d 100644
--- a/geowebcache/pmd-junit-ruleset.xml
+++ b/geowebcache/pmd-junit-ruleset.xml
@@ -22,9 +22,9 @@ under the License.
 GeoTools Junit ruleset. See https://pmd.github.io/latest/pmd_userdocs_understanding_rulesets.html
 </description>
   <rule ref="category/java/bestpractices.xml/SimplifiableTestAssertion" />
-  <rule ref="category/java/bestpractices.xml/JUnit4TestShouldUseBeforeAnnotation" />
-  <rule ref="category/java/bestpractices.xml/JUnit4TestShouldUseAfterAnnotation" />
-  <rule ref="category/java/bestpractices.xml/JUnit4TestShouldUseTestAnnotation" />
+  <rule ref="category/java/bestpractices.xml/UnitTestShouldUseBeforeAnnotation" />
+  <rule ref="category/java/bestpractices.xml/UnitTestShouldUseAfterAnnotation" />
+  <rule ref="category/java/bestpractices.xml/UnitTestShouldUseTestAnnotation" />
   <!-- Excluded due to https://github.com/pmd/pmd/issues/2147 /-->
   <!-- rule ref="category/java/bestpractices.xml/JUnitTestsShouldIncludeAssert" /-->
   <rule name="DisallowJunit3"
diff --git a/geowebcache/pom.xml b/geowebcache/pom.xml
index aa9eada9a..aedeea744 100644
--- a/geowebcache/pom.xml
+++ b/geowebcache/pom.xml
@@ -89,7 +89,7 @@
     <errorProneFlags></errorProneFlags>
     <errorProne.version>2.31.0</errorProne.version>
     <javac.version>9+181-r4173-1</javac.version>
-    <pmd.version>7.10.0</pmd.version>
+    <pmd.version>7.13.0</pmd.version>
     <checkstyle.skip>false</checkstyle.skip>
     <qa>false</qa>
     <lint>deprecation,unchecked</lint>