From 2fc4708cdca2bc15dec927843f83af33c67cf050 Mon Sep 17 00:00:00 2001 From: Dongdong Tian Date: Wed, 18 Mar 2026 13:38:54 +0800 Subject: [PATCH 1/4] CI: Improve the workflow for checking broken links --- .github/workflows/check-links.yml | 36 ++++++++++++++++++------------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/.github/workflows/check-links.yml b/.github/workflows/check-links.yml index 1da3fba14a9..90e9911c62d 100644 --- a/.github/workflows/check-links.yml +++ b/.github/workflows/check-links.yml @@ -15,6 +15,9 @@ on: schedule: - cron: '0 12 * * 0' +permissions: + issues: write + jobs: check_links: name: Check Links @@ -29,26 +32,28 @@ jobs: id: lychee uses: lycheeverse/lychee-action@v2.8.0 with: + fail: false # Don't fail action on broken links + output: /tmp/lychee-out.md + # 200: OK # 429: Too many requests args: > - --accept 429 + --accept 200,429 --exclude ^ftp:// - --exclude ^https://download1.rpmfusion.org/free/fedora/rpmfusion-free-release-$ - --exclude ^https://download1.rpmfusion.org/free/el/rpmfusion-free-release-$ - --exclude ^http://maps.google.com/mapfiles/kml/$ --exclude ^http://aa.usno.navy.mil/faq/docs/lawyers.php$ - --exclude ^uhttp://my.server.com/images$ - --exclude ^-W@weight.png$ - --exclude ^http://topex.ucsd.edu/marine_grav/mar_grav.html - --exclude ^https://topex.ucsd.edu/sandwell/ + --exclude ^http://maps.google.com/mapfiles/kml/$ + --exclude ^http://nsis.sourceforge.io --exclude ^http://topex.ucsd.edu - --exclude ^https://doi.org - --exclude ^https://www.researchgate.net/ + --exclude ^http://topex.ucsd.edu/marine_grav/mar_grav.html --exclude ^http://www.eumetsat.int - --exclude ^http://nsis.sourceforge.io - --exclude ^https://www.ethnologue.com + --exclude ^https://doi.org + --exclude ^https://download1.rpmfusion.org/free/el/rpmfusion-free-release-$ + --exclude ^https://download1.rpmfusion.org/free/fedora/rpmfusion-free-release-$ --exclude ^https://linux.die.net/man/3/printf + --exclude ^https://topex.ucsd.edu/sandwell/ + --exclude ^https://www.ethnologue.com + --exclude ^https://www.researchgate.net/ --exclude ^https://www.softpedia.com/get/Tweak/Registry-Tweak/EditPath.shtml + --exclude ^http://my.server.com/images$ --verbose **/*.rst **/*.rst_ @@ -59,9 +64,10 @@ jobs: run: echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_OUTPUT - name: Create Issue From File - if: env.lychee_exit_code != 0 + if: github.event_name != 'workflow_dispatch' && steps.lychee.outputs.exit_code != 0 run: | - title="Link Checker Report on ${{ steps.date.outputs.date }}" - gh issue create --title "$title" --body-file ./lychee/out.md + title="Link Checker Report on ${CURRENT_DATE}" + gh issue create --title "$title" --body-file /tmp/lychee-out.md env: GH_TOKEN: ${{secrets.GITHUB_TOKEN}} + CURRENT_DATE: ${{ steps.date.outputs.date }} From ebefcba83f80c1a88beda7bc09b746454f3b2d14 Mon Sep 17 00:00:00 2001 From: Dongdong Tian Date: Wed, 18 Mar 2026 13:42:20 +0800 Subject: [PATCH 2/4] Remove verbose --- .github/workflows/check-links.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/check-links.yml b/.github/workflows/check-links.yml index 90e9911c62d..e873666e89f 100644 --- a/.github/workflows/check-links.yml +++ b/.github/workflows/check-links.yml @@ -54,7 +54,6 @@ jobs: --exclude ^https://www.researchgate.net/ --exclude ^https://www.softpedia.com/get/Tweak/Registry-Tweak/EditPath.shtml --exclude ^http://my.server.com/images$ - --verbose **/*.rst **/*.rst_ **/*.md From dadf8d3bf8610f79846add5c77c5d9e9160f1d98 Mon Sep 17 00:00:00 2001 From: Dongdong Tian Date: Wed, 18 Mar 2026 14:04:17 +0800 Subject: [PATCH 3/4] Minor updates to the remind.yml workflow --- .github/workflows/remind.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/remind.yml b/.github/workflows/remind.yml index 9583f05409e..ee3380559b1 100644 --- a/.github/workflows/remind.yml +++ b/.github/workflows/remind.yml @@ -11,8 +11,14 @@ on: schedule: - cron: '0 0 1 */6 *' +permissions: + contents: read + issues: write + + jobs: review-known-failures: + name: Review Known Failures runs-on: ubuntu-latest steps: From 5b5fd110e07bb2c7ae10ee71d249567a699444e7 Mon Sep 17 00:00:00 2001 From: Dongdong Tian Date: Wed, 18 Mar 2026 14:11:47 +0800 Subject: [PATCH 4/4] Improve the grep command for admin/list_known_failures.sh --- admin/list_known_failures.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/admin/list_known_failures.sh b/admin/list_known_failures.sh index e12834ab552..c3529848aa1 100755 --- a/admin/list_known_failures.sh +++ b/admin/list_known_failures.sh @@ -8,7 +8,7 @@ if [ ! -d cmake ]; then exit 1 fi -known_failures=$(grep -rl "GMT_KNOWN_FAILURE" test/**/*.sh doc/**/*.sh) +known_failures=$(grep -rl --include='*.sh' 'GMT_KNOWN_FAILURE' test doc) if [ -n "$known_failures" ]; then echo "The following tests are marked as GMT_KNOWN_FAILURE and need review:" echo ""