fwk: dogwood: Set the S0ix enter/exit flags correctly

Sometimes, the system will enter and resume S0ix several times within a
tick time (200ms). EC should set the flags in the correct state.

E.g., If the EC chipset state is in S0ix and the system resumes S0ix and
then enters again, the final memmap (EC_CUSTOMIZED_MEMMAP_POWER_STATE)
is EC_PS_ENTER_S0ix. In this case, EC should not set the enter_ms_flag.

BRANCH=fwk-dogwood-27111
BUG=https://app.clickup.com/t/86eu5ttc4
TEST=let system enter S0ix state, use the ec console command
     "memmap set 0x101 0x40", and the press power button to
     resume the system. Check the power LED is on and EC power
     state is S0.

Signed-off-by: Josh Tsai <Josh_Tsai@compal.com>

Author: Josh-Tsai

zephyr/program/framework/dogwood/src/power_sequence.c

@@ -264,9 +264,7 @@ void clear_power_flags(void)
  * host resumes from S0ix, masks from backup variables are copied over to
  * lpc_host_event_mask for SCI.
  */
-static int enter_ms_flag;
-static int resume_ms_flag;
-static int system_in_s0ix;
+static bool enter_ms_flag, resume_ms_flag, system_in_s0ix;
 
 static int check_s0ix_statsus(void)
 {
@@ -279,14 +277,18 @@ static int check_s0ix_statsus(void)
 
 
 		/**
-		 * Sometimes PCH will set the enter and resume flag continuously
-		 * so clear the EMI when we read the flag.
+		 * Sometimes, the system will enter and resume S0ix several times within a
+		 * tick time (200ms).EC should set the flags in the correct state.
+		 *
+		 * E.g., If the EC chipset state is in S0ix and the system resumes S0ix and
+		 *     then enters again, the final memmap (EC_CUSTOMIZED_MEMMAP_POWER_STATE)
+		 *     is EC_PS_ENTER_S0ix. In this case, EC should not set the enter_ms_flag.
 		 */
-		if (power_status & EC_PS_ENTER_S0ix)
-			enter_ms_flag++;
+		if ((power_status & EC_PS_ENTER_S0ix) && !system_in_s0ix)
+			enter_ms_flag = true;
 
-		if (power_status & EC_PS_RESUME_S0ix)
-			resume_ms_flag++;
+		if ((power_status & EC_PS_RESUME_S0ix) && system_in_s0ix)
+			resume_ms_flag = true;
 
 		clear_flag = power_status & (EC_PS_ENTER_S0ix | EC_PS_RESUME_S0ix);
 
@@ -298,14 +300,14 @@ static int check_s0ix_statsus(void)
 		if (enter_ms_flag)
 			return CS_ENTER_S0ix;
 	}
-	return 0;
+	return CS_NONE;
 }
 
 static void power_clear_s0ix_flag(void)
 {
-	resume_ms_flag = 0;
-	enter_ms_flag = 0;
-	system_in_s0ix = 0;
+	resume_ms_flag = false;
+	enter_ms_flag = false;
+	system_in_s0ix = false;
 }
 
 void s0ix_status_handle(void)
@@ -321,11 +323,6 @@ void s0ix_status_handle(void)
 }
 DECLARE_HOOK(HOOK_TICK, s0ix_status_handle, HOOK_PRIO_DEFAULT);
 
-int check_s0ix_status(void)
-{
-	return system_in_s0ix;
-}
-
 #endif
 
 void chipset_reset(enum chipset_shutdown_reason reason)
@@ -827,8 +824,8 @@ enum power_state power_handle_state(enum power_state state)
 		return POWER_S0ix;
 
 	case POWER_S0ixS0:
-		resume_ms_flag = 0;
-		system_in_s0ix = 0;
+		resume_ms_flag = false;
+		system_in_s0ix = false;
 
 		lpc_s0ix_resume_restore_masks();
 		hook_notify(HOOK_CHIPSET_RESUME);
@@ -837,8 +834,9 @@ enum power_state power_handle_state(enum power_state state)
 		break;
 
 	case POWER_S0S0ix:
-		enter_ms_flag = 0;
-		system_in_s0ix = 1;
+		enter_ms_flag = false;
+		system_in_s0ix = true;
+
 		lpc_s0ix_suspend_clear_masks();
 		hook_notify(HOOK_CHIPSET_SUSPEND);
 		return POWER_S0ix;