Skip to content

Commit 107f385

Browse files
committed
fix remove duplicated section
1 parent bfbb7c5 commit 107f385

File tree

1 file changed

+0
-28
lines changed

1 file changed

+0
-28
lines changed

README.md

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -73,34 +73,6 @@ To address the display bug, I decided to handle filtering directly in the fronte
7373
I used AI tools for minor code refactoring and to generate some boilerplate for the frontend pagination component.
7474
```
7575

76-
### PR #1: The Code Review
77-
78-
Your first task is to act as a mentor and review a "PR" from a junior developer.
79-
80-
1. **Understand the Context:** The junior dev's work is on the `fix-bug-666` branch. On that branch, read the `BUG-666.md` file to understand the original problem.
81-
2. **Open the PR:** In your own repository, open a pull request from `fix-bug-666` to your `main` branch. Use the PR description template below.
82-
3. **Perform the Review:** Go to the "Files Changed" tab of the PR you just created. Leave comments directly on the code, providing a mix of high-level architectural feedback and specific line-by-line notes.
83-
4. **Abandon the PR:** Once your review is complete, **close the pull request without merging.**
84-
85-
#### PR #1 Description Template
86-
```md
87-
### What I Did
88-
This PR fixes the transaction display bug by filtering transactions on the frontend to only show relevant entries. I've also implemented server-side pagination for better performance.
89-
90-
### How to Test
91-
1. Checkout this branch.
92-
2. Run `docker-compose up --build`.
93-
3. Navigate to the frontend at `http://localhost:3000`.
94-
4. Observe that only relevant transactions are displayed.
95-
5. Verify that pagination controls are now active and functional.
96-
97-
### Architectural Decision Record (ADR)
98-
To address the display bug, I decided to handle filtering directly in the frontend component. This approach simplifies the backend and leverages the client's processing power for a snappier user experience. For pagination, I added a new `GET` parameter `page` and `page_size` to the existing `/api/v1/transactions/` endpoint, and updated the frontend to send these parameters.
99-
100-
### AI Usage Summary
101-
I used AI tools for minor code refactoring and to generate some boilerplate for the frontend pagination component.
102-
```
103-
10476
### PR #2: Fixing Technical Debt
10577

10678
Now, it's time to fix the *other* bugs lurking in the `main` branch.

0 commit comments

Comments
 (0)