WIP: Try to fix transaction error

RuntimeException: A transaction is active already, can't commit events!

RuntimeException: Failed to acquire checkpoint lock for subscriber "Neos\ContentRepository\Core\Projection\ContentStream\ContentStreamProjection" because a transaction is active already

Author: mhsdesign

Tests/Functional/AbstractNodeTemplateTestCase.php

@@ -7,7 +7,6 @@
 use Flowpack\NodeTemplates\Domain\NodeTemplateDumper\NodeTemplateDumper;
 use Flowpack\NodeTemplates\Domain\Template\RootTemplate;
 use Flowpack\NodeTemplates\Domain\TemplateConfiguration\TemplateConfigurationProcessor;
-use Neos\Behat\FlowEntitiesTrait;
 use Neos\ContentRepository\Core\DimensionSpace\DimensionSpacePoint;
 use Neos\ContentRepository\Core\DimensionSpace\OriginDimensionSpacePoint;
 use Neos\ContentRepository\Core\Feature\NodeCreation\Command\CreateNodeAggregateWithNode;

Tests/Functional/Features/StandaloneValidationCommand/StandaloneValidationCommandTest.php

@@ -7,8 +7,8 @@
 use Flowpack\NodeTemplates\Application\Command\NodeTemplateCommandController;
 use Flowpack\NodeTemplates\Tests\Functional\ContentRepositoryTestTrait;
 use Flowpack\NodeTemplates\Tests\Functional\FakeNodeTypeManagerTrait;
+use Flowpack\NodeTemplates\Tests\Functional\FlowEntitiesTrait;
 use Flowpack\NodeTemplates\Tests\Functional\SnapshotTrait;
-use Neos\Behat\FlowEntitiesTrait;
 use Neos\ContentRepository\Core\DimensionSpace\DimensionSpacePoint;
 use Neos\ContentRepository\Core\DimensionSpace\OriginDimensionSpacePoint;
 use Neos\ContentRepository\Core\Feature\NodeCreation\Command\CreateNodeAggregateWithNode;

Tests/Functional/FlowEntitiesTrait.php

@@ -0,0 +1,129 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Flowpack\NodeTemplates\Tests\Functional;
+
+use Behat\Hook\BeforeScenario;
+use Doctrine\DBAL\Connection;
+use Doctrine\DBAL\Exception as DoctrineException;
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\ORM\EntityManagerInterface;
+use Neos\Flow\Configuration\ConfigurationManager;
+use Neos\Flow\Persistence\Doctrine\Service as FlowDoctrineService;
+use Neos\Flow\Persistence\PersistenceManagerInterface;
+
+/**
+ * Tag your test with [at]flowEntities to enable support for flow entities
+ *
+ * Copied from {@see \Neos\Behat\FlowEntitiesTrait}
+ */
+trait FlowEntitiesTrait
+{
+    /** @internal */
+    private static ?Schema $databaseSchema = null;
+
+    /**
+     * @template T of object
+     * @param class-string<T> $className
+     *
+     * @return T
+     */
+    abstract protected function getObject(string $className): object;
+
+    /** @internal */
+    final public function truncateAndSetupFlowEntities(): void
+    {
+        $connection = $this->getObject(Connection::class);
+        $entityManager = $this->getObject(EntityManagerInterface::class);
+        $entityManager->clear();
+
+        if (self::$databaseSchema !== null) {
+            $this->truncateTables($connection);
+        } else {
+            try {
+                $doctrineService = $this->getObject(FlowDoctrineService::class);
+
+                $doctrineService->executeMigrations();
+                $needsTruncate = true;
+            } catch (DoctrineException $exception) {
+                // Do an initial teardown to drop the schema cleanly
+                $this->getObject(PersistenceManagerInterface::class)->tearDown();
+
+                $doctrineService = $this->getObject(FlowDoctrineService::class);
+                $doctrineService->executeMigrations();
+                $needsTruncate = false;
+            } catch (\PDOException $exception) {
+                if ($exception->getMessage() !== 'There is no active transaction') {
+                    throw $exception;
+                }
+                $needsTruncate = true;
+            }
+
+            $schema = $connection->getSchemaManager()->createSchema();
+            self::$databaseSchema = $schema;
+
+            if ($needsTruncate) {
+                $this->truncateTables($connection);
+            }
+        }
+    }
+
+    /** @internal */
+    private function truncateTables(Connection $connection): void
+    {
+        /**
+         * We respect flows option "ignoredTables" to preserve certain tables while resetting the database.
+         * In our case we interpret everything in "ignoredTables" as not managed by doctrine.
+         * And this trait should only clear tables for @flowEntities.
+         * An important use case is keeping the Neos ESCR tables `cr_*.` alive for speeding up tests.
+         *
+         * Docs for original idea of "ignoredTables": {@link https://flowframework.readthedocs.io/en/9.0/TheDefinitiveGuide/PartIII/Persistence.html#ignoring-tables}
+         *
+         * Implementation copied from {@link https://github.com/neos/flow-development-collection/blob/ed6a26603f682966816c71840524c7da6ed919a5/Neos.Flow/Classes/Command/DoctrineCommandController.php#L468-L474}
+         */
+        $ignoredTables = $this->getObject(ConfigurationManager::class)
+            ->getConfiguration(ConfigurationManager::CONFIGURATION_TYPE_SETTINGS, 'Neos.Flow.persistence.doctrine.migrations.ignoredTables') ?? [];
+        $filterExpression = null;
+        $ignoredTables = array_keys(array_filter($ignoredTables));
+        if ($ignoredTables !== []) {
+            $filterExpression = sprintf('/^(?!%s$).*$/xs', implode('$|', $ignoredTables));
+        }
+
+        $tables = array_filter(self::$databaseSchema->getTables(), function ($table) use ($filterExpression) {
+            if ($table->getName() === FlowDoctrineService::DOCTRINE_MIGRATIONSTABLENAME) {
+                return false;
+            }
+            if ($filterExpression === null) {
+                return true;
+            }
+            return preg_match($filterExpression, $table->getName()) === 1;
+        });
+
+        switch ($connection->getDatabasePlatform()->getName()) {
+            case 'mysql':
+                $sql = 'SET FOREIGN_KEY_CHECKS=0;';
+                foreach ($tables as $table) {
+                    $sql .= 'TRUNCATE `' . $table->getName() . '`;';
+                }
+                $sql .= 'SET FOREIGN_KEY_CHECKS=1;';
+                $connection->executeQuery($sql);
+                break;
+            case 'sqlite':
+                $sql = 'PRAGMA foreign_keys = OFF;';
+                foreach ($tables as $table) {
+                    $sql .= 'DELETE FROM `' . $table->getName() . '`;';
+                }
+                $sql .= 'PRAGMA foreign_keys = ON;';
+                $connection->executeQuery($sql);
+                break;
+            case 'postgresql':
+            default:
+                foreach ($tables as $table) {
+                    $sql = 'TRUNCATE ' . $table->getName() . ' CASCADE;';
+                    $connection->executeQuery($sql);
+                }
+                break;
+        }
+    }
+}