Skip to content

Commit 53ae90f

Browse files
committed
Remove deprecated no-arg constructor from FirebirdContainer
1 parent 00a739d commit 53ae90f

File tree

3 files changed

+1
-24
lines changed

3 files changed

+1
-24
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Version History
1111
- write you own rule implementation to start and stop the container.
1212
- Removed self-referencing generic type parameter from `FirebirdContainer`. \
1313
You need to replace occurrences of `FirebirdContainer<?>` and `FirebirdContainer<>` with `FirebirdContainer`.
14+
- Removed deprecated no-arg constructor from `FirebirdContainer`
1415
- Updated various test dependencies
1516

1617
1.6.1

src/main/java/org/firebirdsql/testcontainers/FirebirdContainer.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,6 @@ public class FirebirdContainer extends JdbcDatabaseContainer<FirebirdContainer>
5151
private boolean enableWireCrypt;
5252
private String sysdbaPassword;
5353

54-
/**
55-
* Creates a Firebird container with the default image ({@link #IMAGE} and {@link #DEFAULT_TAG}).
56-
*
57-
* @deprecated Use explicit image using {@link #FirebirdContainer(DockerImageName)} or {@link #FirebirdContainer(String)}
58-
*/
59-
@Deprecated
60-
public FirebirdContainer() {
61-
this(DEFAULT_IMAGE_NAME.withTag(DEFAULT_TAG));
62-
}
63-
6454
/**
6555
* Creates a Firebird container with an image name (e.g. {@code "firebirdsql/firebird:5.0.3"}.
6656
*

src/test/java/org/firebirdsql/testcontainers/FirebirdContainerTest.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -40,20 +40,6 @@ void testWithSysdbaPassword(DockerImageName imageName) throws SQLException {
4040
}
4141
}
4242

43-
@SuppressWarnings("deprecation")
44-
@Test
45-
void testImplicitImage() throws SQLException {
46-
final String sysdbaPassword = "sysdbapassword";
47-
try (FirebirdContainer container = new FirebirdContainer()
48-
.withSysdbaPassword(sysdbaPassword)) {
49-
container.start();
50-
51-
try (Connection connection = DriverManager.getConnection(container.getJdbcUrl(), "sysdba", sysdbaPassword)) {
52-
assertTrue(connection.isValid(100), "Connection is valid");
53-
}
54-
}
55-
}
56-
5743
/**
5844
* With {@code username} set to sysdba, {@code password} should take precedence over {@code sysdbaPassword}
5945
*/

0 commit comments

Comments
 (0)