Address review: use positive assertions and wrap async calls in Assert.DoesNotThrowAsync

Author: fdcastel

src/FirebirdSql.EntityFrameworkCore.Firebird.Tests/Query/ElementaryTests.cs

@@ -215,10 +215,10 @@ public async Task SqlQueryScalarSingleQuotesValueColumn()
 	{
 		await using (var db = await GetDbContext<SelectContext>())
 		{
-			var result = await db.Database.SqlQueryRaw<int>(@"SELECT 1 AS ""Value"" FROM RDB$DATABASE").SingleAsync();
+			var query = db.Database.SqlQueryRaw<int>(@"SELECT 1 AS ""Value"" FROM RDB$DATABASE");
+			Assert.DoesNotThrowAsync(() => query.SingleAsync());
 			var sql = db.LastCommandText;
-			Assert.AreEqual(1, result);
-			StringAssert.DoesNotContain("Value", sql.Replace(@"""Value""", string.Empty));
+			StringAssert.Contains(@"""Value""", sql);
 		}
 	}
 
@@ -227,10 +227,10 @@ public async Task SqlQueryScalarSingleOrDefaultQuotesValueColumn()
 	{
 		await using (var db = await GetDbContext<SelectContext>())
 		{
-			var result = await db.Database.SqlQueryRaw<int>(@"SELECT 1 AS ""Value"" FROM RDB$DATABASE").SingleOrDefaultAsync();
+			var query = db.Database.SqlQueryRaw<int>(@"SELECT 1 AS ""Value"" FROM RDB$DATABASE");
+			Assert.DoesNotThrowAsync(() => query.SingleOrDefaultAsync());
 			var sql = db.LastCommandText;
-			Assert.AreEqual(1, result);
-			StringAssert.DoesNotContain("Value", sql.Replace(@"""Value""", string.Empty));
+			StringAssert.Contains(@"""Value""", sql);
 		}
 	}
 
@@ -242,7 +242,7 @@ public async Task SqlQueryScalarComposedWhereQuotesValueColumn()
 			var query = db.Database.SqlQueryRaw<int>(@"SELECT 1 AS ""Value"" FROM RDB$DATABASE").Where(x => x > 0);
 			Assert.DoesNotThrowAsync(() => query.LoadAsync());
 			var sql = db.LastCommandText;
-			StringAssert.DoesNotContain("Value", sql.Replace(@"""Value""", string.Empty));
+			StringAssert.Contains(@"""Value""", sql);
 		}
 	}
 
@@ -251,9 +251,8 @@ public async Task EntitySingleOrDefaultQuotesIdentifiers()
 	{
 		await using (var db = await GetDbContext<SelectContext>())
 		{
-			var result = await db.Set<MonAttachment>().OrderBy(x => x.AttachmentId).Take(1).SingleOrDefaultAsync();
-			var sql = db.LastCommandText;
-			Assert.IsNotNull(result);
+			var query = db.Set<MonAttachment>().OrderBy(x => x.AttachmentId).Take(1);
+			Assert.DoesNotThrowAsync(() => query.SingleOrDefaultAsync());
 		}
 	}
 }