Merge pull request #50 from vprus/xor-binary-fuse-error-reporting

XorBinaryFuse: throw on failure

Author: lemire

fastfilter/src/main/java/org/fastfilter/xor/XorBinaryFuse16.java

@@ -200,12 +200,9 @@ private void addAll(long[] keys) {
 
             if (hashIndex > 100) {
                 // if construction doesn't succeed eventually,
-                // then there is likely a problem with the hash function
-                // let us not crash the system:
-                for(int i = 0; i < fingerprints.length; i++) {
-                    fingerprints[i] = (short)0xFFFF;
-                }
-                return;
+                // then there is likely a problem with the hash function.
+                // It's better fail that either produce non-functional or incorrect filter.
+                throw new IllegalArgumentException("could not construct filter");
             }
             // use a new random numbers
             seed = Hash.randomSeed();

fastfilter/src/main/java/org/fastfilter/xor/XorBinaryFuse32.java

@@ -200,12 +200,9 @@ private void addAll(long[] keys) {
 
             if (hashIndex > 100) {
                 // if construction doesn't succeed eventually,
-                // then there is likely a problem with the hash function
-                // let us not crash the system:
-                for (int i = 0; i < fingerprints.length; i++) {
-                    fingerprints[i] = (int) 0xFFFFFFFF;
-                }
-                return;
+                // then there is likely a problem with the hash function.
+                // It's better fail that either produce non-functional or incorrect filter.
+                throw new IllegalArgumentException("could not construct filter");
             }
             // use a new random numbers
             seed = Hash.randomSeed();

fastfilter/src/main/java/org/fastfilter/xor/XorBinaryFuse8.java

@@ -200,12 +200,9 @@ private void addAll(long[] keys) {
 
             if (hashIndex > 100) {
                 // if construction doesn't succeed eventually,
-                // then there is likely a problem with the hash function
-                // let us not crash the system:
-                for(int i = 0; i < fingerprints.length; i++) {
-                    fingerprints[i] = (byte)0xFF;
-                }
-                return;
+                // then there is likely a problem with the hash function.
+                // It's better fail that either produce non-functional or incorrect filter.
+                throw new IllegalArgumentException("could not construct filter");
             }
             // use a new random numbers
             seed = Hash.randomSeed();