templating.py:162: DeprecationWarning

[gkorland]

/usr/local/lib/python3.12/site-packages/starlette/templating.py:162: DeprecationWarning: The `name` is not the first parameter anymore. The first parameter should be the `Request` instance.
Replace `TemplateResponse(name, {"request": request})` by `TemplateResponse(request, name)`.

---

This repo is using Opire - what does it mean? 👇

💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️‍♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #315 either in the PR description or in a PR's comment.

🪙 Also, everyone can tip any user commenting /tip 20 @gkorland (replace 20 with the amount, and @gkorland with the user to tip).

📖 If you want to learn more, check out our documentation.

[overcut-ai]

Completed Working on "Automated Ticket Triage "

✅ Automatic ticket triage done for Issue #315: classified as templating bug (component/templating, bug, priority:low), high confidence; no duplicates; triage summary comment added and labels applied.

---

👉 View complete log

[overcut-ai]

Triage Summary

• Component: component/templating (confidence: 0.82) – warning originates from Starlette’s templating API usage in the backend.
• Category: bug (confidence: 0.90) – runtime deprecation warning indicates incorrect API usage.
• Priority: priority:low (confidence: 0.80) – deprecation needs cleanup but is not breaking current functionality.

Duplicate check: Compared against all open issues (N=30). The closest match was #314 (UI tests) with token-overlap similarity 0.07; no issue describing this Starlette warning was found (no duplicates ≥ 0.75 similarity).

Actions taken:

1. Added labels: component/templating, bug, priority:low.
2. Documented duplicate check results (none found).

Let me know if you’d like this reprioritized or if there’s more context about where the offending template lives so we can tighten scope further.

[overcut-ai]

Completed Working on "Auto Root Cause Analysis"

✅ Workflow completed successfully.

---

👉 View complete log

[overcut-ai]

🕵️ Root Cause Analysis (RCA)

Summary (root cause)
api/routes/auth.py calls Starlette’s TemplateResponse with the template name as the first positional argument:

return templates.TemplateResponse("chat.j2", {"request": request, ...})

Since Starlette ≥ 0.37 changed the function signature to expect the request object as the first parameter (TemplateResponse(request, name, context)), this outdated call now triggers:

DeprecationWarning: The `name` is not the first parameter anymore. The first parameter should be the `Request` instance.

Every time the / route is hit, the warning is emitted; future Starlette versions will turn this into a hard error.

Evidence

File	Lines	Snippet
api/routes/auth.py	~401-413	```python
return templates.TemplateResponse(

"chat.j2",
{
    "request": request,
    "is_authenticated": is_authenticated_flag,
    "user_info": user_info,
    "general_prefix": GENERAL_PREFIX,
    **auth_config,
}

)

_No other occurrences of `TemplateResponse(` were found in the repository._

### Impacted Areas
* `api/routes/auth.py::home` – rendering of the home page (`/` route).

**Confidence:** High (0.86)

---

## 🛠️ Suggested Fix
Starlette requires the `request` object to be the **first positional argument**. Update the call accordingly.

<details>
<summary>Minimal Patch</summary>

```diff
 diff --git a/api/routes/auth.py b/api/routes/auth.py
@@
-    return templates.TemplateResponse(
-        "chat.j2",
-        {
-            "request": request,
-            "is_authenticated": is_authenticated_flag,
-            "user_info": user_info,
-            "general_prefix": GENERAL_PREFIX,
-            **auth_config,
-        }
-    )
+    return templates.TemplateResponse(
+        request,
+        "chat.j2",
+        {
+            "is_authenticated": is_authenticated_flag,
+            "user_info": user_info,
+            "general_prefix": GENERAL_PREFIX,
+            **auth_config,
+        }
+    )

Risk Assessment

• Low risk – single‐line change isolated to one route; no logic alteration.
• Backwards compatible with current and future Starlette versions.

Test Recommendations

1. Run unit/integration tests covering the / route to ensure it still returns HTTP 200 and renders expected content.
2. Start the application locally, navigate to /, and confirm:
   • Page renders correctly.
   • No DeprecationWarning appears in logs.
3. (Optional) Add a regression test that asserts no warnings are logged when hitting /.

Overall Confidence Tier: conf-high

---

Label suggestions: rca-proposed, conf-high