Skip to content

Commit adebd5d

Browse files
authored
Merge pull request #226 from American-Institutes-for-Research/DATA-5021/fix_local_minio
Remove forced use of env.example in Docker Compose - see DATA-5021
2 parents 2690fe5 + 2523a72 commit adebd5d

2 files changed

Lines changed: 3 additions & 9 deletions

File tree

docker-compose.override.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ services:
2626
- /usr/src/app/jupyter
2727
- /usr/src/app/log
2828
- /usr/src/app/media
29-
# Ignore the local .env file, to avoid it conflicting with variables set
30-
# in the docker-compose.yml file, particularly by Dagster
31-
- ./env.example:/usr/src/app/.env
3229
environment:
3330
DJANGO_SETTINGS_MODULE: hea.settings.local
3431
LAUNCHER: ${LAUNCHER} # e.g. "debugpy" or "ddtrace"
@@ -54,9 +51,6 @@ services:
5451
- /usr/src/app/jupyter
5552
- /usr/src/app/log
5653
- /usr/src/app/media
57-
# Ignore the local .env file, to avoid it conflicting with variables set
58-
# in the docker-compose.yml file, particularly by Dagster
59-
- ./env.example:/usr/src/app/.env
6054
environment:
6155
DJANGO_SETTINGS_MODULE: hea.settings.local
6256
LAUNCHER: ${LAUNCHER} # e.g. "debugpy" or "ddtrace"
@@ -75,9 +69,6 @@ services:
7569
- /usr/src/app/jupyter
7670
- /usr/src/app/log
7771
- /usr/src/app/media
78-
# Ignore the local .env file, to avoid it conflicting with variables set
79-
# in the docker-compose.yml file, particularly by Dagster
80-
- ./env.example:/usr/src/app/.env
8172
environment:
8273
DJANGO_SETTINGS_MODULE: hea.settings.local
8374
LAUNCHER: ${LAUNCHER} # e.g. "debugpy" or "ddtrace"

docker-compose.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,9 @@ services:
101101
DAGSTER_ASSET_BASE_PATH: ${DAGSTER_ASSET_BASE_PATH}
102102
DAGSTER_WEBSERVER_URL: ${DAGSTER_WEBSERVER_URL}
103103
DAGSTER_WEBSERVER_PREFIX: pipelines
104+
DAGSTER_S3_BUCKET: ${DAGSTER_S3_BUCKET}
105+
DAGSTER_S3_PREFIX: ${DAGSTER_S3_PREFIX}
106+
DAGSTER_S3_LOG_PATH: ${DAGSTER_S3_LOG_PATH}
104107
AWS_ACCESS_KEY_ID: ${MINIO_ROOT_USER}
105108
AWS_SECRET_ACCESS_KEY: ${MINIO_ROOT_PASSWORD}
106109
AWS_ENDPOINT_URL_S3: ${MINIO_ENDPOINT_URL}

0 commit comments

Comments
 (0)