Commit 74301b2
committed
fix(bbr): correct argument order in bbr_get_raw_target_cwnd calls
The function signature is:
bbr_get_raw_target_cwnd(struct tcp_bbr *bbr, uint32_t gain, uint64_t bw)
But two call sites had bw and gain swapped:
- bbr_get_target_cwnd: bbr_get_raw_target_cwnd(bbr, bw, gain)
- bbr_get_a_state_target: bbr_get_raw_target_cwnd(bbr, bbr_get_bw(bbr), gain)
This caused bw (uint64_t) to be truncated to uint32_t and treated as gain,
while gain was passed as bw, resulting in incorrect BDP calculation and
severely underestimated cwnd when using BBR congestion control.
Fix both call sites to pass arguments in the correct order (gain, bw).
Fixes #10321 parent 22608e4 commit 74301b2
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3466 | 3466 | | |
3467 | 3467 | | |
3468 | 3468 | | |
3469 | | - | |
| 3469 | + | |
3470 | 3470 | | |
3471 | 3471 | | |
3472 | 3472 | | |
| |||
10718 | 10718 | | |
10719 | 10719 | | |
10720 | 10720 | | |
10721 | | - | |
10722 | | - | |
| 10721 | + | |
| 10722 | + | |
10723 | 10723 | | |
10724 | 10724 | | |
10725 | 10725 | | |
| |||
0 commit comments