Skip to content

Commit 9a58df3

Browse files
authored
Merge pull request #30 from Extendas/fix-datetime-filter
sf 6 support fixes
2 parents 1e903ff + c4af5e5 commit 9a58df3

1 file changed

Lines changed: 17 additions & 28 deletions

File tree

Util/Factory/Filter/DateTimeFilter.php

Lines changed: 17 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -14,55 +14,44 @@
1414
*/
1515
class DateTimeFilter extends DatatableFilter
1616
{
17-
protected $is_filter_time = false;
18-
protected $is_required = false;
19-
protected $default_start;
20-
protected $default_end;
17+
protected bool $is_filter_time = false;
18+
protected bool $is_required = false;
19+
protected \DateTime $default_start;
20+
protected \DateTime $default_end;
2121

22-
/**
23-
* DateTimeFilter constructor.
24-
* @param bool $is_filter_time
25-
* @param bool $is_required
26-
* @param \DateTime $default_start
27-
* @param \DateTime $default_end
28-
*/
29-
public function __construct($is_filter_time=false, $is_required=false, \DateTime $default_start=null, \DateTime $default_end=null)
22+
public function __construct(bool $is_filter_time = false, bool $is_required = false, ?\DateTime $default_start = null, ?\DateTime $default_end = null, bool $use_default_start_time = true, bool $use_default_end_time = true)
3023
{
3124
$this->is_filter_time = $is_filter_time;
3225
$this->is_required = $is_required;
3326
$this->default_start = $default_start ?: new \DateTime;
3427
$this->default_end = $default_end ?: new \DateTime;
28+
if ($use_default_start_time)
29+
{
30+
$this->default_start->setTime(0, 0, 0);
31+
}
32+
if ($use_default_end_time)
33+
{
34+
$this->default_end->setTime(23, 59, 59);
35+
}
3536
parent::__construct([]);
3637
}
3738

38-
/**
39-
* @return bool
40-
*/
41-
public function isFilterTime()
39+
public function isFilterTime(): bool
4240
{
4341
return $this->is_filter_time;
4442
}
4543

46-
/**
47-
* @return bool
48-
*/
49-
public function isRequired()
44+
public function isRequired(): bool
5045
{
5146
return $this->is_required;
5247
}
5348

54-
/**
55-
* @return \DateTime
56-
*/
57-
public function getDefaultStart()
49+
public function getDefaultStart(): \DateTime
5850
{
5951
return $this->default_start;
6052
}
6153

62-
/**
63-
* @return \DateTime
64-
*/
65-
public function getDefaultEnd()
54+
public function getDefaultEnd(): \DateTime
6655
{
6756
return $this->default_end;
6857
}

0 commit comments

Comments
 (0)