[$250] Expense - One receipt in Confirm detail page when repeatedly adding multi single receipt

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.90-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2595/folder/13177049/49475610/1101373286
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Win 11/Chrome
App Component: Money Requests

Action Performed:

1. Open https://staging.new.expensify.com
2. Open a 1:1 DM chat
3. Click the "+" button near the Composer, then select Split expense (or select Create expense)
4. Choose to scan or upload a photo (the first receipt)
5. This should lead to the Confirm Details page
6. Click the Right-Hand Panel (RHP) back button to return to the split expense options
7. Select another photo (the second receipt)
8. Click Split expense (or Scan expense if step 3 selected Create expense)

Expected Result:

Verify that two receipts are now shown on the Confirm Details page, indicating that both have been added to the split

Actual Result:

Only one receipt is shown on the Confirm Details page. The same issue for create expense on 1:1 DM or workspace chat, there displays Create expense instead of Create 2 expenses

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022006670757813373056
• Upwork Job ID: 2006670757813373056
• Last Price Increase: 2026-01-01

Issue Owner

Current Issue Owner: @jayeshmangwani

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[TaduJR]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When users add multiple receipt images sequentially to a split expense flow (upload first receipt → go to Confirm Details → go back → upload second receipt), only the most recent receipt appears on the Confirm Details page. The button text also shows "Create expense" instead of "Create 2 expenses."

What is the root cause of that problem?

The issue is in shouldReuseInitialTransaction function:

App/src/libs/TransactionUtils/index.ts

Lines 2416 to 2436 in 66de3d6

	function shouldReuseInitialTransaction(
	initialTransaction: OnyxEntry<Transaction>,
	shouldAcceptMultipleFiles: boolean,
	index: number,
	isMultiScanEnabled: boolean,
	transactions: Transaction[],
	): boolean {
	if (!initialTransaction) {
	return false;
	}
	if (!shouldAcceptMultipleFiles) {
	return true;
	}
	if (index !== 0) {
	return false;
	}
	return !isMultiScanEnabled || (transactions.length === 1 && (!initialTransaction.receipt?.source || initialTransaction.receipt?.isTestReceipt === true));
	}

When isMultiScanEnabled is false, the condition short-circuits:

return !isMultiScanEnabled || (transactions.length === 1 && (!initialTransaction.receipt?.source || ...));

Since !isMultiScanEnabled is true, the function immediately returns true without checking if the initial transaction already has a receipt.

Flow:

1. First receipt upload calls setReceiptFilesAndNavigate:

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Lines 618 to 668 in 66de3d6

	const setReceiptFilesAndNavigate = (files: FileObject[]) => {
	if (files.length === 0) {
	return;
	}
	// Store the receipt on the transaction object in Onyx
	const newReceiptFiles: ReceiptFile[] = [];
	if (isEditing) {
	const file = files.at(0);
	if (!file) {
	return;
	}
	const source = URL.createObjectURL(file as Blob);
	setMoneyRequestReceipt(initialTransactionID, source, file.name ?? '', !isEditing, file.type);
	updateScanAndNavigate(file, source);
	return;
	}
	if (!isMultiScanEnabled) {
	removeDraftTransactions(true);
	}
	for (const [index, file] of files.entries()) {
	const source = URL.createObjectURL(file as Blob);
	const transaction = shouldReuseInitialTransaction(initialTransaction, shouldAcceptMultipleFiles, index, isMultiScanEnabled, transactions)
	? (initialTransaction as Partial<Transaction>)
	: buildOptimisticTransactionAndCreateDraft({
	initialTransaction: initialTransaction as Partial<Transaction>,
	currentUserPersonalDetails,
	reportID,
	});
	const transactionID = transaction.transactionID ?? initialTransactionID;
	newReceiptFiles.push({file, source, transactionID});
	setMoneyRequestReceipt(transactionID, source, file.name ?? '', true, file.type);
	}
	if (shouldSkipConfirmation) {
	setReceiptFiles(newReceiptFiles);
	const gpsRequired = initialTransaction?.amount === 0 && iouType !== CONST.IOU.TYPE.SPLIT && files.length;
	if (gpsRequired) {
	const beginLocationPermissionFlow = shouldStartLocationPermissionFlow();
	if (beginLocationPermissionFlow) {
	setStartLocationPermissionFlow(true);
	return;
	}
	}
	}
	navigateToConfirmationStep(newReceiptFiles, false);
	};

2. shouldReuseInitialTransaction returns true → uses transaction ID "1" → stores first receipt

3. User goes back, uploads second receipt

4. shouldReuseInitialTransaction still returns true (because !isMultiScanEnabled short-circuits) → reuses same transaction ID "1" → overwrites first receipt

5. Confirmation page only sees one transaction with the second receipt

What changes do you think we should make in order to solve the problem?

Modify shouldReuseInitialTransaction to check if the initial transaction already has a receipt when multi-scan is disabled:

App/src/libs/TransactionUtils/index.ts

Line 2435 in 66de3d6

return !isMultiScanEnabled || (transactions.length === 1 && (!initialTransaction.receipt?.source || initialTransaction.receipt?.isTestReceipt === true));

Change from:

return !isMultiScanEnabled || (transactions.length === 1 && (!initialTransaction.receipt?.source || initialTransaction.receipt?.isTestReceipt === true));

To:

return (!isMultiScanEnabled && !initialTransaction.receipt?.source) ||
       (transactions.length === 1 && (!initialTransaction.receipt?.source || initialTransaction.receipt?.isTestReceipt === true));

This ensures that when isMultiScanEnabled is false but the initial transaction already has a receipt source, the function returns false, triggering buildOptimisticTransactionAndCreateDraft to create a new transaction instead of reusing the existing one:

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Lines 649 to 659 in 66de3d6

	const transactionID = transaction.transactionID ?? initialTransactionID;
	newReceiptFiles.push({file, source, transactionID});
	setMoneyRequestReceipt(transactionID, source, file.name ?? '', true, file.type);
	}
	if (shouldSkipConfirmation) {
	setReceiptFiles(newReceiptFiles);
	const gpsRequired = initialTransaction?.amount === 0 && iouType !== CONST.IOU.TYPE.SPLIT && files.length;
	if (gpsRequired) {
	const beginLocationPermissionFlow = shouldStartLocationPermissionFlow();

What alternative solutions did you explore? (Optional)

Alternatively, the fix could be applied in setReceiptFilesAndNavigate by explicitly checking initialTransaction.receipt?.source before calling shouldReuseInitialTransaction. However, modifying shouldReuseInitialTransaction is cleaner as it centralizes the reuse logic in one place and follows the existing pattern.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022006670757813373056

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[yatin-italy]

🚨 Edited by proposal-police: This proposal was edited at 2026-01-01 16:33:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When users add multiple receipts sequentially in a split or create expense flow (upload receipt → Confirm Details → back → upload another receipt), only the most recently added receipt appears on the Confirm Details page.

Additionally, the CTA incorrectly shows “Create expense” instead of “Create 2 expenses”, even though two receipts were added.

---

What is the root cause of that problem?

The issue occurs because the utility function shouldReuseInitialTransaction always returns true for the first file when isMultiScanEnabled is false, regardless of whether the initial transaction already contains a receipt.

As a result:

• The second receipt reuses the same transaction ID as the first
• The new receipt overwrites receipt.source in Onyx
• Only one transaction exists with a single receipt
• Confirm Details renders one receipt
• The CTA reflects an incorrect expense count

Confirm Details derives its UI state from Onyx transactions, and multiple receipts on a single transaction are not supported. Each receipt must be associated with a distinct transaction in order to be displayed correctly.

---

What changes do you think we should make in order to solve the problem?

Update shouldReuseInitialTransaction to prevent reusing the initial transaction once it already has a real receipt, even when multi-scan is disabled.

Proposed change

File: App/src/libs/TransactionUtils/index.ts

function shouldReuseInitialTransaction(
    initialTransaction,
    shouldAcceptMultipleFiles,
    index,
    isMultiScanEnabled,
    transactions,
) {
    if (!initialTransaction) {
        return false;
    }

    // Do not reuse the initial transaction if it already has a real receipt
    if (
        !isMultiScanEnabled &&
        initialTransaction.receipt?.source &&
        !initialTransaction.receipt.isTestReceipt
    ) {
        return false;
    }

    if (!shouldAcceptMultipleFiles) {
        return true;
    }

    if (index !== 0) {
        return false;
    }

    return (
        transactions.length === 1 &&
        (!initialTransaction.receipt?.source || initialTransaction.receipt.isTestReceipt === true)
    );
}

---

What alternative solutions did you explore? (Optional)

An alternative approach was to override reuse behavior locally in setReceiptFilesAndNavigate. However, this would duplicate business logic and increase long-term maintenance risk.

Updating shouldReuseInitialTransaction directly is preferred, as it is the source of truth for transaction reuse across expense flows and allows for a minimal, well-guarded fix.

[TaduJR]

Hey @jayeshmangwani

Happy New Year 🎉

Do you have a spare time to checkout my Proposal?

I got sometime this week so I can finish this up.

Thanks!