[$250] Incorrect upgrade message in animation page on creating new report

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.90-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77040
Email or phone of affected tester (no customers): starynight123@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11/Chrome, iPhone 16/iOS 18.7.1/Pixel 8a/Android 16
App Component: Money Requests

Action Performed:

Precondition: Create new account which has self DM and no workspace

1. Navigate to staging.new.expensify.com
2. Go to self DM & Create an expense
3. Go to Reports > Expenses
4. Select the expense via checkbox
5. Click dropdown menu > Move expense
6. Select Create report
7. Verify the upgrade message say "Reports are available on the Collect plan, starting at $5 per member per month."
8. Click on Upgrade button >> Confirm
9. Observe the upgrade message on animation RHP say "You've successfully upgraded S's Workspace to the Control plan! View your subscription for more details.

Expected Result:

On step 9 - Message on upgrade animation RHP should be relevant saying plan has been upgraded to Collect workspace as Reports feature is available on collect plan & does not require Control plan

Actual Result:

On step 7 message say reports are available on collect plan but after upgrading message on step 9 mentions that workspace has been upgraded to Control plan which is contradicting

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7040025_1767218562862.313.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022006670532051463656
• Upwork Job ID: 2006670532051463656
• Last Price Increase: 2026-01-01

Issue Owner

Current Issue Owner: @truph01

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mitarachim]

We can reproduce issue in Production build v9.2.89-6 with following steps :

Precondition: Create new account which has self DM and no workspace

1. Navigate to staging.new.expensify.com
2. Go to self DM & Create an expense
3. open created expense
4. Click Report field
5. Verify the upgrade message say "Reports are available on the Collect plan, starting at $5 per member per month."
6. Click on Upgrade button >> Confirm
7. Observe the upgrade message on animation RHP say "You've successfully upgraded S's Workspace to the Control plan! View your subscription for more details.

Screen.Recording.2026-01-01.at.8.03.59.AM.mov

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect upgrade message in animation page on creating new report

What is the root cause of that problem?

The condition in UpgradeConfirmation uses the nullish coalescing operator (??) instead of logical OR (||), so when isCategorizing is false, it doesn't check for isReporting

App/src/pages/workspace/upgrade/UpgradeConfirmation.tsx

Line 39 in c63d520

if (isCategorizing ?? isReporting) {

The same issue exists for the heading

App/src/pages/workspace/upgrade/UpgradeConfirmation.tsx

Line 59 in c63d520

if (isCategorizing ?? isReporting) {

What changes do you think we should make in order to solve the problem?

We need to replace the nullish coalescing operator (??) with logical OR (||) so both isCategorizing and isReporting are checked correctly

    const description = useMemo(() => {
        if (isCategorizing || isReporting) {
            return <Text style={[styles.textAlignCenter, styles.w100]}>{translate('workspace.upgrade.completed.categorizeMessage')}</Text>;
        }

App/src/pages/workspace/upgrade/UpgradeConfirmation.tsx

Lines 38 to 41 in c63d520

	const description = useMemo(() => {
	if (isCategorizing ?? isReporting) {
	return <Text style={[styles.textAlignCenter, styles.w100]}>{translate('workspace.upgrade.completed.categorizeMessage')}</Text>;
	}

    const heading = useMemo(() => {
        if (isCategorizing || isReporting) {
            return translate('workspace.upgrade.completed.createdWorkspace');
        }

App/src/pages/workspace/upgrade/UpgradeConfirmation.tsx

Lines 58 to 61 in c63d520

	const heading = useMemo(() => {
	if (isCategorizing ?? isReporting) {
	return translate('workspace.upgrade.completed.createdWorkspace');
	}

Note: we could also create a new translation keys for this scenario

What alternative solutions did you explore? (Optional)

We could check isReporting separately with if (isReporting) and create a new translation keys for workspace.upgrade.completed.reportMessage if needed

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022006670532051463656

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (External)

[btkcodedev]

@bfitzexpensify, if people put their proposal even before the external tag is added, I think it is not fair to open it to the community.