Skip to content

[HOLD for payment 2024-08-19] Suggestions causing excessive updates #46810

@hannojg

Description

@hannojg

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:v9.0.16-4 Develop
Reproducible in staging?: No, but there no warning will be thrown, although the performance impact is there
Reproducible in production?: No, but there no warning will be thrown, although the performance impact is there
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:@hannojg
Slack conversation:

Action Performed:

  • Open the native mobile app in development mode
  • Type rapidly into the composer spamming ~80 characters
  • In dev mode a warning will popup warning about excessive re-renders

Expected Result:

None of our components rerenders excessively while typing.

Actual Result:

Although there are no visible changes, internally we queue lots of react state updates.

Workaround:

No, its more of a performance issue.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-07-19.at.19.11.12.mov

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @twisterdotcom

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions