Skip to content

Commit e52ed82

Browse files
christsoclaude
andauthored
chore: remove unnecessary backward-compat shims for eval_set (#815)
eval_set was never user-facing in YAML — drop deprecated aliases from Zod schema, manifest reader, artifact writer, pipeline commands, trace stats, and example scripts. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 5f8f61c commit e52ed82

File tree

8 files changed

+5
-16
lines changed

8 files changed

+5
-16
lines changed

apps/cli/src/commands/eval/artifact-writer.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -463,8 +463,7 @@ function safeTargetId(target: string | undefined): string {
463463
}
464464

465465
function getDataset(result: EvaluationResult): string | undefined {
466-
const record = result as EvaluationResult & { eval_set?: string; evalSet?: string };
467-
return result.dataset ?? record.eval_set ?? record.evalSet;
466+
return result.dataset;
468467
}
469468

470469
function buildArtifactSubdir(result: EvaluationResult): string {

apps/cli/src/commands/pipeline/bench.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export const evalBenchCommand = command({
4545
const manifest = JSON.parse(await readFile(join(exportDir, 'manifest.json'), 'utf8'));
4646
const testIds: string[] = manifest.test_ids;
4747
const targetName: string = manifest.target?.name ?? 'unknown';
48-
const evalSet: string = manifest.dataset ?? manifest.eval_set ?? '';
48+
const evalSet: string = manifest.dataset ?? '';
4949
const experiment: string | undefined = manifest.experiment;
5050
const safeEvalSet = evalSet ? evalSet.replace(/[\/\\:*?"<>|]/g, '_') : '';
5151

apps/cli/src/commands/pipeline/grade.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export const evalGradeCommand = command({
4040
const manifestPath = join(exportDir, 'manifest.json');
4141
const manifest = JSON.parse(await readFile(manifestPath, 'utf8'));
4242
const testIds: string[] = manifest.test_ids;
43-
const evalSet: string = manifest.dataset ?? manifest.eval_set ?? '';
43+
const evalSet: string = manifest.dataset ?? '';
4444
const safeEvalSet = evalSet ? evalSet.replace(/[\/\\:*?"<>|]/g, '_') : '';
4545

4646
let totalGraders = 0;

apps/cli/src/commands/results/manifest.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ export interface ResultManifestRecord {
1212
readonly test_id?: string;
1313
readonly eval_id?: string;
1414
readonly dataset?: string;
15-
readonly eval_set?: string; // deprecated alias for dataset
1615
readonly experiment?: string;
1716
readonly target?: string;
1817
readonly score: number;
@@ -125,7 +124,7 @@ function hydrateManifestRecord(baseDir: string, record: ResultManifestRecord): E
125124
return {
126125
timestamp: record.timestamp,
127126
testId,
128-
dataset: record.dataset ?? record.eval_set,
127+
dataset: record.dataset,
129128
target: record.target,
130129
score: record.score,
131130
executionStatus: record.execution_status,

apps/cli/src/commands/trace/stats.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ function groupResults(results: RawResult[], groupBy?: string): GroupedResults[]
110110
key = result.target ?? 'unknown';
111111
break;
112112
case 'dataset':
113-
case 'eval-set':
114113
key = result.dataset ?? 'unknown';
115114
break;
116115
case 'test-id':

examples/showcase/offline-grader-benchmark/scripts/score-grader-benchmark.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ type EvalResult = {
1717
timestamp?: string;
1818
test_id?: string;
1919
dataset?: string;
20-
eval_set?: string; // backward compat
2120
target?: string;
2221
input?: string;
2322
output_text?: string;
@@ -222,7 +221,7 @@ for (const line of rawResults) {
222221
const output = {
223222
timestamp: result.timestamp,
224223
test_id: result.test_id,
225-
dataset: result.dataset ?? result.eval_set,
224+
dataset: result.dataset,
226225
target: labelOverride ?? result.target ?? labelFromPath(resultsPath),
227226
input: result.input,
228227
output_text: result.output_text,

packages/core/src/evaluation/validation/eval-file.schema.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,6 @@ const EvalTestSchema = z.object({
350350
metadata: z.record(z.unknown()).optional(),
351351
conversation_id: z.string().optional(),
352352
dataset: z.string().optional(),
353-
eval_set: z.string().optional(), // deprecated alias for dataset
354353
note: z.string().optional(),
355354
});
356355

plugins/agentv-dev/skills/agentv-eval-writer/references/eval-schema.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6390,9 +6390,6 @@
63906390
"dataset": {
63916391
"type": "string"
63926392
},
6393-
"eval_set": {
6394-
"type": "string"
6395-
},
63966393
"note": {
63976394
"type": "string"
63986395
}
@@ -12704,9 +12701,6 @@
1270412701
"dataset": {
1270512702
"type": "string"
1270612703
},
12707-
"eval_set": {
12708-
"type": "string"
12709-
},
1271012704
"note": {
1271112705
"type": "string"
1271212706
}

0 commit comments

Comments
 (0)