phpstan - spike dynamic output mode

It's hotfix that prevents xml error if checkstyle is not used:

$ ./phpqa --config tests/.ci --tools phpstan
simplexml_load_file(): build//phpstan.xml:1: parser error : Start tag expected, '<' not found

Author: zdenekdrahos

src/RunningTool.php

@@ -2,6 +2,8 @@
 
 namespace Edge\QA;
 
+use Edge\QA\Tools\Analyzer\Phpstan;
+
 class RunningTool
 {
     private $tool;
@@ -64,6 +66,9 @@ private function isAtLeastOneClassInstalled(array $classes)
 
     public function hasOutput($outputMode)
     {
+        if (!$this->outputMode && $this->tool === 'phpstan') {
+            $this->outputMode = Phpstan::$SETTINGS['outputMode'];
+        }
         return $this->outputMode == $outputMode;
     }
 

src/Tools/Analyzer/Phpstan.php

@@ -8,7 +8,7 @@ class Phpstan extends \Edge\QA\Tools\Tool
 {
     public static $SETTINGS = array(
         'optionSeparator' => ' ',
-        'outputMode' => OutputMode::XML_CONSOLE_OUTPUT,
+        'outputMode' => null, // hotfix for dynamic output mode that depends on errorFormat
         'xml' => ['phpstan.xml'],
         'errorsXPath' => '//checkstyle/file/error',
         'composer' => 'phpstan/phpstan',
@@ -42,11 +42,14 @@ function ($relativeDir) {
         $phpstanConfig = "# Configuration generated in phpqa\n" . \Nette\Neon\Neon::encode($config);
         $neonFile = $this->saveDynamicConfig($phpstanConfig, 'neon');
 
+        $errorFormat = $this->config->value('phpstan.errorFormat') ?: 'checkstyle';
+        self::$SETTINGS['outputMode'] = $errorFormat === 'checkstyle'
+            ? OutputMode::XML_CONSOLE_OUTPUT : OutputMode::RAW_CONSOLE_OUTPUT;
+
         $args = array(
             'analyze',
             'ansi' => '',
-            // TODO: disable xml output if errorFormat != checkstyle
-            $this->getErrorFormatOption() => $this->config->value('phpstan.errorFormat') ?: 'checkstyle',
+            $this->getErrorFormatOption() => $errorFormat,
             'level' => $this->config->value('phpstan.level'),
             'configuration' => $neonFile,
             $this->options->getAnalyzedDirs(' '),

tests/.ci/.phpqa.yml

@@ -49,6 +49,8 @@ psalm:
 
 phpstan:
     level: 5 # last level without type hints
+    # only checkstyle has pretty html report in phqpa - https://phpstan.org/user-guide/output-format
+    errorFormat: table
     # memoryLimit: 1G
     # https://github.com/phpstan/phpstan#configuration
     standard: phpstan.neon

tests/.ci/phpmd.xml

@@ -8,6 +8,7 @@
     <rule ref="rulesets/codesize.xml" />
     <rule ref="rulesets/controversial.xml">
         <exclude name="CamelCasePropertyName" />
+        <exclude name="CamelCaseVariableName" />
     </rule>
     <rule ref="rulesets/design.xml" />
     <rule ref="rulesets/unusedcode.xml" />

tests/RunningToolTest.php

@@ -2,6 +2,8 @@
 
 namespace Edge\QA;
 
+use Edge\QA\Tools\Analyzer\Phpstan;
+
 /** @SuppressWarnings(PHPMD.TooManyPublicMethods) */
 class RunningToolTest extends \PHPUnit_Framework_TestCase
 {
@@ -128,4 +130,13 @@ public function testCreateUniqueIdForUserReport()
         $report = $tool->getHtmlRootReports()[0];
         assertThat($report['id'], is('phpcs-dir-path-php'));
     }
+
+    public function testDynamicOutputModePhpstan()
+    {
+        $tool = new RunningTool('phpstan', [
+            'outputMode' => null,
+        ]);
+        Phpstan::$SETTINGS['outputMode'] = OutputMode::RAW_CONSOLE_OUTPUT;
+        assertThat($tool->hasOutput(OutputMode::RAW_CONSOLE_OUTPUT), is(true));
+    }
 }