replace shell scripts with node

Author: Shane98c

package.json

@@ -23,19 +23,19 @@
   "scripts": {
     "build": "tsup",
     "dev": "tsup --watch",
-    "clean": "rm -rf dist",
+    "clean": "node -e \"require('fs').rmSync('dist',{recursive:true,force:true})\"",
     "typecheck": "tsc --noEmit",
-    "pretest": "test -d tests/data || ./scripts/sync-fixtures.sh",
+    "pretest": "node scripts/sync.mjs --if-missing fixtures",
     "test": "vitest run",
     "test:watch": "vitest",
     "test:coverage": "vitest run --coverage",
     "format": "prettier --write .",
     "format:check": "prettier --check .",
-    "prepare": "test -d tests/data || ./scripts/sync-fixtures.sh && test -d flatbuffers || ./scripts/sync-flatbuffers.sh",
-    "sync:fixtures": "./scripts/sync-fixtures.sh",
-    "sync:fbs": "./scripts/sync-flatbuffers.sh",
-    "generate:fbs": "FLATC=\"$(./scripts/ensure-flatc.sh)\" && \"$FLATC\" -T -o ./src/format/flatbuffers --gen-all ./flatbuffers/all.fbs && node scripts/postgen-fbs.cjs ./src/format/flatbuffers && prettier --write src/format/flatbuffers/generated",
-    "check:fbs": "rm -rf /tmp/fbs-check && FLATC=\"$(./scripts/ensure-flatc.sh)\" && \"$FLATC\" -T -o /tmp/fbs-check --gen-all ./flatbuffers/all.fbs && node scripts/postgen-fbs.cjs /tmp/fbs-check && prettier --write /tmp/fbs-check/generated && diff -r /tmp/fbs-check/generated src/format/flatbuffers/generated"
+    "prepare": "node scripts/sync.mjs --if-missing fixtures flatbuffers",
+    "sync:fixtures": "node scripts/sync.mjs fixtures",
+    "sync:fbs": "node scripts/sync.mjs flatbuffers",
+    "generate:fbs": "node scripts/generate-fbs.mjs",
+    "check:fbs": "node scripts/check-fbs.mjs"
   },
   "keywords": [
     "icechunk",

scripts/check-fbs.mjs

@@ -0,0 +1,81 @@
+#!/usr/bin/env node
+/**
+ * Check that generated FlatBuffer TypeScript is up to date.
+ * Generates into a temp directory and diffs against the committed files.
+ *
+ * Usage:
+ *   node scripts/check-fbs.mjs
+ */
+import { execSync } from "node:child_process";
+import { mkdtempSync, rmSync, readdirSync, readFileSync } from "node:fs";
+import { join, dirname } from "node:path";
+import { tmpdir } from "node:os";
+import { fileURLToPath } from "node:url";
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const PROJECT_DIR = dirname(__dirname);
+
+const tmp = mkdtempSync(join(tmpdir(), "fbs-check-"));
+
+try {
+  const flatc = execSync("node scripts/ensure-flatc.mjs", {
+    cwd: PROJECT_DIR,
+    encoding: "utf8",
+  }).trim();
+
+  execSync(`"${flatc}" -T -o "${tmp}" --gen-all ./flatbuffers/all.fbs`, {
+    stdio: "inherit",
+    cwd: PROJECT_DIR,
+  });
+
+  execSync(`node scripts/postgen-fbs.cjs "${tmp}"`, {
+    stdio: "inherit",
+    cwd: PROJECT_DIR,
+  });
+
+  execSync(`npx prettier --write "${join(tmp, "generated")}"`, {
+    stdio: "inherit",
+    cwd: PROJECT_DIR,
+  });
+
+  // Compare generated files
+  const generatedDir = join(tmp, "generated");
+  const committedDir = join(
+    PROJECT_DIR,
+    "src",
+    "format",
+    "flatbuffers",
+    "generated",
+  );
+
+  const genFiles = readdirSync(generatedDir).sort();
+  const comFiles = readdirSync(committedDir).sort();
+
+  if (genFiles.join(",") !== comFiles.join(",")) {
+    console.error("File list mismatch:");
+    console.error("  generated:", genFiles.join(", "));
+    console.error("  committed:", comFiles.join(", "));
+    process.exit(1);
+  }
+
+  let dirty = false;
+  for (const file of genFiles) {
+    const a = readFileSync(join(generatedDir, file), "utf8");
+    const b = readFileSync(join(committedDir, file), "utf8");
+    if (a !== b) {
+      console.error(`DIFF: ${file}`);
+      dirty = true;
+    }
+  }
+
+  if (dirty) {
+    console.error(
+      "Generated FlatBuffer code is out of date. Run: npm run generate:fbs",
+    );
+    process.exit(1);
+  }
+
+  console.log("FlatBuffer generated code is up to date.");
+} finally {
+  rmSync(tmp, { recursive: true, force: true });
+}

scripts/ensure-flatc.mjs

@@ -0,0 +1,89 @@
+#!/usr/bin/env node
+/**
+ * Ensure the pinned flatc version is available at .bin/flatc (or .bin/flatc.exe on Windows).
+ * Downloads it if missing or wrong version. Prints the path on stdout.
+ *
+ * Usage:
+ *   node scripts/ensure-flatc.mjs
+ *   # returns the path to the flatc binary
+ */
+import { execSync } from "node:child_process";
+import { existsSync, mkdirSync, chmodSync, rmSync, mkdtempSync } from "node:fs";
+import { join, dirname } from "node:path";
+import { tmpdir, platform } from "node:os";
+import { fileURLToPath } from "node:url";
+
+const FLATC_VERSION = "25.12.19";
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const PROJECT_DIR = dirname(__dirname);
+const BIN_DIR = join(PROJECT_DIR, ".bin");
+const isWindows = platform() === "win32";
+const FLATC = join(BIN_DIR, isWindows ? "flatc.exe" : "flatc");
+
+// Check if we already have the right version
+if (existsSync(FLATC)) {
+  try {
+    const out = execSync(`"${FLATC}" --version`, { encoding: "utf8" });
+    const match = out.match(/(\d+\.\d+\.\d+)/);
+    if (match && match[1] === FLATC_VERSION) {
+      process.stdout.write(FLATC);
+      process.exit(0);
+    }
+    console.error(`flatc in .bin/ is v${match?.[1]}, need v${FLATC_VERSION}`);
+  } catch {
+    // binary exists but can't run — re-download
+  }
+}
+
+// Determine asset name
+let asset;
+switch (platform()) {
+  case "linux":
+    asset = "Linux.flatc.binary.clang++-18.zip";
+    break;
+  case "darwin":
+    asset = "Mac.flatc.binary.zip";
+    break;
+  case "win32":
+    asset = "Windows.flatc.binary.zip";
+    break;
+  default:
+    console.error(`error: cannot download flatc for ${platform()}`);
+    console.error(`Install flatc v${FLATC_VERSION} to .bin/flatc manually.`);
+    process.exit(1);
+}
+
+mkdirSync(BIN_DIR, { recursive: true });
+
+const url = `https://github.com/google/flatbuffers/releases/download/v${FLATC_VERSION}/${asset}`;
+const tmp = mkdtempSync(join(tmpdir(), "flatc-"));
+const zipPath = join(tmp, "flatc.zip");
+
+try {
+  console.error(`Downloading flatc v${FLATC_VERSION}...`);
+
+  // Use curl on unix, PowerShell on Windows
+  if (isWindows) {
+    execSync(
+      `powershell -Command "Invoke-WebRequest -Uri '${url}' -OutFile '${zipPath}'"`,
+      { stdio: ["pipe", "pipe", "inherit"] },
+    );
+    execSync(
+      `powershell -Command "Expand-Archive -Path '${zipPath}' -DestinationPath '${BIN_DIR}' -Force"`,
+      { stdio: ["pipe", "pipe", "inherit"] },
+    );
+  } else {
+    execSync(`curl -fsSL "${url}" -o "${zipPath}"`, {
+      stdio: ["pipe", "pipe", "inherit"],
+    });
+    execSync(`unzip -o -q "${zipPath}" -d "${BIN_DIR}/"`, {
+      stdio: ["pipe", "pipe", "inherit"],
+    });
+    chmodSync(FLATC, 0o755);
+  }
+
+  process.stdout.write(FLATC);
+} finally {
+  rmSync(tmp, { recursive: true, force: true });
+}

scripts/ensure-flatc.sh

@@ -0,0 +1,34 @@
+#!/usr/bin/env node
+/**
+ * Generate TypeScript from FlatBuffer schemas using the pinned flatc binary.
+ *
+ * Usage:
+ *   node scripts/generate-fbs.mjs
+ */
+import { execSync } from "node:child_process";
+import { dirname } from "node:path";
+import { fileURLToPath } from "node:url";
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const PROJECT_DIR = dirname(__dirname);
+
+// ensure-flatc prints the binary path to stdout
+const flatc = execSync("node scripts/ensure-flatc.mjs", {
+  cwd: PROJECT_DIR,
+  encoding: "utf8",
+}).trim();
+
+execSync(
+  `"${flatc}" -T -o ./src/format/flatbuffers --gen-all ./flatbuffers/all.fbs`,
+  { stdio: "inherit", cwd: PROJECT_DIR },
+);
+
+execSync("node scripts/postgen-fbs.cjs ./src/format/flatbuffers", {
+  stdio: "inherit",
+  cwd: PROJECT_DIR,
+});
+
+execSync("npx prettier --write src/format/flatbuffers/generated", {
+  stdio: "inherit",
+  cwd: PROJECT_DIR,
+});