-
Notifications
You must be signed in to change notification settings - Fork 20
Closed
Description
Changes to configuration settings in #263 (e.g., renaming tarball_prefix to artefact_prefix) may lead to bot components crashing when those settings are accessed, but weren't changed in the app.cfg.
We should ensure that all needed settings are present for the event handler and the job manager by using something similar to what is done for the job manager in eessi_bot_job_manager.py:
- defining needed settings by
eessi-bot-software-layer/eessi_bot_job_manager.py
Lines 70 to 77 in 2d15e77
REQUIRED_CONFIG = { FINISHED_JOB_COMMENTS: [FAILURE, JOB_RESULT_UNKNOWN_FMT, MISSING_MODULES, MULTIPLE_TARBALLS, NO_MATCHING_TARBALL, NO_SLURM_OUT, NO_TARBALL_MESSAGE, SLURM_OUT, SUCCESS], NEW_JOB_COMMENTS: [AWAITS_LAUNCH], RUNNING_JOB_COMMENTS: [RUNNING_JOB] } - verifying the config settings are present by
config.check_required_cfg_settings(REQUIRED_CONFIG)
This should be done before making a new release or we might miss to update the bot configs.