fix: Prevent characterCountElement prop from being set on DOM elements

frankieyan · frankieyan · commit f80cd88b4206 · 2025-11-12T23:35:23.000-08:00
diff --git a/src/select-field/select-field.tsx b/src/select-field/select-field.tsx
@@ -49,7 +49,7 @@ const SelectField = React.forwardRef<HTMLSelectElement, SelectFieldProps>(functi
             hidden={hidden}
             aria-describedby={ariaDescribedBy}
         >
-            {(extraProps) => (
+            {({ characterCountElement, ...extraProps }) => (
                 <Box
                     data-testid="select-wrapper"
                     className={[
diff --git a/src/text-area/text-area.tsx b/src/text-area/text-area.tsx
@@ -104,7 +104,7 @@ const TextArea = React.forwardRef<HTMLTextAreaElement, TextAreaProps>(function T
             maxWidth={maxWidth}
             maxLength={maxLength}
         >
-            {({ onChange, ...extraProps }) => (
+            {({ onChange, characterCountElement, ...extraProps }) => (
                 <Box
                     width="full"
                     display="flex"

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ const SelectField = React.forwardRef<HTMLSelectElement, SelectFieldProps>(functi`
`49`	`49`	`hidden={hidden}`
`50`	`50`	`aria-describedby={ariaDescribedBy}`
`51`	`51`	`>`
`52`		`- {(extraProps) => (`
	`52`	`+ {({ characterCountElement, ...extraProps }) => (`
`53`	`53`	`<Box`
`54`	`54`	`data-testid="select-wrapper"`
`55`	`55`	`className={[`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ const TextArea = React.forwardRef<HTMLTextAreaElement, TextAreaProps>(function T`
`104`	`104`	`maxWidth={maxWidth}`
`105`	`105`	`maxLength={maxLength}`
`106`	`106`	`>`
`107`		`- {({ onChange, ...extraProps }) => (`
	`107`	`+ {({ onChange, characterCountElement, ...extraProps }) => (`
`108`	`108`	`<Box`
`109`	`109`	`width="full"`
`110`	`110`	`display="flex"`