-
Notifications
You must be signed in to change notification settings - Fork 154
Open
Description
Description
ironrdp-server fails to compile on current master (87f8d07) because it uses ironrdp_tokio::reqwest::ReqwestNetworkClient but doesn't enable the reqwest feature on the ironrdp-tokio dependency.
Reproduction
git clone https://github.com/Devolutions/IronRDP.git
cd IronRDP
cargo check -p ironrdp-serverError
error[E0433]: failed to resolve: could not find `reqwest` in `ironrdp_tokio`
--> crates/ironrdp-server/src/server.rs:352:45
|
352 | &mut ironrdp_tokio::reqwest::ReqwestNetworkClient::new(),
| ^^^^^^^ could not find `reqwest` in `ironrdp_tokio`
Cause
Commit bca6d19 (#1043) added ReqwestNetworkClient::new() to accept_credssp in server.rs but didn't update ironrdp-server/Cargo.toml to enable the reqwest feature.
Fix
In crates/ironrdp-server/Cargo.toml, change:
ironrdp-tokio = { path = "../ironrdp-tokio", version = "0.8" }to:
ironrdp-tokio = { path = "../ironrdp-tokio", version = "0.8", features = ["reqwest"] }I can submit a PR with this fix if helpful.
Metadata
Metadata
Assignees
Labels
No labels