From cf4b420fbc94591663ef0a5bf56849e39795cfac Mon Sep 17 00:00:00 2001 From: Aya <31237389+tal5@users.noreply.github.com> Date: Thu, 7 Aug 2025 23:45:19 +0100 Subject: [PATCH 1/8] Item data component framework --- .../denizen/paper/PaperModule.java | 7 + .../ComponentAdaptersRegistry.java | 10 ++ .../paper/datacomponents/FoodAdapter.java | 52 ++++++ .../denizen/paper/properties/ItemRemoved.java | 59 ++++++ .../paper/utilities/DataComponentAdapter.java | 170 ++++++++++++++++++ .../nms/v1_21/helpers/ItemHelperImpl.java | 6 + 6 files changed, 304 insertions(+) create mode 100644 paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/ComponentAdaptersRegistry.java create mode 100644 paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java create mode 100644 paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java create mode 100644 paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/PaperModule.java b/paper/src/main/java/com/denizenscript/denizen/paper/PaperModule.java index 58ff60ed66..8dfc598483 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/PaperModule.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/PaperModule.java @@ -6,6 +6,7 @@ import com.denizenscript.denizen.nms.interfaces.packets.PacketOutChat; import com.denizenscript.denizen.objects.EntityTag; import com.denizenscript.denizen.objects.ItemTag; +import com.denizenscript.denizen.paper.datacomponents.ComponentAdaptersRegistry; import com.denizenscript.denizen.paper.events.*; import com.denizenscript.denizen.paper.properties.*; import com.denizenscript.denizen.paper.tags.PaperTagBase; @@ -127,6 +128,12 @@ public static void init() { PropertyParser.registerProperty(EntityWitherInvulnerable.class, EntityTag.class); PropertyParser.registerProperty(ItemArmorStand.class, ItemTag.class); + // Component adapters + if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21)) { + PropertyParser.registerProperty(ItemRemoved.class, ItemTag.class); + ComponentAdaptersRegistry.register(); + } + // Paper object extensions PaperElementExtensions.register(); PaperEntityExtensions.register(); diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/ComponentAdaptersRegistry.java b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/ComponentAdaptersRegistry.java new file mode 100644 index 0000000000..730418cbbd --- /dev/null +++ b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/ComponentAdaptersRegistry.java @@ -0,0 +1,10 @@ +package com.denizenscript.denizen.paper.datacomponents; + +import com.denizenscript.denizen.paper.utilities.DataComponentAdapter; + +public class ComponentAdaptersRegistry { + + public static void register() { + DataComponentAdapter.register(new FoodAdapter()); + } +} diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java new file mode 100644 index 0000000000..acc49d11a5 --- /dev/null +++ b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java @@ -0,0 +1,52 @@ +package com.denizenscript.denizen.paper.datacomponents; + +import com.denizenscript.denizen.paper.utilities.DataComponentAdapter; +import com.denizenscript.denizencore.objects.Mechanism; +import com.denizenscript.denizencore.objects.core.ElementTag; +import com.denizenscript.denizencore.objects.core.MapTag; +import io.papermc.paper.datacomponent.DataComponentTypes; +import io.papermc.paper.datacomponent.item.FoodProperties; + +public class FoodAdapter extends DataComponentAdapter { + + // <--[property] + // @object ItemTag + // @name food + // @input MapTag + // @description + // Controls an item's food <@link language Item Components>. + // The map includes keys: + // - "nutrition", ElementTag(Number) representing the amount of food points restored by this item. + // - "saturation", ElementTag(Decimal) representing the amount of saturation points restored by this item. + // - "can_always_eat", ElementTag(Boolean) controlling whether the item can always be eaten, even if the player isn't hungry. + // --> + + // <--[tag] + // @attribute + // @returns MapTag + // @description + // Gets the material's default food value, in the same format as <@link tag ItemTag.food>. + // --> + + public FoodAdapter() { + super(DataComponentTypes.FOOD, MapTag.class, "food"); + } + + @Override + public MapTag toDenizen(FoodProperties value) { + MapTag foodData = new MapTag(); + foodData.putObject("nutrition", new ElementTag(value.nutrition())); + foodData.putObject("saturation", new ElementTag(value.saturation())); + foodData.putObject("can_always_eat", new ElementTag(value.canAlwaysEat())); + return foodData; + } + + @Override + public FoodProperties toPaper(MapTag value, Mechanism mechanism) { + FoodProperties.Builder builder = FoodProperties.food(); + setIfValid(builder::nutrition, value, "nutrition", "number", ElementTag::isInt, ElementTag::asInt, mechanism); + setIfValid(builder::saturation, value, "saturation", "decimal number", ElementTag::isFloat, ElementTag::asFloat, mechanism); + setIfValid(builder::canAlwaysEat, value, "can_always_eat", "boolean", ElementTag::isBoolean, ElementTag::asBoolean, mechanism); + return builder.build(); + } +} diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java b/paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java new file mode 100644 index 0000000000..73a98dcd88 --- /dev/null +++ b/paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java @@ -0,0 +1,59 @@ +package com.denizenscript.denizen.paper.properties; + +import com.denizenscript.denizen.objects.ItemTag; +import com.denizenscript.denizen.objects.properties.item.ItemProperty; +import com.denizenscript.denizen.paper.utilities.DataComponentAdapter; +import com.denizenscript.denizencore.objects.Mechanism; +import com.denizenscript.denizencore.objects.core.ElementTag; +import com.denizenscript.denizencore.objects.core.ListTag; +import io.papermc.paper.datacomponent.DataComponentType; + +public class ItemRemoved extends ItemProperty { + + // <--[property] + // @object ItemTag + // @name removed + // @input ListTag + // @description + // Controls the properties explicitly removed from an item. + // This can be used to remove item's default behavior, such as making consumable items un-consumable. + // See also <@link language Item Components>. + // --> + + public static boolean describes(ItemTag item) { + return !item.getItemStack().isEmpty(); + } + + @Override + public ListTag getPropertyValue() { + return new ListTag(getMaterial().getDefaultDataTypes(), + componentType -> getItemStack().isDataOverridden(componentType) && !getItemStack().hasData(componentType), + componentType -> new ElementTag(componentType.key().asMinimalString(), true)); + } + + @Override + public boolean isDefaultValue(ListTag value) { + return value.isEmpty(); + } + + @Override + public void setPropertyValue(ListTag value, Mechanism mechanism) { + for (String input : value) { + DataComponentType componentType = DataComponentAdapter.getComponentType(input); + if (componentType == null) { + mechanism.echoError("Invalid type to remove '" + input + "' specified: must be a valid property or item component name."); + continue; + } + getItemStack().unsetData(componentType); + } + } + + @Override + public String getPropertyId() { + return "removed"; + } + + public static void register() { + autoRegister("removed", ItemRemoved.class, ListTag.class, false); + } +} diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java b/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java new file mode 100644 index 0000000000..47168af9b7 --- /dev/null +++ b/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java @@ -0,0 +1,170 @@ +package com.denizenscript.denizen.paper.utilities; + +import com.denizenscript.denizen.objects.ItemTag; +import com.denizenscript.denizen.objects.MaterialTag; +import com.denizenscript.denizen.objects.properties.item.ItemComponentsPatch; +import com.denizenscript.denizen.objects.properties.item.ItemProperty; +import com.denizenscript.denizen.utilities.Utilities; +import com.denizenscript.denizencore.objects.Mechanism; +import com.denizenscript.denizencore.objects.ObjectTag; +import com.denizenscript.denizencore.objects.core.ElementTag; +import com.denizenscript.denizencore.objects.core.MapTag; +import com.denizenscript.denizencore.objects.properties.PropertyParser; +import com.denizenscript.denizencore.utilities.CoreUtilities; +import io.papermc.paper.datacomponent.DataComponentType; +import org.bukkit.Material; +import org.bukkit.Registry; + +import java.util.HashMap; +import java.util.Map; +import java.util.function.Consumer; +import java.util.function.Function; +import java.util.function.Predicate; + +public abstract class DataComponentAdapter { + + // <--[language] + // @name Item Components + // @group Minecraft Logic + // @description + // Minecraft item components (see <@link url https://minecraft.wiki/w/Data_component_format>) are managed as follows: + // Each item type has a default set of component values; a food item will have food components by default, a tool item will have tool components by default, etc. + // Different items can override their type's default components, either by setting values that weren't there previously (e.g. making an inedible item edible), or by removing values that are there by default (e.g. making a shield item that can't block). + // Item's overrides can later be reset, so that their type's default value is used again. + // + // In Denizen, different item components are represented by item properties. + // These properties allow both setting a component override on an item, and clearing it by providing no input. + // Item properties' name will generally match their respective item component's name, but not always! + // Due to this, features that take item component names as input (such as <@link tag ItemTag.is_overridden>) accept both Minecraft component names and Denizen property names. + // + // Here is an example of applying all of this in Denizen: + // + // # We define a default apple item + // - define apple + // # We remove the apple's "food" component, making eating it restore no food points (it is still consumable due to the "consumable" component). + // - adjust def:apple removed:food + // # This check will pass, as the apple's "food" component is overridden to have no value. + // - if <[apple].is_overridden[food]>: + // - narrate "The apple has a changed food component! It will behave differently to a normal apple." + // # We reset the apple item's food component, making it a normal apple. + // - adjust def:apple food: + // + // --> + + public static final Map COMPONENTS_BY_PROPERTY = new HashMap<>(); + public static final String[] EMPTY_STRING_ARRAY = new String[0]; + + public static DataComponentType getComponentType(String name) { + String nameLower = CoreUtilities.toLowerCase(name); + DataComponentType componentType = Registry.DATA_COMPONENT_TYPE.get(Utilities.parseNamespacedKey(nameLower)); + if (componentType == null) { + componentType = DataComponentAdapter.COMPONENTS_BY_PROPERTY.get(nameLower); + } + return componentType; + } + + public static void register(DataComponentAdapter adapter) { + DataComponentAdapter.Property.currentlyRegisteringComponentAdapter = adapter; + PropertyParser.registerPropertyGetter( + item -> !item.getItemStack().isEmpty() ? adapter.new Property(item) : null, + ItemTag.class, EMPTY_STRING_ARRAY, EMPTY_STRING_ARRAY, DataComponentAdapter.Property.class); + DataComponentAdapter.Property.currentlyRegisteringComponentAdapter = null; + MaterialTag.tagProcessor.registerTag(adapter.denizenType, adapter.name, (attribute, materialTag) -> { + Material material = materialTag.getMaterial(); + if (!material.isItem()) { + attribute.echoError("Cannot get item component value from a block material."); + return null; + } + TP internalValue = material.getDefaultData(adapter.componentType); + return internalValue != null ? adapter.toDenizen(internalValue) : null; + }); + COMPONENTS_BY_PROPERTY.put(adapter.name, adapter.componentType); + ItemComponentsPatch.registerHandledComponent(adapter.componentType.key().value()); + } + + static { + + // <--[tag] + // @attribute ]> + // @returns ElementTag(Boolean) + // @description + // Returns whether an item has a specific item component type overridden, see <@link language Item Components>. + // --> + ItemTag.tagProcessor.registerTag(ElementTag.class, ElementTag.class, "is_overridden", (attribute, object, param) -> { + DataComponentType componentType = getComponentType(param.asString()); + if (componentType == null) { + attribute.echoError("Invalid type specified, must be a valid item component type or property name."); + return null; + } + return new ElementTag(object.getItemStack().isDataOverridden(componentType)); + }); + } + + DataComponentType.Valued componentType; + Class denizenType; + String name; + + public DataComponentAdapter(DataComponentType.Valued componentType, Class denizenType, String name) { + this.componentType = componentType; + this.denizenType = denizenType; + this.name = name; + } + + public abstract TD toDenizen(TP value); + + public abstract TP toPaper(TD value, Mechanism mechanism); + + public static void setIfValid(Consumer setter, MapTag data, String key, String type, Predicate checker, Function converter, Mechanism mechanism) { + ElementTag value = data.getElement(key); + if (value == null) { + return; + } + T converted; + if (!checker.test(value) || (converted = converter.apply(value)) == null) { + mechanism.echoError("Invalid '" + key + "' specified: must be a " + type + '.'); + return; + } + setter.accept(converted); + } + + public class Property extends ItemProperty { + + private static DataComponentAdapter currentlyRegisteringComponentAdapter; + + public Property(ItemTag item) { + this.object = item; + } + + @Override + public TD getPropertyValue() { + TP internalValue = getItemStack().getData(componentType); + return internalValue == null ? null : toDenizen(internalValue); + } + + @Override + public TD getPropertyValueNoDefault() { + return getItemStack().isDataOverridden(componentType) ? getPropertyValue() : null; + } + + @Override + public void setPropertyValue(TD value, Mechanism mechanism) { + if (value == null) { + getItemStack().resetData(componentType); + return; + } + TP converted = toPaper(value, mechanism); + if (converted != null) { + getItemStack().setData(componentType, converted); + } + } + + @Override + public String getPropertyId() { + return name; + } + + public static void register() { + autoRegisterNullable(currentlyRegisteringComponentAdapter.name, DataComponentAdapter.Property.class, currentlyRegisteringComponentAdapter.denizenType, false); + } + } +} diff --git a/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/ItemHelperImpl.java b/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/ItemHelperImpl.java index 14298cc907..0d49eb88c7 100644 --- a/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/ItemHelperImpl.java +++ b/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/ItemHelperImpl.java @@ -450,6 +450,12 @@ public MapTag getRawComponentsPatch(ItemStack item, boolean excludeHandled) { } RegistryOps registryOps = CraftRegistry.getMinecraftRegistry().createSerializationContext(NbtOps.INSTANCE); CompoundTag nmsPatch = (CompoundTag) DataComponentPatch.CODEC.encodeStart(registryOps, patch).getOrThrow(); + if (excludeHandled) { + nmsPatch.keySet().removeIf(s -> s.charAt(0) == '!'); + if (nmsPatch.isEmpty()) { + return new MapTag(); + } + } MapTag rawComponents = (MapTag) ItemRawNBT.nbtTagToObject(NBTAdapter.toAPI(nmsPatch)); rawComponents.putObject(ItemComponentsPatch.DATA_VERSION_KEY, new ElementTag(CraftMagicNumbers.INSTANCE.getDataVersion())); return rawComponents; From a6600d653441c4a67c4d89323defed6c58f98a3e Mon Sep 17 00:00:00 2001 From: Aya <31237389+tal5@users.noreply.github.com> Date: Thu, 7 Aug 2025 23:51:47 +0100 Subject: [PATCH 2/8] Only register mapping when needed --- .../denizen/paper/utilities/DataComponentAdapter.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java b/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java index 47168af9b7..487a737513 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java @@ -78,8 +78,11 @@ public static void register(DataComponentAdapter Date: Fri, 8 Aug 2025 00:12:03 +0100 Subject: [PATCH 3/8] Field modifiers --- .../denizen/paper/utilities/DataComponentAdapter.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java b/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java index 487a737513..ccd69ebf36 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java @@ -103,9 +103,9 @@ public static void register(DataComponentAdapter componentType; - Class denizenType; - String name; + public final DataComponentType.Valued componentType; + public final Class denizenType; + public final String name; public DataComponentAdapter(DataComponentType.Valued componentType, Class denizenType, String name) { this.componentType = componentType; From c14ac8793c3f0f6cd22a48692257f48adb9b2e70 Mon Sep 17 00:00:00 2001 From: Aya <31237389+tal5@users.noreply.github.com> Date: Fri, 8 Aug 2025 00:21:39 +0100 Subject: [PATCH 4/8] Reorder --- .../denizen/paper/datacomponents/FoodAdapter.java | 2 +- .../denizen/paper/utilities/DataComponentAdapter.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java index acc49d11a5..2c14856a78 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java @@ -7,7 +7,7 @@ import io.papermc.paper.datacomponent.DataComponentTypes; import io.papermc.paper.datacomponent.item.FoodProperties; -public class FoodAdapter extends DataComponentAdapter { +public class FoodAdapter extends DataComponentAdapter { // <--[property] // @object ItemTag diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java b/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java index ccd69ebf36..65e6307f3d 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java @@ -21,7 +21,7 @@ import java.util.function.Function; import java.util.function.Predicate; -public abstract class DataComponentAdapter { +public abstract class DataComponentAdapter { // <--[language] // @name Item Components @@ -63,7 +63,7 @@ public static DataComponentType getComponentType(String name) { return componentType; } - public static void register(DataComponentAdapter adapter) { + public static void register(DataComponentAdapter adapter) { DataComponentAdapter.Property.currentlyRegisteringComponentAdapter = adapter; PropertyParser.registerPropertyGetter( item -> !item.getItemStack().isEmpty() ? adapter.new Property(item) : null, From 8e1fe581ca5928ac0afd643739003735c67a80bb Mon Sep 17 00:00:00 2001 From: Aya <31237389+tal5@users.noreply.github.com> Date: Fri, 8 Aug 2025 00:29:19 +0100 Subject: [PATCH 5/8] Move `DataComponentAdapter` --- .../denizen/paper/datacomponents/ComponentAdaptersRegistry.java | 2 -- .../{utilities => datacomponents}/DataComponentAdapter.java | 2 +- .../denizenscript/denizen/paper/datacomponents/FoodAdapter.java | 1 - .../com/denizenscript/denizen/paper/properties/ItemRemoved.java | 2 +- 4 files changed, 2 insertions(+), 5 deletions(-) rename paper/src/main/java/com/denizenscript/denizen/paper/{utilities => datacomponents}/DataComponentAdapter.java (99%) diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/ComponentAdaptersRegistry.java b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/ComponentAdaptersRegistry.java index 730418cbbd..c4b781ed1a 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/ComponentAdaptersRegistry.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/ComponentAdaptersRegistry.java @@ -1,7 +1,5 @@ package com.denizenscript.denizen.paper.datacomponents; -import com.denizenscript.denizen.paper.utilities.DataComponentAdapter; - public class ComponentAdaptersRegistry { public static void register() { diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java similarity index 99% rename from paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java rename to paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java index 65e6307f3d..77bba0049b 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/utilities/DataComponentAdapter.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java @@ -1,4 +1,4 @@ -package com.denizenscript.denizen.paper.utilities; +package com.denizenscript.denizen.paper.datacomponents; import com.denizenscript.denizen.objects.ItemTag; import com.denizenscript.denizen.objects.MaterialTag; diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java index 2c14856a78..88a7722eef 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/FoodAdapter.java @@ -1,6 +1,5 @@ package com.denizenscript.denizen.paper.datacomponents; -import com.denizenscript.denizen.paper.utilities.DataComponentAdapter; import com.denizenscript.denizencore.objects.Mechanism; import com.denizenscript.denizencore.objects.core.ElementTag; import com.denizenscript.denizencore.objects.core.MapTag; diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java b/paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java index 73a98dcd88..593fd6d2f4 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java @@ -2,7 +2,7 @@ import com.denizenscript.denizen.objects.ItemTag; import com.denizenscript.denizen.objects.properties.item.ItemProperty; -import com.denizenscript.denizen.paper.utilities.DataComponentAdapter; +import com.denizenscript.denizen.paper.datacomponents.DataComponentAdapter; import com.denizenscript.denizencore.objects.Mechanism; import com.denizenscript.denizencore.objects.core.ElementTag; import com.denizenscript.denizencore.objects.core.ListTag; From ab944f383837b85f769628b8707f4f5fc4d3419e Mon Sep 17 00:00:00 2001 From: Aya <31237389+tal5@users.noreply.github.com> Date: Fri, 8 Aug 2025 00:36:32 +0100 Subject: [PATCH 6/8] Meta cleanups --- .../denizen/paper/datacomponents/DataComponentAdapter.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java index 77bba0049b..4797e3ed2e 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java @@ -30,14 +30,14 @@ public abstract class DataComponentAdapter { // Minecraft item components (see <@link url https://minecraft.wiki/w/Data_component_format>) are managed as follows: // Each item type has a default set of component values; a food item will have food components by default, a tool item will have tool components by default, etc. // Different items can override their type's default components, either by setting values that weren't there previously (e.g. making an inedible item edible), or by removing values that are there by default (e.g. making a shield item that can't block). - // Item's overrides can later be reset, so that their type's default value is used again. + // Items' overrides can later be reset, making them use their type's default values again. // // In Denizen, different item components are represented by item properties. - // These properties allow both setting a component override on an item, and clearing it by providing no input. + // These properties allow both setting a component override on an item, and clearing/resetting it by providing no input. // Item properties' name will generally match their respective item component's name, but not always! // Due to this, features that take item component names as input (such as <@link tag ItemTag.is_overridden>) accept both Minecraft component names and Denizen property names. // - // Here is an example of applying all of this in Denizen: + // Here is an example of applying all of this in a script: // // # We define a default apple item // - define apple From e6fa0efe523fcf24d3db6194dd07aec133a8fe3b Mon Sep 17 00:00:00 2001 From: Aya <31237389+tal5@users.noreply.github.com> Date: Fri, 8 Aug 2025 01:02:55 +0100 Subject: [PATCH 7/8] s --- .../denizen/paper/datacomponents/DataComponentAdapter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java index 4797e3ed2e..b0d5ae7eb8 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java @@ -72,7 +72,7 @@ public static void register(DataComponentAdapter { Material material = materialTag.getMaterial(); if (!material.isItem()) { - attribute.echoError("Cannot get item component value from a block material."); + attribute.echoError("Cannot get item component values from a block material."); return null; } TP internalValue = material.getDefaultData(adapter.componentType); From f9e944837ffcfb54eb1739404779f4f7a8c180ca Mon Sep 17 00:00:00 2001 From: Aya <31237389+tal5@users.noreply.github.com> Date: Mon, 22 Sep 2025 00:50:09 +0100 Subject: [PATCH 8/8] Minor cleanups --- .../denizen/paper/datacomponents/DataComponentAdapter.java | 2 +- .../denizenscript/denizen/paper/properties/ItemRemoved.java | 2 +- .../denizen/nms/v1_21/helpers/ItemHelperImpl.java | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java index b0d5ae7eb8..0adb4978f9 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/datacomponents/DataComponentAdapter.java @@ -58,7 +58,7 @@ public static DataComponentType getComponentType(String name) { String nameLower = CoreUtilities.toLowerCase(name); DataComponentType componentType = Registry.DATA_COMPONENT_TYPE.get(Utilities.parseNamespacedKey(nameLower)); if (componentType == null) { - componentType = DataComponentAdapter.COMPONENTS_BY_PROPERTY.get(nameLower); + componentType = COMPONENTS_BY_PROPERTY.get(nameLower); } return componentType; } diff --git a/paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java b/paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java index 593fd6d2f4..d2e324fb48 100644 --- a/paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java +++ b/paper/src/main/java/com/denizenscript/denizen/paper/properties/ItemRemoved.java @@ -16,7 +16,7 @@ public class ItemRemoved extends ItemProperty { // @input ListTag // @description // Controls the properties explicitly removed from an item. - // This can be used to remove item's default behavior, such as making consumable items un-consumable. + // This can be used to remove item's default behavior, such as making consumable items non-consumable. // See also <@link language Item Components>. // --> diff --git a/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/ItemHelperImpl.java b/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/ItemHelperImpl.java index 0d49eb88c7..9f743d42b0 100644 --- a/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/ItemHelperImpl.java +++ b/v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/ItemHelperImpl.java @@ -1,5 +1,6 @@ package com.denizenscript.denizen.nms.v1_21.helpers; +import com.denizenscript.denizen.Denizen; import com.denizenscript.denizen.nms.interfaces.ItemHelper; import com.denizenscript.denizen.nms.util.PlayerProfile; import com.denizenscript.denizen.nms.v1_21.Handler; @@ -450,7 +451,7 @@ public MapTag getRawComponentsPatch(ItemStack item, boolean excludeHandled) { } RegistryOps registryOps = CraftRegistry.getMinecraftRegistry().createSerializationContext(NbtOps.INSTANCE); CompoundTag nmsPatch = (CompoundTag) DataComponentPatch.CODEC.encodeStart(registryOps, patch).getOrThrow(); - if (excludeHandled) { + if (excludeHandled && Denizen.supportsPaper) { nmsPatch.keySet().removeIf(s -> s.charAt(0) == '!'); if (nmsPatch.isEmpty()) { return new MapTag();