Skip to content

All command responses that have a success or error should use ✅ or ❌ (respectively) #208

@DaRealTurtyWurty

Description

@DaRealTurtyWurty

Primarily in older commands of the bot, there are instances where replying with an error or with a success are not prefixed with a ❌ or ✅ at the start of the reply. Almost all of the new code does this (possibly with some mistaken exceptions), so this (the same as #207) is purely a consistency issue, and since it affects users of the bot, it is quite important.

Finding examples of this may be a little tricky, however using these 2 searches, you should be able to find the ones that are missing them:
https://github.com/search?q=repo%3ADaRealTurtyWurty%2FSuperTurtyBot%20event.deferReply&type=code
https://github.com/search?q=repo%3ADaRealTurtyWurty%2FSuperTurtyBot+reply%28event&type=code

Choosing whether or not it needs the emoji should ideally be decided on a case-by-case basis, as a lot of the time it just doesn't make sense to have either.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomersjavaPull requests that update Java code

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions