fix: removed useless RPC call

Author: fstagni

src/DIRAC/AccountingSystem/Client/AccountingCLI.py

@@ -57,7 +57,6 @@ def showTraceback(self):
         traceback.print_tb(sys.exc_info()[2])
         print("________________________\n")
 
-
     def do_showRegisteredTypes(self, args):
         """
         Get a list of registered types

src/DIRAC/MonitoringSystem/DB/MonitoringDB.py

@@ -447,26 +447,6 @@ def __getRawData(self, typeName, condDict, size=-1):
                 records.append({paramName: getattr(resObj["_source"], paramName) for paramName in paramNames})
             return S_OK(records)
 
-    def getLastDayData(self, typeName, condDict):
-        """
-        It returns the last day data for a given monitoring type.
-
-        :returns: for example
-
-          .. code-block:: python
-
-           {'sort': [{'timestamp': {'order': 'desc'}}],
-            'query': {'bool': {'must': [{'match': {'host': 'dzmathe.cern.ch'}},
-                                        {'match': {'component': 'Bookkeeping_BookkeepingManager'}}]}}}
-
-        :param str typeName: name of the monitoring type
-        :param dict condDict: conditions for the query
-
-                      * key -> name of the field
-                      * value -> list of possible values
-        """
-        return self.__getRawData(typeName, condDict)
-
     def getLimitedData(self, typeName, condDict, size=10):
         """
         Returns a list of records for a given selection.

src/DIRAC/MonitoringSystem/Service/MonitoringHandler.py

@@ -244,24 +244,6 @@ def export_getReport(self, reportRequest):
         reportRequest["generatePlot"] = False
         return reporter.generate(reportRequest)
 
-    types_addMonitoringRecords = [str, list]
-
-    def export_addMonitoringRecords(self, monitoringtype, data):
-        """
-        Bulk insert data directly to the given monitoring type.
-
-        :param str monitoringtype: monitoring type name
-        :param list data: list of documents
-        :returns: S_OK or S_ERROR
-        """
-
-        retVal = self.__db.getIndexName(monitoringtype)
-        if not retVal["OK"]:
-            return retVal
-        prefix = retVal["Value"]
-        gLogger.debug("addMonitoringRecords:", prefix)
-        return self.__db.bulk_index(prefix, data)
-
     types_addRecords = [str, str, list]
 
     def export_addRecords(self, indexname, monitoringType, data):
@@ -290,21 +272,6 @@ def export_deleteIndex(self, indexName):
         gLogger.debug("delete index:", indexName)
         return self.__db.deleteIndex(indexName)
 
-    types_getLastDayData = [str, dict]
-
-    def export_getLastDayData(self, typeName, condDict):
-        """
-        It returns the data from the last day index. Note: we create daily indexes.
-
-        :param str typeName: name of the monitoring type
-        :param dict condDict: conditions for the query
-
-                       * key -> name of the field
-                       * value -> list of possible values
-        """
-
-        return self.__db.getLastDayData(typeName, condDict)
-
     types_getLimitedDat = [str, dict, int]
 
     def export_getLimitedData(self, typeName, condDict, size):

tests/Integration/AccountingSystem/Test_ReportsClient.py

@@ -49,7 +49,3 @@ def test_addAndRemoveStorageOccupancy():
         "StorageElement",
     )
     assert res["OK"], res["Message"]
-
-    # now removing that record
-    res = gDataStoreClient.remove(record)
-    assert res["OK"], res["Message"]

tests/Integration/Monitoring/Test_MonitoringSystem.py

@@ -245,25 +245,3 @@ def test_getReport(putAndDelete):
         },
         "granularity": 1800000,
     }
-
-
-def test_getLastDayData(putAndDelete):
-    params = {"Status": "Running", "Site": "LCG.NIKHEF.nl"}
-    result = client.getLastDayData("WMSHistory", params)
-    assert result["OK"], result["Message"]
-    assert len(result["Value"]) == 2
-    assert sorted(result["Value"][0]) == sorted(
-        [
-            "Status",
-            "Jobs",
-            "JobSplitType",
-            "timestamp",
-            "MinorStatus",
-            "Site",
-            "Reschedules",
-            "ApplicationStatus",
-            "User",
-            "JobGroup",
-            "UserGroup",
-        ]
-    )