+Most of the comments were on improving the readability of the code and streamlining some procedures. In general I found the comments very useful and instructive for myself. With the focus on code quality, they definitely helped me get an outside perspective and thus hopefully helped to make the code more reusable. A detailed review of the algorithmical assumptions would have required more domain knowledge and time, and was thus out of scope, as the reviewer commented. Apart from my initial misunderstanding of the process of setting up notifications, the process was actually really quick and effective. So: 10/10 points, would do it again!
0 commit comments