From 7a6b5747fdab94fb2bf31f7ac36cb3a47245e71c Mon Sep 17 00:00:00 2001
From: Kelly Kinkade <kelly.lynn.martin@gmail.com>
Date: Sun, 17 Aug 2025 16:42:26 -0500
Subject: [PATCH 1/2] add default values for `material` and `mat_index` in
 `reaction_reagentst` and `reaction_productst` child classes

fixes #847
---
 changelog.txt   |  1 +
 df.reaction.xml | 12 ++++++------
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/changelog.txt b/changelog.txt
index 51c43143b..09895d835 100644
--- a/changelog.txt
+++ b/changelog.txt
@@ -19,6 +19,7 @@ Template for new versions:
 # Future
 
 ## Structures
+- added default values for ``material`` and ``mat_index`` in ``reaction_reagentst`` and ``reaction_productst`` child classes
 
 # 52.03-r1.1
 
diff --git a/df.reaction.xml b/df.reaction.xml
index 3060393cc..84d27f02d 100644
--- a/df.reaction.xml
+++ b/df.reaction.xml
@@ -55,8 +55,8 @@
     <class-type type-name='reaction_reagent_itemst' inherits-from='reaction_reagent'>
         <enum base-type='int16_t' name='item_type' type-name='item_type'/>
         <int16_t name='item_subtype' refers-to='(item-subtype-target $$._parent.item_type $)'/>
-        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index'/>
-        <int16_t name='mat_index'/>
+        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' default-value='-1'/>
+        <int16_t name='mat_index' default-value='-1'/>
 
         <stl-string name='reaction_class'/>
         <stl-string name='has_material_reaction_product'/>
@@ -131,8 +131,8 @@
     <class-type type-name='reaction_product_itemst' inherits-from='reaction_product'>
         <enum base-type='int16_t' name='item_type' type-name='item_type'/>
         <int16_t name='item_subtype' refers-to='(item-subtype-target $$._parent.item_type $)'/>
-        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index'/>
-        <int32_t name='mat_index'/>
+        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' default-value='-1'/>
+        <int32_t name='mat_index' default-value='-1'/>
 
         <int16_t name='probability'/>
         <int16_t name='count'/>
@@ -161,8 +161,8 @@
         <enum name='improvement_type' type-name='improvement_type'/>
         <enum base-type='int32_t' name='improvement_specific_type' type-name='itemimprovement_specific_type'/>
 
-        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index'/>
-        <int32_t name='mat_index'/>
+        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' default-value='-1'/>
+        <int32_t name='mat_index' default-value='-1'/>
 
         <int16_t name='probability'/>
 

From 1bd7a15fefe5266f518a06d7f0601c577e5b6adf Mon Sep 17 00:00:00 2001
From: Kelly Kinkade <kelly.lynn.martin@gmail.com>
Date: Sun, 17 Aug 2025 16:57:05 -0500
Subject: [PATCH 2/2] `init-value` not `default-value`
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

d'oh 🤪
---
 df.reaction.xml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/df.reaction.xml b/df.reaction.xml
index 84d27f02d..b6d587366 100644
--- a/df.reaction.xml
+++ b/df.reaction.xml
@@ -55,8 +55,8 @@
     <class-type type-name='reaction_reagent_itemst' inherits-from='reaction_reagent'>
         <enum base-type='int16_t' name='item_type' type-name='item_type'/>
         <int16_t name='item_subtype' refers-to='(item-subtype-target $$._parent.item_type $)'/>
-        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' default-value='-1'/>
-        <int16_t name='mat_index' default-value='-1'/>
+        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' init-value='-1'/>
+        <int16_t name='mat_index' init-value='-1'/>
 
         <stl-string name='reaction_class'/>
         <stl-string name='has_material_reaction_product'/>
@@ -131,8 +131,8 @@
     <class-type type-name='reaction_product_itemst' inherits-from='reaction_product'>
         <enum base-type='int16_t' name='item_type' type-name='item_type'/>
         <int16_t name='item_subtype' refers-to='(item-subtype-target $$._parent.item_type $)'/>
-        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' default-value='-1'/>
-        <int32_t name='mat_index' default-value='-1'/>
+        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' init-value='-1'/>
+        <int32_t name='mat_index' init-value='-1'/>
 
         <int16_t name='probability'/>
         <int16_t name='count'/>
@@ -161,8 +161,8 @@
         <enum name='improvement_type' type-name='improvement_type'/>
         <enum base-type='int32_t' name='improvement_specific_type' type-name='itemimprovement_specific_type'/>
 
-        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' default-value='-1'/>
-        <int32_t name='mat_index' default-value='-1'/>
+        <int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' init-value='-1'/>
+        <int32_t name='mat_index' init-value='-1'/>
 
         <int16_t name='probability'/>