Improve how nils is handled

Author: kean

Sources/URLQueryEncoder/URLQueryEncoder.swift

@@ -73,14 +73,6 @@ public class URLQueryEncoder {
         try? value.encode(to: self)
     }
 
-    #warning("do we need this method?")
-    public func encode<V: Encodable>(_ value: V, forKey key: String, explode: Bool? = nil, delimeter: String? = nil, isDeepObject: Bool? = nil) {
-        _explode = explode ?? self.explode
-        _delimeter = delimeter ?? self.delimeter
-        _isDeepObject = isDeepObject ?? self.isDeepObject
-        try? [key: value].encode(to: self)
-    }
-    
     public static func data(for queryItems: [URLQueryItem]) -> Data {
         var components = URLComponents()
         components.queryItems = queryItems
@@ -89,9 +81,8 @@ public class URLQueryEncoder {
 }
 
 private extension URLQueryEncoder {
-    #warning("test encodeNil extensively!")
     func encodeNil(forKey codingPath: [CodingKey]) throws {
-        queryItems.append(URLQueryItem(name: codingPath.last?.stringValue ?? "", value: nil))
+        // Do nothing
     }
 
     func encode(_ value: String, forKey codingPath: [CodingKey]) throws {

Tests/URLQueryEncoderTests/URLQueryEncoderTests.swift

@@ -204,6 +204,38 @@ final class QueryEncoderTests: XCTestCase {
         XCTAssertEqual(encoder.query, "id[role]=admin&id[name]=kean")
         XCTAssertEqual(encoder.percentEncodedQuery, "id%5Brole%5D=admin&id%5Bname%5D=kean")
     }
+    
+    // MARK: Misc
+    
+    func testMixingDifferentStyles() {
+        // GIVEN
+        let user = User(role: "admin", name: "kean")
+        let ids = [3, 4, 5]
+        
+        // WHEN
+        let encoder = URLQueryEncoder()
+        encoder.encode(["ids": ids], explode: false)
+        encoder.encode(["ids2": ids], explode: true)
+        encoder.encode(["user": user], isDeepObject: true)
+        encoder.encode(["id": 2])
+        
+        // THEN
+        XCTAssertEqual(encoder.query, "ids=3,4,5&ids2=3&ids2=4&ids2=5&user[role]=admin&user[name]=kean&id=2")
+    }
+    
+    // MARK: Encoding Nils
+    
+    func testEncodingNil() {
+        // GIVEN
+        let id: Int? = nil
+        
+        // THEN
+        let encoder = URLQueryEncoder()
+        encoder.encode(["id": id])
+
+        // THEN
+        XCTAssertTrue(encoder.queryItems.isEmpty)
+    }
 }
 
 private struct User: Encodable {