From be50629ab32be382fffa06e2bd4d21c25f12d9f2 Mon Sep 17 00:00:00 2001 From: echobt Date: Mon, 2 Feb 2026 05:00:10 +0000 Subject: [PATCH] fix(clippy): use sort_by_key instead of sort_by for reverse sorting - Fix cortex-apply-patch backup.rs: use sort_by_key with Reverse - Fix cortex-compact log_pruner.rs: use sort_by_key with Reverse These changes address clippy::unnecessary_sort_by warnings. --- src/cortex-apply-patch/src/backup.rs | 2 +- src/cortex-compact/src/auto_compaction/log_pruner.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cortex-apply-patch/src/backup.rs b/src/cortex-apply-patch/src/backup.rs index 8815686a..8529f423 100644 --- a/src/cortex-apply-patch/src/backup.rs +++ b/src/cortex-apply-patch/src/backup.rs @@ -232,7 +232,7 @@ impl BackupManager { } // Sort by timestamp (newest first) - backups.sort_by(|a, b| b.timestamp.cmp(&a.timestamp)); + backups.sort_by_key(|b| std::cmp::Reverse(b.timestamp)); Ok(backups) } diff --git a/src/cortex-compact/src/auto_compaction/log_pruner.rs b/src/cortex-compact/src/auto_compaction/log_pruner.rs index 94cb52a7..6eeca74c 100644 --- a/src/cortex-compact/src/auto_compaction/log_pruner.rs +++ b/src/cortex-compact/src/auto_compaction/log_pruner.rs @@ -96,7 +96,7 @@ impl LogPruner { } // Sort by modified time (newest first) for rotation priority - log_files.sort_by(|a, b| b.modified.cmp(&a.modified)); + log_files.sort_by_key(|f| std::cmp::Reverse(f.modified)); // Process each log file for (idx, log_file) in log_files.iter().enumerate() {