Skip to content

Commit f2e496e

Browse files
authored
Revert "feat: separate cortex-gui into standalone repository (#509)" (#510)
This reverts commit bc7d617.
1 parent bc7d617 commit f2e496e

File tree

11,058 files changed

+1264428
-223
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

11,058 files changed

+1264428
-223
lines changed

Cargo.lock

Lines changed: 4217 additions & 221 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,7 @@ members = [
106106
# ==========================================================================
107107
# Desktop Application (GUI) - Tauri
108108
# ==========================================================================
109-
# NOTE: cortex-gui has been moved to a separate repository: CortexLM/cortex-ide
110-
# See: https://github.com/CortexLM/cortex-ide
109+
"cortex-gui/src-tauri",
111110
]
112111

113112
[workspace.package]

cortex-gui/.env.example

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# API Configuration
2+
# Override the default API URL (defaults to http://127.0.0.1:4096)
3+
VITE_API_URL=http://127.0.0.1:4096

cortex-gui/.gitignore

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
# Dependencies
2+
node_modules/
3+
4+
# Font Awesome Kit (junction to kit-a943e80cf4-desktop)
5+
public/kit-a943e80cf4-desktop/
6+
7+
# Build outputs
8+
dist/
9+
src-tauri/target/
10+
11+
# Logs
12+
*.log
13+
logs/
14+
15+
# IDE
16+
.idea/
17+
.vscode/
18+
*.swp
19+
*.swo
20+
21+
# OS files
22+
.DS_Store
23+
Thumbs.db
24+
25+
# Environment
26+
.env
27+
.env.local
28+
.env.*.local
29+
30+
# Tauri
31+
src-tauri/WixTools/
32+
src-tauri/icons/*.png
33+
src-tauri/icons/*.ico
34+
src-tauri/icons/*.icns

cortex-gui/AUDIT_REPORT.md

Lines changed: 220 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,220 @@
1+
# Deep Audit Report: cortex-gui IDE
2+
3+
## Executive Summary
4+
5+
This audit identified several "Action Gaps" in the cortex-gui IDE where UI elements imply functionality that is missing, broken, or unlinked to the backend. The most significant findings were **29 missing backend commands** that were invoked from the frontend but had no corresponding Tauri command handler.
6+
7+
**Status: FIXED** - This audit has been updated to reflect all fixes implemented through PR #364, #365, and the latest Deep Audit PR.
8+
9+
---
10+
11+
## 1. Critical Failures: Buttons/Elements with No Backend Implementation
12+
13+
### 1.1 Missing Tauri Command Handlers - FIXED (Previous Update)
14+
15+
The following commands were **implemented** in a previous update:
16+
17+
| Command | Status | Implementation |
18+
|---------|--------|----------------|
19+
| `search_replace_all` | ✅ Fixed | Added in `src-tauri/src/search.rs` |
20+
| `search_replace_in_file` | ✅ Fixed | Added in `src-tauri/src/search.rs` |
21+
| `search_replace_match` | ✅ Fixed | Added in `src-tauri/src/search.rs` |
22+
| `notebook_execute_cell` | ✅ Fixed | Added in `src-tauri/src/notebook.rs` |
23+
| `notebook_interrupt_kernel` | ✅ Fixed | Added in `src-tauri/src/notebook.rs` |
24+
| `notebook_shutdown_kernel` | ✅ Fixed | Added in `src-tauri/src/notebook.rs` |
25+
| `notebook_start_kernel` | ✅ Fixed | Added in `src-tauri/src/notebook.rs` |
26+
| `terminate_cortex_process` | ✅ Fixed | Added in `src-tauri/src/process.rs` |
27+
| `git_branch_rename` | ✅ Fixed | Added to `src-tauri/src/git.rs` |
28+
| `git_reset_soft` | ✅ Fixed | Added to `src-tauri/src/git.rs` |
29+
| `git_clean` | ✅ Fixed | Added to `src-tauri/src/git.rs` |
30+
| `git_stage_lines` | ✅ Fixed | Added to `src-tauri/src/git.rs` |
31+
| `git_unstage_lines` | ✅ Fixed | Added to `src-tauri/src/git.rs` |
32+
| `git_remote_add` | ✅ Fixed | Alias added to `src-tauri/src/git.rs` |
33+
| `git_remote_remove` | ✅ Fixed | Alias added to `src-tauri/src/git.rs` |
34+
| `git_remote_rename` | ✅ Fixed | Alias added to `src-tauri/src/git.rs` |
35+
36+
### 1.2 Missing Tauri Command Handlers - FIXED (This Update)
37+
38+
The following commands were **implemented** in this audit update:
39+
40+
| Command | Status | Implementation |
41+
|---------|--------|----------------|
42+
| `debug_terminate` | ✅ Fixed | Added in `src-tauri/src/dap/commands.rs` |
43+
| `debug_disconnect` | ✅ Fixed | Added in `src-tauri/src/dap/commands.rs` |
44+
| `debug_step_into_target` | ✅ Fixed | Added in `src-tauri/src/dap/commands.rs` |
45+
| `tasks_run_task` | ✅ Fixed | Added in `src-tauri/src/tasks.rs` (NEW MODULE) |
46+
| `tasks_list` | ✅ Fixed | Added in `src-tauri/src/tasks.rs` |
47+
| `tasks_get_config` | ✅ Fixed | Added in `src-tauri/src/tasks.rs` |
48+
| `shell_open` | ✅ Fixed | Added in `src-tauri/src/fs.rs` |
49+
| `toggle_devtools` | ✅ Fixed | Added in `src-tauri/src/window.rs` |
50+
51+
### 1.3 Commands Fixed in Latest Deep Audit Update
52+
53+
The following commands were **implemented** in this deep audit:
54+
55+
| Command | Status | Implementation |
56+
|---------|--------|----------------|
57+
| `profiles_save` | ✅ Fixed | Added in `src-tauri/src/settings.rs` |
58+
| `profiles_load` | ✅ Fixed | Added in `src-tauri/src/settings.rs` |
59+
| `remote_forward_port` | ✅ Fixed | Added in `src-tauri/src/remote.rs` |
60+
| `remote_stop_forward` | ✅ Fixed | Added in `src-tauri/src/remote.rs` |
61+
| `rules_save_file` | ✅ Fixed | Added as alias in `src-tauri/src/rules_library.rs` |
62+
| `ssh_save_profile` | ✅ Fixed | Added in `src-tauri/src/ssh_terminal.rs` |
63+
| `ssh_delete_profile` | ✅ Fixed | Added in `src-tauri/src/ssh_terminal.rs` |
64+
| `ssh_generate_profile_id` | ✅ Fixed | Added in `src-tauri/src/ssh_terminal.rs` |
65+
| `ssh_list_profiles` | ✅ Fixed | Added in `src-tauri/src/ssh_terminal.rs` |
66+
| `testing_stop` | ✅ Fixed | Added in `src-tauri/src/testing.rs` |
67+
| `tunnel_close` | ✅ Fixed | Added in `src-tauri/src/remote.rs` |
68+
| `update_extension` | ✅ Fixed | Added in `src-tauri/src/extensions.rs` |
69+
70+
### 1.4 Still Missing (Lower Priority)
71+
72+
The following commands are still missing but are lower priority as they relate to features not yet fully implemented:
73+
74+
| Command | File Location | Impact |
75+
|---------|--------------|--------|
76+
| `ai_cancel_stream` | AIContext.tsx:636 | AI streaming cannot be cancelled (commented out) |
77+
| `apply_workspace_edit` | editor/RenameWidget.tsx | LSP workspace edits (needs LSP integration) |
78+
| `devcontainer_*` | RemoteContext.tsx | DevContainer operations (feature WIP) |
79+
| `vscode_execute_*` | CommandContext.tsx | VS Code command execution |
80+
81+
### 1.5 Empty Action Handlers (Acceptable)
82+
83+
**File: DiagnosticsPanel.tsx:409**
84+
```typescript
85+
action: () => {}, // Divider item - intentionally empty
86+
```
87+
88+
**File: OpenWithMenu.tsx:691**
89+
```typescript
90+
action: () => {}, // Separator item - intentionally empty
91+
```
92+
93+
These are separators/dividers in menus and are acceptable.
94+
95+
---
96+
97+
## 2. Broken Bridges: Frontend/Backend Signature Mismatches - FIXED
98+
99+
### 2.1 Command Name Mismatches - RESOLVED
100+
101+
| Frontend Invoke | Backend Command | Status |
102+
|-----------------|-----------------|--------|
103+
| `git_remote_add` | `git_add_remote` | ✅ Alias added |
104+
| `git_remote_remove` | `git_remove_remote` | ✅ Alias added |
105+
| `git_remote_rename` | `git_rename_remote` | ✅ Alias added |
106+
| `testing_stop` | `testing_stop` | ✅ Now implemented properly |
107+
108+
---
109+
110+
## 3. UX Improvements: Missing Feedback (Unchanged)
111+
112+
### 3.1 Missing Loading States
113+
114+
| Component | Issue | Recommendation |
115+
|-----------|-------|----------------|
116+
| `AutoUpdateContext.tsx` | No progress indicator for update download | Add progress bar |
117+
| `ExtensionsContext.tsx` | Extension installation lacks progress | Add activity indicator |
118+
| `MultiRepoContext.tsx` | Git operations need loading states | Show spinner during operations |
119+
| `NotebookContext.tsx` | Kernel operations should show activity | Add kernel status indicator |
120+
121+
### 3.2 Silent Error Handling
122+
123+
Multiple components catch errors but don't propagate them to the user:
124+
125+
**Pattern found:**
126+
```typescript
127+
.catch((e) => {
128+
console.error("Operation failed:", e);
129+
// No user notification!
130+
});
131+
```
132+
133+
**Recommendation:** Replace with toast notifications:
134+
```typescript
135+
.catch((e) => {
136+
notifications.show({
137+
type: "error",
138+
title: "Operation failed",
139+
body: e.message
140+
});
141+
});
142+
```
143+
144+
---
145+
146+
## 4. Navigation & UI Integrity
147+
148+
### 4.1 Activity Bar Items - All Working ✅
149+
150+
All activity bar items have proper `onClick` handlers:
151+
- Explorer ✅
152+
- Search ✅
153+
- Source Control ✅
154+
- Debug ✅
155+
- Extensions ✅
156+
- Agents ✅
157+
- Factory ✅
158+
- Testing ✅
159+
- Remote ✅
160+
161+
### 4.2 Menu Bar Actions - All Working ✅
162+
163+
The `MenuBar.tsx` component has comprehensive menu items with proper actions.
164+
165+
---
166+
167+
## 5. Files Modified in This Fix
168+
169+
### Previous Update
170+
1. **`src-tauri/src/search.rs`** (NEW) - Search and replace commands
171+
2. **`src-tauri/src/notebook.rs`** (NEW) - Notebook kernel commands
172+
3. **`src-tauri/src/process.rs`** (NEW) - Process management commands
173+
4. **`src-tauri/src/git.rs`** - Added missing git commands and aliases
174+
5. **`src-tauri/src/lib.rs`** - Registered all new commands
175+
176+
### This Update (PR #364)
177+
1. **`src-tauri/src/tasks.rs`** (NEW) - VS Code-style tasks.json runner
178+
2. **`src-tauri/src/dap/commands.rs`** - Added debug_terminate, debug_disconnect, debug_step_into_target
179+
3. **`src-tauri/src/fs.rs`** - Added shell_open command
180+
4. **`src-tauri/src/window.rs`** - Added toggle_devtools command
181+
5. **`src-tauri/src/lib.rs`** - Registered all new commands
182+
183+
### Deep Audit Update (PR #366)
184+
1. **`src-tauri/src/extensions.rs`** - Added update_extension command
185+
2. **`src-tauri/src/settings.rs`** - Added profiles_save and profiles_load commands
186+
3. **`src-tauri/src/remote.rs`** - Added remote_forward_port, remote_stop_forward, tunnel_close
187+
4. **`src-tauri/src/ssh_terminal.rs`** - Added SSH profile management commands
188+
5. **`src-tauri/src/rules_library.rs`** - Added rules_save_file alias
189+
6. **`src-tauri/src/testing.rs`** - Added testing_stop command
190+
7. **`src-tauri/src/notebook.rs`** - Fixed missing Emitter import
191+
8. **`src-tauri/src/search.rs`** - Fixed serde attribute issue in ReplaceMatchRequest
192+
9. **`src-tauri/src/lib.rs`** - Registered all new commands (12 additional commands)
193+
194+
---
195+
196+
## 6. Remaining Work (Future PRs)
197+
198+
1. **DevContainer Support** - Full implementation of devcontainer_* commands
199+
2. **VSCode Compatibility** - vscode_execute_* commands for extension compatibility
200+
3. **AI Stream Cancellation** - ai_cancel_stream implementation
201+
4. **LSP Workspace Edits** - apply_workspace_edit for rename refactoring
202+
203+
---
204+
205+
## Appendix: Statistics
206+
207+
- Total unique invoke commands in frontend: **214**
208+
- Backend commands registered: **542+**
209+
- Commands fixed in previous updates: **24**
210+
- Commands fixed in this deep audit: **12**
211+
- Commands still missing (low priority): **~4**
212+
213+
---
214+
215+
## Audit Details
216+
217+
- **Date**: 2026-01-27
218+
- **Branch**: master
219+
- **Commit**: Deep audit fix PR
220+
- **Auditor**: AI-assisted deep audit

0 commit comments

Comments
 (0)