Skip to content

Commit b31ea43

Browse files
committed
Try to guard against StructureTemplate loading mixins early
RE: #653
1 parent a3f1563 commit b31ea43

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

.github/workflows/ci-builds.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ env:
66
on:
77
workflow_dispatch:
88
push:
9-
tags-ignore:
10-
- "v**"
119
paths:
1210
- "gradle/*.versions.toml"
1311
- "core-api/**/*"
@@ -33,7 +31,7 @@ jobs:
3331

3432
- name: Version
3533
id: version
36-
uses: paulhatch/semantic-version@v5.4.0
34+
uses: paulhatch/semantic-version@v6.0.1
3735
with:
3836
version_format: "${major}.${minor}.${patch}"
3937
search_commit_body: true
@@ -66,7 +64,7 @@ jobs:
6664
runs-on: ubuntu-latest
6765
steps:
6866
- name: Create tag
69-
uses: actions/github-script@v7
67+
uses: actions/github-script@v8
7068
with:
7169
script: |
7270
github.rest.git.createRef({

neoforge-main/src/main/java/dev/compactmods/machines/network/machine/OpenMachinePreviewScreenPacket.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,31 +4,32 @@
44
import dev.compactmods.machines.api.CompactMachines;
55
import dev.compactmods.machines.client.machine.ClientMachinePacketHandler;
66
import dev.compactmods.machines.util.codec.VanillaCodecs;
7+
import net.minecraft.Util;
78
import net.minecraft.core.GlobalPos;
89
import net.minecraft.network.FriendlyByteBuf;
910
import net.minecraft.network.codec.ByteBufCodecs;
1011
import net.minecraft.network.codec.StreamCodec;
1112
import net.minecraft.network.protocol.common.custom.CustomPacketPayload;
1213
import net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplate;
1314
import net.neoforged.neoforge.network.handling.IPayloadHandler;
15+
import org.jetbrains.annotations.NotNull;
1416

1517
public record OpenMachinePreviewScreenPacket(GlobalPos machinePos, String roomCode, StructureTemplate internalBlocks) implements CustomPacketPayload {
1618

1719
public static final Type<OpenMachinePreviewScreenPacket> TYPE = new Type<>(CompactMachines.modRL("open_machine_preview_screen"));
1820

19-
public static final StreamCodec<FriendlyByteBuf, OpenMachinePreviewScreenPacket> STREAM_CODEC = StreamCodec.composite(
21+
public static final StreamCodec<FriendlyByteBuf, OpenMachinePreviewScreenPacket> STREAM_CODEC = Util.make(() -> StreamCodec.composite(
2022
GlobalPos.STREAM_CODEC, OpenMachinePreviewScreenPacket::machinePos,
2123
ByteBufCodecs.STRING_UTF8, OpenMachinePreviewScreenPacket::roomCode,
2224
VanillaCodecs.STRUCTURE_TEMPLATE_STREAM_CODEC, OpenMachinePreviewScreenPacket::internalBlocks,
2325
OpenMachinePreviewScreenPacket::new
24-
);
26+
));
2527

26-
public static final IPayloadHandler<OpenMachinePreviewScreenPacket> HANDLER = (pkt, ctx) -> {
27-
ClientMachinePacketHandler.openRoomPreviewScreen(pkt);
28-
};
28+
public static final IPayloadHandler<OpenMachinePreviewScreenPacket> HANDLER = (pkt, ctx)
29+
-> ClientMachinePacketHandler.openRoomPreviewScreen(pkt);
2930

3031
@Override
31-
public Type<? extends CustomPacketPayload> type() {
32+
public @NotNull Type<? extends CustomPacketPayload> type() {
3233
return TYPE;
3334
}
3435
}

neoforge-main/src/main/java/dev/compactmods/machines/network/room/InitialRoomBlockDataPacket.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,27 +3,28 @@
33
import dev.compactmods.machines.api.CompactMachines;
44
import dev.compactmods.machines.client.room.ClientRoomPacketHandler;
55
import dev.compactmods.machines.util.codec.VanillaCodecs;
6+
import net.minecraft.Util;
67
import net.minecraft.network.FriendlyByteBuf;
78
import net.minecraft.network.codec.StreamCodec;
89
import net.minecraft.network.protocol.common.custom.CustomPacketPayload;
910
import net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplate;
1011
import net.neoforged.neoforge.network.handling.IPayloadHandler;
12+
import org.jetbrains.annotations.NotNull;
1113

1214
public record InitialRoomBlockDataPacket(StructureTemplate blocks) implements CustomPacketPayload {
1315

1416
public static final CustomPacketPayload.Type<InitialRoomBlockDataPacket> TYPE = new CustomPacketPayload.Type<>(CompactMachines.modRL("initial_room_block_data"));
1517

16-
public static final StreamCodec<FriendlyByteBuf, InitialRoomBlockDataPacket> STREAM_CODEC = StreamCodec.composite(
18+
public static final StreamCodec<FriendlyByteBuf, InitialRoomBlockDataPacket> STREAM_CODEC = Util.make(() -> StreamCodec.composite(
1719
VanillaCodecs.STRUCTURE_TEMPLATE_STREAM_CODEC, InitialRoomBlockDataPacket::blocks,
1820
InitialRoomBlockDataPacket::new
19-
);
21+
));
2022

21-
public static final IPayloadHandler<InitialRoomBlockDataPacket> HANDLER = (pkt, ctx) -> {
22-
ctx.enqueueWork(() -> ClientRoomPacketHandler.handleBlockData(pkt.blocks));
23-
};
23+
public static final IPayloadHandler<InitialRoomBlockDataPacket> HANDLER = (pkt, ctx)
24+
-> ctx.enqueueWork(() -> ClientRoomPacketHandler.handleBlockData(pkt.blocks));
2425

2526
@Override
26-
public Type<? extends CustomPacketPayload> type() {
27+
public @NotNull Type<? extends CustomPacketPayload> type() {
2728
return TYPE;
2829
}
2930
}

0 commit comments

Comments
 (0)