Merge branch 'main' into fix_converter_sample

Author: Avid29

.github/workflows/build.yml

@@ -158,6 +158,13 @@ jobs:
         id: test-generator
         run: vstest.console.exe ./tooling/CommunityToolkit.Tooling.SampleGen.Tests/bin/Release/net8.0/CommunityToolkit.Tooling.SampleGen.Tests.dll /logger:"trx;LogFileName=SourceGenerators.trx"
 
+      - name: Start Procdump monitoring for first-chance exceptions
+        if: ${{ (matrix.multitarget == 'uwp' || matrix.multitarget == 'wasdk') && env.ENABLE_DIAGNOSTICS == 'true' }}
+        shell: pwsh
+        run: |
+          $procdumpArgs = @("-accepteula", "-e", "1", "-w", "CommunityToolkit.Tests.${{ matrix.multitarget }}.exe", "-ma", "${{ env.PROCDUMP_PATH }}")
+          Start-Process -FilePath "${{ env.PROCDUMP_PATH }}/procdump64.exe" -ArgumentList $procdumpArgs -NoNewWindow
+
       - name: Run component tests against ${{ matrix.multitarget }}
         if: ${{ matrix.multitarget == 'uwp' || matrix.multitarget == 'wasdk' }}
         id: test-platform
@@ -467,3 +474,4 @@ jobs:
         with:
           name: linux-logs
           path: ./**/*.*log
+

components/Extensions/src/Shadows/AttachedShadowBase.cs

@@ -161,8 +161,8 @@ protected internal virtual void OnElementContextInitialized(AttachedShadowElemen
     /// <param name="context">The <see cref="AttachedShadowElementContext"/> that is being uninitialized.</param>
     protected internal virtual void OnElementContextUninitialized(AttachedShadowElementContext context)
     {
-        context.ClearAndDisposeResources();
         ElementCompositionPreview.SetElementChildVisual(context.Element, null!);
+        context.ClearAndDisposeResources();
     }
 
     /// <inheritdoc/>

components/Extensions/src/Shadows/AttachedShadowElementContext.cs

@@ -135,6 +135,12 @@ private void Uninitialize()
 
         IsInitialized = false;
 
+        if (Element != null)
+        {
+            ElementCompositionPreview.SetElementChildVisual(Element, null!);
+            Element.SizeChanged -= OnElementSizeChanged;
+        }
+
         Parent.OnElementContextUninitialized(this);
 
         if (SpriteVisual != null)
@@ -148,12 +154,6 @@ private void Uninitialize()
             Shadow.Dispose();
         }
 
-        if (Element != null)
-        {
-            ElementCompositionPreview.SetElementChildVisual(Element, null!);
-            Element.SizeChanged -= OnElementSizeChanged;
-        }
-
         SpriteVisual = null;
         Shadow = null;
         ElementVisual = null;