Skip to content

Commit c7c0190

Browse files
authored
Merge pull request #328 from ligangty/radas-umb
Chore: RADAS: some logging adjustment
2 parents 0c17fe3 + b7ec978 commit c7c0190

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

charon/pkgs/radas_sign.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
from typing import List, Any, Tuple, Callable, Dict, Optional
2525
from charon.config import RadasConfig
2626
from charon.pkgs.oras_client import OrasClient
27+
from charon.utils import files
2728
from proton import SSLDomain, Message, Event, Sender, Connection
2829
from proton.handlers import MessagingHandler
2930
from proton.reactor import Container
@@ -327,20 +328,25 @@ async def generate_single_sign_file(
327328
signature_path = os.path.join(top_level, asc_filename)
328329

329330
if not os.path.isfile(artifact_path):
330-
logger.warning("Artifact missing, skip signature file generation")
331+
logger.warning(
332+
"Artifact %s missing, skip signature file generation.",
333+
artifact_path)
331334
return
332335

333336
try:
334-
with open(signature_path, "w") as asc_file:
335-
asc_file.write(signature)
337+
files.overwrite_file(signature_path, signature)
336338
generated_signs.append(signature_path)
337-
logger.info("Generated .asc file: %s", signature_path)
339+
logger.debug("Generated .asc file: %s", signature_path)
338340
except Exception as e:
339341
failed_paths.append(signature_path)
340342
logger.error("Failed to write .asc file for %s: %s", artifact_path, e)
341343

342344
result = data.get("results", [])
343-
return __do_path_cut_and(path_handler=generate_single_sign_file, data=result)
345+
(_failed_metas, _generated_signs) = __do_path_cut_and(generate_single_sign_file, result)
346+
logger.info(
347+
"Signature generation done. There are %s signature files generated.",
348+
len(_generated_signs))
349+
return (_failed_metas, _generated_signs)
344350

345351

346352
def __do_path_cut_and(

0 commit comments

Comments
 (0)